Skip to content

[recoveryservicesbackup] minor fix for long running operation customer issue #36557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[recoveryservicesbackup] minor fix for long running operation customer issue #36557

wants to merge 1 commit into from

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Aug 8, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 8, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 8, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Aug 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.RecoveryServices
Java com.azure.resourcemanager:azure-resourcemanager-recoveryservicesbackup
JavaScript @azure/arm-recoveryservicesbackup
Python azure-mgmt-recoveryservicesbackup
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup

@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Go-Sdk labels Aug 8, 2025
@hiaga hiaga added Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 AzCoreIDC labels Aug 10, 2025
@mikekistler mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Aug 10, 2025
@hiaga hiaga added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 11, 2025
@hiaga
Copy link
Member Author

hiaga commented Aug 11, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Aug 11, 2025
@pcsin
Copy link

pcsin commented Aug 12, 2025

Some of the automated checks are failing, and from the initial review the change is not following the async provisioning guide - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#asynchronous-operations

Pls ensure the swagger lint checks pass.

@pcsin pcsin added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 12, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@josefree
Copy link
Member

A PR converting this service to TypeSpec has been prepped by the Azure SDK team as part of the drive to move all existing Azure services to use TypeSpec. The PR for this is
#35709
. The team owning this service will need to validate the PR, address any highlighted linter failures, make any service-specific changes to the PR, have a review with ARM, and complete the PR before any additional work can be done on the service. Information regarding how to do this finalization and who to contact for assistance are at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/2700/docs/migrate-swagger/01-get-started/#review-and-adjust-the-typespec. Going forward, any change to the service spec will need to be performed with TypeSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview AzCoreIDC BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. Recovery Services Backup resource-manager service-under-conversion Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hiaga @pcsin @josefree @AzureRestAPISpecReview @mikekistler