Skip to content

Add clusterResourceGroupAuthType field to HDInsight Ondemand cluster … #37910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2025
Merged

Add clusterResourceGroupAuthType field to HDInsight Ondemand cluster … #37910

merged 3 commits into from
Oct 17, 2025

Conversation

nakul16168
Copy link
Contributor

…linked service swagger definition for Datafactory and Synapse

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Add clusterResourceGroupAuthType field to HDInsight Ondemand cluster …
ef14455 
…linked service swagger definition for Datafactory and Synapse
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview data-plane resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DataFactory-DataFactory
Swagger Microsoft.Synapse
Go sdk/resourcemanager/datafactory/armdatafactory
Java com.azure.resourcemanager:azure-resourcemanager-datafactorydatafactory
JavaScript @azure/arm-datafactory
C# Azure.ResourceManager.DataFactory

@github-actions github-actions bot added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2025
@JeffreyRichter JeffreyRichter added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 6, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 6, 2025
@mentat9
Copy link
Member

mentat9 commented Oct 6, 2025

@nakul16168 - Please submit the dataplane changes in a separate PR. This repo handles either a CP or DP PR, not a single PR for both. ARM reviewers don't review or approve dataplane changes.

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 6, 2025
@nakul16168
Copy link
Contributor Author

@mentat9

These changes are simple changes to update the Swagger definition for linked service payload for a single activity. We have been making similar changes for sometime now. Reference PR's:

#36664
#33955

There is no risk involved here as these are new fields.

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 14, 2025
@psah434 psah434 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 15, 2025
@Jingshu918 Jingshu918 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 17, 2025
@Jingshu918 Jingshu918 enabled auto-merge (squash) October 17, 2025 00:36
@Jingshu918 Jingshu918 merged commit a39b73b into main Oct 17, 2025
40 of 41 checks passed
@Jingshu918 Jingshu918 deleted the dev/nramanathan/updateHdinsightOndemandLinkedService branch October 17, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruowan ruowan ruowan approved these changes

@wanyang7 wanyang7 wanyang7 approved these changes

@Frey-Wang Frey-Wang Awaiting requested review from Frey-Wang Frey-Wang is a code owner

@davidzhaoyue davidzhaoyue Awaiting requested review from davidzhaoyue davidzhaoyue is a code owner

Assignees

No one assigned

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nakul16168 @mentat9 @ruowan @wanyang7 @JeffreyRichter @psah434 @Jingshu918