Skip to content

Conversation

nakul16168
Copy link
Contributor

…linked service swagger definition for Datafactory and Synapse

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

…linked service swagger definition for Datafactory and Synapse
Copy link

github-actions bot commented Oct 3, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview data-plane resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DataFactory-DataFactory
Swagger Microsoft.Synapse
Go sdk/resourcemanager/datafactory/armdatafactory
Java com.azure.resourcemanager:azure-resourcemanager-datafactorydatafactory
JavaScript @azure/arm-datafactory
C# Azure.ResourceManager.DataFactory

@github-actions github-actions bot added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2025
@JeffreyRichter JeffreyRichter added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 6, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 6, 2025
@mentat9
Copy link
Member

mentat9 commented Oct 6, 2025

@nakul16168 - Please submit the dataplane changes in a separate PR. This repo handles either a CP or DP PR, not a single PR for both. ARM reviewers don't review or approve dataplane changes.

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested ARMReview data-plane resource-manager Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants