diff --git a/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts b/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts index 99bc46be890a..f8ad13d7a7bc 100644 --- a/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts +++ b/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts @@ -250,7 +250,7 @@ function skipForRestLevelClientOrManagementPlaneInTsEmitter( folder: string, ): SkipResult { const isRLCClient = - config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] !== true; + config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] === false; const shouldSkip = isManagementSdk(folder) || isRLCClient; const result: SkipResult = { shouldSkip: shouldSkip, @@ -262,7 +262,7 @@ function skipForRestLevelClientOrManagementPlaneInTsEmitter( function skipForModularOrManagementPlaneInTsEmitter(config: any, folder: string): SkipResult { const isModularClient = - config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] === true; + config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] !== false; const shouldSkip = isManagementSdk(folder) || isModularClient; const result: SkipResult = { shouldSkip: shouldSkip, diff --git a/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts b/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts index 22ea52ec2b5d..ec06edf98465 100644 --- a/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts +++ b/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts @@ -247,6 +247,8 @@ const tsDpEmitterOutputDirTestCases = createEmitterOptionTestCases( "{output-dir}/{service-dir}/arm-aaa-rest", "{output-dir}/{service-dir}/aaa--rest", [new TspConfigTsDpEmitterOutputDirSubRule()], + false, + { "is-modular-library": false }, ); const tsDpPackageNameTestCases = createEmitterOptionTestCases( @@ -256,6 +258,8 @@ const tsDpPackageNameTestCases = createEmitterOptionTestCases( "@azure-rest/aaa-bbb", "@azure/aaa-bbb", [new TspConfigTsRlcDpPackageNameMatchPatternSubRule()], + false, + { "is-modular-library": false }, ); const tsDpModularPackageNameTestCases = createEmitterOptionTestCases( diff --git a/specification/confidentialledger/data-plane/ConfidentialLedger/tspconfig.yaml b/specification/confidentialledger/data-plane/ConfidentialLedger/tspconfig.yaml index 97e67515fad9..6cea243102c2 100644 --- a/specification/confidentialledger/data-plane/ConfidentialLedger/tspconfig.yaml +++ b/specification/confidentialledger/data-plane/ConfidentialLedger/tspconfig.yaml @@ -36,5 +36,6 @@ options: "name": "@azure-rest/azure-confidentialledger" description: "Microsoft Confidential Ledger" "flavor": "azure" + is-modular-library: false generate-metadata: true generate-sample-project: false diff --git a/specification/confidentialledger/data-plane/ConfidentialLedgerIdentity/tspconfig.yaml b/specification/confidentialledger/data-plane/ConfidentialLedgerIdentity/tspconfig.yaml index 35d1c01761f6..12608c4275c3 100644 --- a/specification/confidentialledger/data-plane/ConfidentialLedgerIdentity/tspconfig.yaml +++ b/specification/confidentialledger/data-plane/ConfidentialLedgerIdentity/tspconfig.yaml @@ -36,5 +36,6 @@ options: "name": "@azure-rest/azure-confidentialledger-certificate" description: "Microsoft Confidential Ledger Certificate" "flavor": "azure" + is-modular-library: false generate-metadata: true generate-sample-project: false diff --git a/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml b/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml index 2e79b67159f8..6f9f92cebefb 100644 --- a/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml +++ b/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml @@ -32,7 +32,6 @@ options: model-namespace: false "@azure-tools/typespec-ts": emitter-output-dir: "{output-dir}/{service-dir}/contoso-widgetmanager" - is-modular-library: true package-details: name: "@azure/contoso-widgetmanager" flavor: azure