add TSV rules for CShanpc and fix reslove placeholder variable #38924
+489
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛Comment generated by summarize-checks workflow run. |
MaryGao
reviewed
Nov 25, 2025
eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts
Outdated
Show resolved
Hide resolved
MaryGao
reviewed
Nov 25, 2025
| [new TspConfigCsharpMgmtNamespaceSubRule()], | ||
| ); | ||
|
|
||
| const httpClientCsharpAzEmitterOutputTestCases = createEmitterOptionTestCases( |
Member
There was a problem hiding this comment.
Could you highlight the test cases for warning without tspconfig definition? And test case for error because of wrong definition?
Contributor
Author
There was a problem hiding this comment.
warning without tspconfig definition:
https://github.com/Azure/azure-rest-api-specs/blob/kyle/httpClientCsharpRules/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts#L751C1-L909C3
test case for error because of wrong definition:
https://github.com/Azure/azure-rest-api-specs/blob/kyle/httpClientCsharpRules/eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts#L722C1-L734C5
MaryGao
changed the title
skywing918
changed the title
MaryGao
reviewed
Nov 25, 2025
| return option; | ||
| } | ||
|
|
||
| protected resolveVariables(value: string, config: any): { resolved: string; error?: string } { |
…ing createFailedResult method to include failure types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #38964
fix Azure/azure-sdk-tools#12435
add HTTP client C# rules for emitter output directory and namespace validation
Azure/azure-sdk-tools#12435
add a new TSV validation rule specifically targeting the csharp.
tspconfig samples:
@azure-typespec/http-client-csharp-mgmt
@azure-typespec/http-client-csharp
If @azure-typespec/http-client-csharp-mgmt and @azure-typespec/http-client-csharp are configured, validate that their values are correct; otherwise, show a warning if
not find.