Skip to content

Move sre agent resources into separate folder#39437

Merged
LaylaLiu-gmail merged 4 commits intoAzure:release-app-Microsoft.App-stable/2026-01-01from
LaylaLiu-gmail:user/layliu/UpdateSreAgent
Jan 29, 2026
Merged

Move sre agent resources into separate folder#39437
LaylaLiu-gmail merged 4 commits intoAzure:release-app-Microsoft.App-stable/2026-01-01from
LaylaLiu-gmail:user/layliu/UpdateSreAgent

Conversation

@LaylaLiu-gmail
Copy link
Contributor

@LaylaLiu-gmail LaylaLiu-gmail commented Jan 5, 2026

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/appcontainers/armappcontainers
Go sdk/resourcemanager/sreagent/armsreagent
Java com.azure.resourcemanager:azure-resourcemanager-appcontainers
JavaScript @azure/arm-appcontainers
Python azure-mgmt-appcontainers
Python azure-mgmt-sreagent
JavaScript @azure/arm-sreagent
TypeSpec Microsoft.App
Java com.azure.resourcemanager:azure-resourcemanager-sreagent

@ravimeda
Copy link
Member

ravimeda commented Jan 5, 2026

Please address the 'Required' checks that are failing.

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 5, 2026
@ravimeda
Copy link
Member

ravimeda commented Jan 5, 2026

Please address the 'Required' checks that are failing.

@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/UpdateSreAgent branch 2 times, most recently from 3eff87d to 467c5c6 Compare January 6, 2026 03:23
@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/UpdateSreAgent branch from 467c5c6 to 40b9213 Compare January 6, 2026 03:47
@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/UpdateSreAgent branch 5 times, most recently from c3797c0 to 7473076 Compare January 27, 2026 02:45
@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/UpdateSreAgent branch from 7473076 to 6531806 Compare January 27, 2026 03:57
@josefree josefree removed the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 27, 2026
@qiaozha
Copy link
Member

qiaozha commented Jan 27, 2026

If this is a new service with new SDK, it should onboard from TypeSpec. /cc @josefree

Copy link
Member

@josefree josefree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new service of Microsoft.App. Not a brownfield service. It is Greenfield. The service should use TypeSpec.

@github-actions github-actions bot added TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. labels Jan 27, 2026
@LaylaLiu-gmail
Copy link
Contributor Author

This is a new service of Microsoft.App. Not a brownfield service. It is Greenfield. The service should use TypeSpec.

Have changed to typespec, please help review again

@razvanbadea-msft
Copy link
Member

razvanbadea-msft commented Jan 27, 2026

So this pr has a convert to typespec and some folder organization. If the agents are moved wonder if there is any customer impact as i see it is for a stable version

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2026
@LaylaLiu-gmail
Copy link
Contributor Author

So this pr has a convert to typespec and some folder organization. If the agents are moved wonder if there is any customer impact as i see it is for a stable version

This change is never merged to main branch yet. So, it won't break anything.

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 28, 2026
@razvanbadea-msft razvanbadea-msft added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jan 28, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 28, 2026
@LaylaLiu-gmail LaylaLiu-gmail merged commit 9ea818a into Azure:release-app-Microsoft.App-stable/2026-01-01 Jan 29, 2026
66 checks passed
LaylaLiu-gmail added a commit to LaylaLiu-gmail/azure-rest-api-specs that referenced this pull request Jan 29, 2026
* Move sre agent resources into separate folder and use TypeSpec

---------

Co-authored-by: Layla Liu <layliu+microsoft@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants