Certs update (#6507)

* generate code and build the generated code

* client

* update name

* put back things

* work in progress for get

* get and get version

* das

* issuer ops

* set/get/delete contacts

* backup restore

* Get /update policy

* purge

* get deleted

* Update props

* Merge cert

* import cert

* Create

* Start delete

* Recover

* Delete/Cacel op

* GetCertsProps

* Get versions

* get deleted certs

* getissuers

* some cleanup and tests all working

* samples

* test record

* PR build

* more PR stuffs

* PR update part i lost count

* clang

* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-basic-operations/certificate_basic_operations.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-get-certificates/certificate_get_certificates.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-import-certificate/certificate_import_certificate.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/test/ut/certificate_client_base_test.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/test/ut/certificate_client_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* comments

* explicitly turn off

* friend comments

* clang

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

Author: gearama

.vscode/cspell.json

@@ -48,6 +48,7 @@
     "sdk/storage/*/NOTICE.txt",
     "sdk/tables/*/NOTICE.txt",
     "sdk/keyvault/azure-security-keyvault-keys/src/generated/*",
+    "sdk/keyvault/azure-security-keyvault-certificates/src/generated/*",
   ],
   // * Unless configured otherwise, these words are not case sensitive
   // * Alphabetize the list when making changes so the list is easier for future

sdk/keyvault/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "cpp",
   "TagPrefix": "cpp/keyvault",
-  "Tag": "cpp/keyvault_28cdcba8d8"
+  "Tag": "cpp/keyvault_963756fe61"
 }

sdk/keyvault/azure-security-keyvault-certificates/CMakeLists.txt

@@ -46,6 +46,25 @@ elseif(NOT AZ_ALL_LIBRARIES)
   endif()
 endif()
 
+option(AZURE_TSP_KV_CERTIFICATES_GEN "Generate KeyVault Certificates from TypeSpec" OFF)
+message("KeyVault Secrets TSP Generation ${AZURE_TSP_KV_CERTIFICATES_GEN}")
+
+if(AZURE_TSP_KV_CERTIFICATES_GEN)
+    include(TSPCompile) 
+    #typespec related repo information
+    set(TSP_SERVICE_PATH "Security.KeyVault.Certificates")
+    set(TSP_DESTINATION "keyvault_certificates")
+    
+    #codegen related repo information
+    set(CODEGEN_SHA "83758baff29b89a8a7bd28fa26a692225f4f208f")
+    set(CODEGEN_DESTINATION "typespec-cpp")
+       
+    #destination folders
+    set(GEN_FILES_DESTINATION "${CMAKE_CURRENT_SOURCE_DIR}")
+    #generate code from typespec
+    GenerateCodeFromTypeSpec(${TSP_DESTINATION} ${TSP_SERVICE_PATH} ${CODEGEN_SHA} ${CODEGEN_DESTINATION} ${GEN_FILES_DESTINATION} OFF)
+endif()
+
 set(
   AZURE_KEYVAULT_CERTIFICATES_HEADER
     inc/azure/keyvault/certificates.hpp
@@ -62,13 +81,24 @@ set(
     src/certificate_client.cpp
     src/certificate_client_models.cpp
     src/certificate_client_operations.cpp
-    src/certificate_client_paged_response.cpp
-    src/certificate_serializers.cpp
+    src/certificate_client_paged_response.cpp    
     src/keyvault_certificates_common_request.cpp
     src/private/certificate_constants.hpp
     src/private/certificate_serializers.hpp
     src/private/keyvault_certificates_common_request.hpp
     src/private/package_version.hpp
+    #generated code
+    src/generated/certificates_models.hpp
+    src/generated/certificates.cpp
+    src/generated/get_certificate_issuers_paged_response.cpp
+    src/generated/get_certificate_versions_paged_response.cpp
+    src/generated/get_certificates_paged_response.cpp
+    src/generated/get_deleted_certificates_paged_response.cpp
+    src/generated/key_vault_client_options.hpp
+    src/generated/key_vault_client_paged_responses.hpp
+    src/generated/key_vault_client.cpp
+    src/generated/key_vault_client.hpp
+    #done generated code
 )
 
 add_library(azure-security-keyvault-certificates

sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp

@@ -27,6 +27,9 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
     class KeyVaultCertificateClientTest;
   }
 #endif
+  namespace _detail {
+    class KeyVaultClient;
+  }
   /**
    * @brief The CertificateClient provides synchronous methods to manage KeyVaultCertificate in
    * Azure Key Vault.
@@ -45,6 +48,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
     Azure::Core::Url m_vaultUrl;
     std::string m_apiVersion;
     std::shared_ptr<Azure::Core::Http::_internal::HttpPipeline> m_pipeline;
+    std::shared_ptr<_detail::KeyVaultClient> m_client;
 
   public:
     /**
@@ -504,18 +508,5 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
     Azure::Response<CertificateOperationProperties> CancelPendingCertificateOperation(
         std::string const& certificateName,
         Azure::Core::Context const& context = Azure::Core::Context()) const;
-
-    std::unique_ptr<Azure::Core::Http::RawResponse> SendRequest(
-        Azure::Core::Http::Request& request,
-        Azure::Core::Context const& context) const;
-
-    Azure::Core::Http::Request CreateRequest(
-        Azure::Core::Http::HttpMethod method,
-        std::vector<std::string> const& path = {},
-        Azure::Core::IO::BodyStream* content = nullptr) const;
-
-    Azure::Core::Http::Request ContinuationTokenRequest(
-        std::vector<std::string> const& path,
-        const Azure::Nullable<std::string>& NextPageToken) const;
   };
 }}}} // namespace Azure::Security::KeyVault::Certificates