[App Configuration] fix lint error and remove build tags for go 1.18 (#25683)

* fix lint error and remove build tags for go 1.18

* update

* update coverage goal

* add more tests

* update

Author: linglingye001

sdk/data/azappconfig/client.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
@@ -156,7 +153,7 @@ func (c *Client) GetSetting(ctx context.Context, key string, options *GetSetting
 	return GetSettingResponse{
 		Setting:      settingFromGenerated(resp.KeyValue),
 		SyncToken:    SyncToken(*resp.SyncToken),
-		LastModified: resp.KeyValue.LastModified,
+		LastModified: resp.LastModified,
 	}, nil
 }
 
@@ -474,9 +471,9 @@ func (c *Client) GetSnapshot(ctx context.Context, snapshotName string, options *
 			ETag:            (*azcore.ETag)(getResp.Etag),
 			Expires:         getResp.Expires,
 			ItemsCount:      getResp.ItemsCount,
-			Name:            getResp.Snapshot.Name,
+			Name:            getResp.Name,
 			Size:            getResp.Size,
-			Status:          getResp.Snapshot.Status,
+			Status:          getResp.Status,
 		},
 		SyncToken: SyncToken(*getResp.SyncToken),
 		Link:      getResp.Link,
@@ -569,9 +566,9 @@ func (c *Client) updateSnapshotStatus(ctx context.Context, snapshotName string,
 			ETag:            (*azcore.ETag)(updateResp.Etag),
 			Expires:         updateResp.Expires,
 			ItemsCount:      updateResp.ItemsCount,
-			Name:            updateResp.Snapshot.Name,
+			Name:            updateResp.Name,
 			Size:            updateResp.Size,
-			Status:          updateResp.Snapshot.Status,
+			Status:          updateResp.Status,
 		},
 		SyncToken: SyncToken(*updateResp.SyncToken),
 		Link:      updateResp.Link,

sdk/data/azappconfig/client_test.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
@@ -548,7 +545,7 @@ func TestSnapshotArchive(t *testing.T) {
 	// Archive the snapshot
 	archiveSnapshot, err := client.ArchiveSnapshot(context.Background(), snapshotName, nil)
 	require.NoError(t, err)
-	require.Equal(t, azappconfig.SnapshotStatusArchived, *archiveSnapshot.Snapshot.Status)
+	require.Equal(t, azappconfig.SnapshotStatusArchived, *archiveSnapshot.Status)
 
 	// Best effort snapshot cleanup
 	require.NoError(t, CleanupSnapshot(client, snapshotName))
@@ -571,12 +568,12 @@ func TestSnapshotRecover(t *testing.T) {
 	// Check that snapshot is archived
 	archivedSnapshot, err := client.GetSnapshot(context.Background(), *snapshot.Name, nil)
 	require.NoError(t, err)
-	require.Equal(t, azappconfig.SnapshotStatusArchived, *archivedSnapshot.Snapshot.Status)
+	require.Equal(t, azappconfig.SnapshotStatusArchived, *archivedSnapshot.Status)
 
 	// Recover the snapshot
 	readySnapshot, err := client.RecoverSnapshot(context.Background(), *snapshot.Name, nil)
 	require.NoError(t, err)
-	require.Equal(t, azappconfig.SnapshotStatusReady, *readySnapshot.Snapshot.Status)
+	require.Equal(t, azappconfig.SnapshotStatusReady, *readySnapshot.Status)
 
 	// Best effort snapshot cleanup
 	require.NoError(t, CleanupSnapshot(client, snapshotName))

sdk/data/azappconfig/constants.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 

sdk/data/azappconfig/doc.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 

sdk/data/azappconfig/examples_test.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 

sdk/data/azappconfig/internal/auth/policy_hmac_auth.go

@@ -1,6 +1,3 @@
-//go:build go1.18
-// +build go1.18
-
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.