Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Nov 21, 2025

checking migration breaking change

Copilot AI review requested due to automatic review settings November 21, 2025 03:01
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Nov 21, 2025
@jliusan jliusan changed the title [Migration-Check]sdk/resourcemanager/attestation [Migration-Check]sdk/resourcemanager/attestation/armattestation Nov 21, 2025
Copilot finished reviewing on behalf of jliusan November 21, 2025 03:02
@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/attestation/armattestation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Azure Attestation SDK from AutoRest to the Go Code Generator, upgrading from v1 to v2 with a major version bump. The migration includes updating the API version from 2020-10-01 to 2021-06-01, restructuring the code generation approach, and introducing new features like private link resources support and enhanced public network access controls.

Key changes:

  • Migration from AutoRest to Go Code Generator with updated code generation tooling
  • Module path change to include /v2 suffix following Go module versioning conventions
  • API version update from 2020-10-01 to 2021-06-01 with new features
  • Breaking changes including type renames, pagination support, and removed types

Reviewed Changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated module path to include v2 suffix and upgraded dependencies
version.go New file containing module name and version constants
tsp-location.yaml New TypeSpec configuration replacing autorest.md
time_rfc3339.go Enhanced date/time parsing with support for additional formats
models.go Updated type definitions with new fields and renamed types
constants.go Added new enums and updated existing ones for new API features
client files Updated to use new API version and pagination patterns
example test files Refreshed examples with updated import paths and API usage
fake server files Updated test infrastructure for new pagination and client patterns
CHANGELOG.md Documents breaking changes and new features
README.md Updated installation instructions with v2 path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants