Add Float 16 Datatype Support #25707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tvaron3/vs16Datatype
Copilot finished reviewing on behalf of
tvaron3
December 3, 2025 16:11
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Float16 datatype in the vector embedding policy for Azure Cosmos DB containers.
Key Changes:
- Added
VectorDataTypeFloat16constant for 16-bit floating point vector embeddings - Added comprehensive test coverage for all vector data types (float32, float16, int8, uint8)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/data/azcosmos/vector_embedding_policy.go | Adds the Float16 constant definition with appropriate documentation |
| sdk/data/azcosmos/emulator_cosmos_container_test.go | Adds test function that validates container creation and property persistence for all vector data types including the new float16 type |
Comment on lines
+398
to
+441
| createdResp, err := database.CreateContainer(context.TODO(), properties, nil) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create container with %s data type: %v", dt.name, err) | ||
| } | ||
|
|
||
| container, _ := database.NewContainer(containerID) | ||
| readResp, err := container.Read(context.TODO(), nil) | ||
| if err != nil { | ||
| t.Fatalf("Failed to read container: %v", err) | ||
| } | ||
|
|
||
| readProperties := readResp.ContainerProperties | ||
| if readProperties.VectorEmbeddingPolicy == nil { | ||
| t.Fatalf("Expected VectorEmbeddingPolicy to be set") | ||
| } | ||
|
|
||
| if len(readProperties.VectorEmbeddingPolicy.VectorEmbeddings) != 1 { | ||
| t.Fatalf("Expected 1 vector embedding, got %d", len(readProperties.VectorEmbeddingPolicy.VectorEmbeddings)) | ||
| } | ||
|
|
||
| embedding := readProperties.VectorEmbeddingPolicy.VectorEmbeddings[0] | ||
| if embedding.DataType != dt.dataType { | ||
| t.Errorf("Expected data type %s, got %s", dt.dataType, embedding.DataType) | ||
| } | ||
|
|
||
| if embedding.Path != "/vector1" { | ||
| t.Errorf("Expected path /vector1, got %s", embedding.Path) | ||
| } | ||
|
|
||
| if embedding.Dimensions != 256 { | ||
| t.Errorf("Expected dimensions 256, got %d", embedding.Dimensions) | ||
| } | ||
|
|
||
| if embedding.DistanceFunction != VectorDistanceFunctionEuclidean { | ||
| t.Errorf("Expected distance function euclidean, got %s", embedding.DistanceFunction) | ||
| } | ||
|
|
||
| // Clean up | ||
| _, err = container.Delete(context.TODO(), nil) | ||
| if err != nil { | ||
| t.Fatalf("Failed to delete container %s: %v", containerID, err) | ||
| } | ||
|
|
||
| _ = createdResp // Avoid unused variable warning |
There was a problem hiding this comment.
The variable createdResp is assigned but never used meaningfully. The comment // Avoid unused variable warning suggests this was done intentionally, but it would be cleaner to use the blank identifier _ at assignment: _, err := database.CreateContainer(...) instead of assigning to createdResp and then discarding it later.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the float16 datatype for the vector embedding policy and adds a test creating a policy for each data type