Skip to content

Conversation

@AzureMarker
Copy link
Member

@AzureMarker AzureMarker commented Dec 3, 2025

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

This PR fixes #25700

Copilot AI review requested due to automatic review settings December 3, 2025 22:08
Copilot finished reviewing on behalf of AzureMarker December 3, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes audience URL inconsistencies for AzureGovernment and AzureChina cloud configurations by adding trailing slashes to align with Azure CLI, other SDKs, and the existing AzurePublic configuration.

Key Changes:

  • Added trailing slashes to cloud.AzureChina and cloud.AzureGovernment audience URLs
  • Updated CHANGELOG.md to document the bug fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/azcore/arm/runtime/runtime.go Added trailing slashes to audience URLs for AzureChina and AzureGovernment to match AzurePublic and align with Azure CLI
sdk/azcore/CHANGELOG.md Added entry documenting the bug fix for audience values in version 1.20.1

Review Summary: No issues found. The changes correctly fix the audience URL inconsistency by adding trailing slashes to AzureChina and AzureGovernment configurations, making them consistent with the existing AzurePublic configuration. The existing test coverage in pipeline_test.go validates these audience URLs and will continue to work correctly with the trailing slashes, as the test constructs scopes by appending "/.default" to the audience URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AzureGovernment and AzureChina audience values are not aligned with Azure CLI

1 participant