Adopt new keyvault folder structure #25717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
changed the title
Copilot finished reviewing on behalf of
tadelesh
December 4, 2025 03:50
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adopts a new folder structure for TypeSpec specifications by migrating from the old Security.KeyVault.* directory paths to the new data-plane/Administration/* structure in the Azure REST API specs repository.
Key changes:
- Introduces batch configuration for tsp-client to simplify code generation
- Updates all TypeSpec location references to the new folder structure
- Updates tooling versions (emitter 0.8.6 and tsp-client 0.31.0)
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/security/keyvault/azadmin/tsp-location.yaml | Adds batch configuration to coordinate code generation across backup, rbac, and settings subdirectories |
| sdk/security/keyvault/azadmin/settings/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.Settings to data-plane/Administration/Settings |
| sdk/security/keyvault/azadmin/rbac/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.RBAC to data-plane/Administration/RBAC |
| sdk/security/keyvault/azadmin/backup/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.BackupRestore to data-plane/Administration/BackupRestore |
| sdk/security/keyvault/azadmin/settings/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/rbac/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/backup/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/settings/client.go | Updates client documentation to better describe the administration service capabilities |
| sdk/security/keyvault/azadmin/rbac/client.go | Adds scope parameter validation checks across all RBAC methods |
| sdk/security/keyvault/azadmin/build.go | Simplifies build directives to use single tsp-client update command leveraging new batch configuration |
| eng/common/tsp-client/package.json | Updates typespec-client-generator-cli from version 0.30.0 to 0.31.0 |
| eng/common/tsp-client/package-lock.json | Updates package lock file to reflect new tsp-client version |
Files not reviewed (1)
- eng/common/tsp-client/package-lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on this PR.