Skip to content

[azopenai] Token counts aren't contractual for our client, no need to test for it. #25728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardpark-msft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[azopenai] Token counts aren't contractual for our client, no need to test for it. #25728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions sdk/ai/azopenai/client_chat_completions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,10 @@ func TestClient_GetChatCompletions(t *testing.T) {
require.NotEmpty(t, choice.Message.Content)
require.Equal(t, "stop", choice.FinishReason)

require.Equal(t, openai.CompletionUsage{
// these change depending on which model you use. These #'s work for gpt-4, which is
// what I'm using for these tests.
CompletionTokens: 29,
PromptTokens: 42,
TotalTokens: 71,
}, openai.CompletionUsage{
CompletionTokens: resp.Usage.CompletionTokens,
PromptTokens: resp.Usage.PromptTokens,
TotalTokens: resp.Usage.TotalTokens,
})
// let's just make sure that the #'s are filled out.
require.Greater(t, resp.Usage.CompletionTokens, int64(0))
require.Greater(t, resp.Usage.PromptTokens, int64(0))
require.Greater(t, resp.Usage.TotalTokens, int64(0))
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using require.NotZero instead of require.Greater(t, ..., int64(0)) for consistency with similar checks in client_completions_test.go (lines 33-35). Both approaches are functionally equivalent, but NotZero is more concise and aligns with the existing pattern in the codebase.

Suggested change
require.Greater(t, resp.Usage.TotalTokens, int64(0))
require.NotZero(t, resp.Usage.TotalTokens)

Copilot uses AI. Check for mistakes.
}

t.Run("AzureOpenAI", func(t *testing.T) {
Expand Down
Loading