Skip to content

Commit 00d65c3

Browse files
Copilotrujche
andcommitted
Refactor credential resolution to eliminate code duplication
Co-authored-by: rujche <[email protected]>
1 parent d2850e9 commit 00d65c3

File tree

2 files changed

+34
-16
lines changed

2 files changed

+34
-16
lines changed

sdk/spring/spring-cloud-azure-stream-binder-eventhubs/src/main/java/com/azure/spring/cloud/stream/binder/eventhubs/implementation/config/EventHubsBinderConfiguration.java

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,7 @@ EventHubsProducerFactoryCustomizer defaultEventHubsProducerFactoryCustomizer(
123123
@Qualifier(DEFAULT_TOKEN_CREDENTIAL_BEAN_NAME) TokenCredential defaultAzureCredential,
124124
ObjectProvider<AzureServiceClientBuilderCustomizer<EventHubClientBuilder>> clientBuilderCustomizers) {
125125

126-
TokenCredential tokenCredential = eventHubsProperties.getIfAvailable() != null
127-
? azureTokenCredentialResolver.resolve(eventHubsProperties.getIfAvailable())
128-
: null;
129-
TokenCredential credential = tokenCredential != null ? tokenCredential : defaultAzureCredential;
126+
TokenCredential credential = resolveTokenCredential(azureTokenCredentialResolver, eventHubsProperties, defaultAzureCredential);
130127
return new DefaultProducerFactoryCustomizer(credential, azureTokenCredentialResolver, clientBuilderCustomizers);
131128
}
132129

@@ -138,13 +135,25 @@ EventHubsProcessorFactoryCustomizer defaultEventHubsProcessorFactoryCustomizer(
138135
@Qualifier(DEFAULT_TOKEN_CREDENTIAL_BEAN_NAME) TokenCredential defaultCredential,
139136
ObjectProvider<AzureServiceClientBuilderCustomizer<EventProcessorClientBuilder>> processorClientBuilderCustomizers) {
140137

141-
TokenCredential tokenCredential = eventHubsProperties.getIfAvailable() != null
142-
? azureTokenCredentialResolver.resolve(eventHubsProperties.getIfAvailable())
143-
: null;
144-
TokenCredential credential = tokenCredential != null ? tokenCredential : defaultCredential;
138+
TokenCredential credential = resolveTokenCredential(azureTokenCredentialResolver, eventHubsProperties, defaultCredential);
145139
return new DefaultProcessorFactoryCustomizer(credential, azureTokenCredentialResolver, processorClientBuilderCustomizers);
146140
}
147141

142+
private static TokenCredential resolveTokenCredential(
143+
AzureTokenCredentialResolver azureTokenCredentialResolver,
144+
ObjectProvider<AzureEventHubsProperties> eventHubsProperties,
145+
TokenCredential defaultCredential) {
146+
147+
AzureEventHubsProperties properties = eventHubsProperties.getIfAvailable();
148+
if (properties != null) {
149+
TokenCredential resolvedCredential = azureTokenCredentialResolver.resolve(properties);
150+
if (resolvedCredential != null) {
151+
return resolvedCredential;
152+
}
153+
}
154+
return defaultCredential;
155+
}
156+
148157
/**
149158
* The default {@link EventHubsProducerFactoryCustomizer} to configure the credential related properties and client builder customizers.
150159
*/

sdk/spring/spring-cloud-azure-stream-binder-servicebus/src/main/java/com/azure/spring/cloud/stream/binder/servicebus/implementation/config/ServiceBusBinderConfiguration.java

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,7 @@ ServiceBusProducerFactoryCustomizer defaultServiceBusProducerFactoryCustomizer(
125125
ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder>> clientBuilderCustomizers,
126126
ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder.ServiceBusSenderClientBuilder>> senderClientBuilderCustomizers) {
127127

128-
TokenCredential tokenCredential = serviceBusProperties.getIfAvailable() != null
129-
? azureTokenCredentialResolver.resolve(serviceBusProperties.getIfAvailable())
130-
: null;
131-
TokenCredential credential = tokenCredential != null ? tokenCredential : defaultAzureCredential;
128+
TokenCredential credential = resolveTokenCredential(azureTokenCredentialResolver, serviceBusProperties, defaultAzureCredential);
132129
return new DefaultProducerFactoryCustomizer(credential, azureTokenCredentialResolver,
133130
clientBuilderCustomizers,
134131
senderClientBuilderCustomizers);
@@ -144,16 +141,28 @@ ServiceBusProcessorFactoryCustomizer defaultServiceBusProcessorFactoryCustomizer
144141
ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder.ServiceBusProcessorClientBuilder>> processorClientBuilderCustomizers,
145142
ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder.ServiceBusSessionProcessorClientBuilder>> sessionProcessorClientBuilderCustomizers) {
146143

147-
TokenCredential tokenCredential = serviceBusProperties.getIfAvailable() != null
148-
? azureTokenCredentialResolver.resolve(serviceBusProperties.getIfAvailable())
149-
: null;
150-
TokenCredential credential = tokenCredential != null ? tokenCredential : defaultAzureCredential;
144+
TokenCredential credential = resolveTokenCredential(azureTokenCredentialResolver, serviceBusProperties, defaultAzureCredential);
151145
return new DefaultProcessorFactoryCustomizer(credential, azureTokenCredentialResolver,
152146
clientBuilderCustomizers,
153147
processorClientBuilderCustomizers,
154148
sessionProcessorClientBuilderCustomizers);
155149
}
156150

151+
private static TokenCredential resolveTokenCredential(
152+
AzureTokenCredentialResolver azureTokenCredentialResolver,
153+
ObjectProvider<AzureServiceBusProperties> serviceBusProperties,
154+
TokenCredential defaultCredential) {
155+
156+
AzureServiceBusProperties properties = serviceBusProperties.getIfAvailable();
157+
if (properties != null) {
158+
TokenCredential resolvedCredential = azureTokenCredentialResolver.resolve(properties);
159+
if (resolvedCredential != null) {
160+
return resolvedCredential;
161+
}
162+
}
163+
return defaultCredential;
164+
}
165+
157166
/**
158167
* The default {@link ServiceBusProducerFactory} to configure the credential related properties and client builder customizers.
159168
*/

0 commit comments

Comments
 (0)