Skip to content

Commit 0c8d6c1

Browse files
authored
Exception type name missing (#42241)
* Exception type name missing * Update sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
1 parent b0f6934 commit 0c8d6c1

File tree

1 file changed

+6
-6
lines changed
  • sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation

1 file changed

+6
-6
lines changed

sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -768,9 +768,7 @@ private void exportEvents(SpanData span, @Nullable String operationName, @Nullab
768768
if (stacktrace != null && !shouldSuppress.test(span, event)) {
769769
String exceptionLogged = span.getAttributes().get(AiSemanticAttributes.LOGGED_EXCEPTION);
770770
if (!stacktrace.equals(exceptionLogged)) {
771-
consumer.accept(createExceptionTelemetryItem(
772-
event.getAttributes().get(SemanticAttributes.EXCEPTION_STACKTRACE), span, operationName,
773-
sampleRate));
771+
consumer.accept(createExceptionTelemetryItem(event, span, operationName, sampleRate));
774772
}
775773
}
776774
}
@@ -801,7 +799,7 @@ private void exportEvents(SpanData span, @Nullable String operationName, @Nullab
801799
}
802800
}
803801

804-
private TelemetryItem createExceptionTelemetryItem(String errorStack, SpanData span, @Nullable String operationName,
802+
private TelemetryItem createExceptionTelemetryItem(EventData event, SpanData span, @Nullable String operationName,
805803
@Nullable Double sampleRate) {
806804

807805
ExceptionTelemetryBuilder telemetryBuilder = ExceptionTelemetryBuilder.create();
@@ -815,13 +813,15 @@ private TelemetryItem createExceptionTelemetryItem(String errorStack, SpanData s
815813
} else {
816814
setOperationName(telemetryBuilder, span.getAttributes());
817815
}
818-
setTime(telemetryBuilder, span.getEndEpochNanos());
816+
setTime(telemetryBuilder, event.getEpochNanos());
819817
setSampleRate(telemetryBuilder, sampleRate);
820818

819+
// TODO (trask) should this map the span attributes or the event attributes?
821820
MAPPINGS.map(span.getAttributes(), telemetryBuilder);
822821

823822
// set exception-specific properties
824-
setExceptions(errorStack, span.getAttributes(), telemetryBuilder);
823+
String errorStack = event.getAttributes().get(SemanticAttributes.EXCEPTION_STACKTRACE);
824+
setExceptions(errorStack, event.getAttributes(), telemetryBuilder);
825825

826826
return telemetryBuilder.build();
827827
}

0 commit comments

Comments
 (0)