Skip to content

Commit 0d0a2d1

Browse files
author
Changjian Wang
committed
Fix JaCoCo coverage exclusion using proper rules configuration
Changed from simple excludes to JaCoCo rules with explicit exclude pattern. This properly excludes Sample*Test classes from coverage requirements while maintaining the 40% line / 30% branch coverage thresholds for the actual library code.
1 parent 7edd132 commit 0d0a2d1

File tree

1 file changed

+20
-5
lines changed
  • sdk/contentunderstanding/azure-ai-contentunderstanding

1 file changed

+20
-5
lines changed

sdk/contentunderstanding/azure-ai-contentunderstanding/pom.xml

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@
4747
<jacoco.min.branchcoverage>0.30</jacoco.min.branchcoverage>
4848
<!-- Exclude generated sample files from Checkstyle validation -->
4949
<checkstyle.excludes>**/generated/Sample*Test.java,**/samples/Sample*.java</checkstyle.excludes>
50-
<!-- Exclude generated sample test files from JaCoCo coverage (they are integration tests requiring credentials) -->
51-
<jacoco.maven.plugin.excludes>**/generated/Sample*Test.class</jacoco.maven.plugin.excludes>
5250
</properties>
5351
<dependencies>
5452
<dependency>
@@ -82,9 +80,26 @@
8280
<artifactId>jacoco-maven-plugin</artifactId>
8381
<version>0.8.13</version> <!-- {x-version-update;org.jacoco:jacoco-maven-plugin;external_dependency} -->
8482
<configuration>
85-
<excludes>
86-
<exclude>${jacoco.maven.plugin.excludes}</exclude>
87-
</excludes>
83+
<rules>
84+
<rule>
85+
<element>BUNDLE</element>
86+
<excludes>
87+
<exclude>**/generated/Sample*Test</exclude>
88+
</excludes>
89+
<limits>
90+
<limit>
91+
<counter>LINE</counter>
92+
<value>COVEREDRATIO</value>
93+
<minimum>0.40</minimum>
94+
</limit>
95+
<limit>
96+
<counter>BRANCH</counter>
97+
<value>COVEREDRATIO</value>
98+
<minimum>0.30</minimum>
99+
</limit>
100+
</limits>
101+
</rule>
102+
</rules>
88103
</configuration>
89104
</plugin>
90105
</plugins>

0 commit comments

Comments
 (0)