Exceptions are allowed to propagate upwards

Author: jpalvarezl

sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/http/HttpClientHelper.java

@@ -20,9 +20,6 @@
 import com.openai.core.http.HttpResponse;
 
 import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.io.UncheckedIOException;
-import java.time.Duration;
 import java.util.List;
 import java.util.Objects;
 import java.util.concurrent.CompletableFuture;
@@ -96,12 +93,7 @@ public CompletableFuture<HttpResponse> executeAsync(HttpRequest request, Request
             Objects.requireNonNull(request, "request");
             Objects.requireNonNull(requestOptions, "requestOptions");
 
-            final com.azure.core.http.HttpRequest azureRequest;
-            try {
-                azureRequest = buildAzureRequest(request);
-            } catch (RuntimeException runtimeException) {
-                return failedFuture(runtimeException);
-            }
+            final com.azure.core.http.HttpRequest azureRequest = buildAzureRequest(request);
 
             Context requestContext = new Context("azure-eagerly-read-response", true);
             Timeout timeout = requestOptions.getTimeout();
@@ -131,11 +123,9 @@ private static com.azure.core.http.HttpRequest buildAzureRequest(HttpRequest req
             BinaryData bodyData = null;
 
             if (requestBody != null) {
-                try {
-                    bodyData = toBinaryData(requestBody);
-                } finally {
-                    closeQuietly(requestBody);
-                }
+                ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
+                requestBody.writeTo(outputStream);
+                bodyData = BinaryData.fromBytes(outputStream.toByteArray());
             }
 
             HttpHeaders headers = toAzureHeaders(request.headers());
@@ -170,44 +160,5 @@ private static HttpHeaders toAzureHeaders(Headers sourceHeaders) {
             return target;
         }
 
-        /**
-         * Buffers the OpenAI {@link HttpRequestBody} into {@link BinaryData} so it can be attached to the Azure
-         * request. The body is consumed exactly once and closed afterwards.
-         */
-        private static BinaryData toBinaryData(HttpRequestBody requestBody) {
-            if (requestBody == null) {
-                return null;
-            }
-
-            try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
-                requestBody.writeTo(outputStream);
-                return BinaryData.fromBytes(outputStream.toByteArray());
-            } catch (IOException e) {
-                throw LOGGER.logExceptionAsError(new UncheckedIOException("Failed to buffer request body", e));
-            }
-        }
-
-        /**
-         * Closes the OpenAI request body while suppressing any exceptions (to avoid masking the root cause).
-         */
-        private static void closeQuietly(HttpRequestBody body) {
-            if (body == null) {
-                return;
-            }
-            try {
-                body.close();
-            } catch (Exception ignored) {
-                // no-op
-            }
-        }
-
-        /**
-         * Creates a failed {@link CompletableFuture} for callers that require a future even when conversion fails.
-         */
-        private static <T> CompletableFuture<T> failedFuture(Throwable throwable) {
-            CompletableFuture<T> future = new CompletableFuture<>();
-            future.completeExceptionally(throwable);
-            return future;
-        }
     }
 }

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ClientTestBase.java

@@ -105,16 +105,9 @@ private void addTestRecordCustomSanitizers() {
     }
 
     private void addCustomMatchers() {
-        interceptorManager.addMatchers(new CustomMatcher().setExcludedHeaders(
-            Arrays.asList("Cookie",
-                "Set-Cookie",
-                "X-Stainless-Arch",
-                "X-Stainless-Lang",
-                "X-Stainless-OS",
-                "X-Stainless-OS-Version",
-                "X-Stainless-Package-Version",
-                "X-Stainless-Runtime",
-                "X-Stainless-Runtime-Version")));
+        interceptorManager.addMatchers(new CustomMatcher().setExcludedHeaders(Arrays.asList("Cookie", "Set-Cookie",
+            "X-Stainless-Arch", "X-Stainless-Lang", "X-Stainless-OS", "X-Stainless-OS-Version",
+            "X-Stainless-Package-Version", "X-Stainless-Runtime", "X-Stainless-Runtime-Version")));
     }
 
     protected void sleep(long millis) {

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsAsyncTests.java

@@ -140,9 +140,11 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
     @LiveOnly
     @ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
     @MethodSource("com.azure.ai.agents.TestUtils#getTestParameters")
-    public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) throws ExecutionException, InterruptedException {
+    public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion)
+        throws ExecutionException, InterruptedException {
         ConversationsAsyncClient client = getConversationsAsyncClient(httpClient, serviceVersion);
-        RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
+        RequestOptions requestOptions
+            = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
 
         assertThrows(Exception.class, () -> client.getConversationServiceAsync().create(requestOptions).get());
     }

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsTests.java

@@ -126,7 +126,8 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
     public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) {
         ConversationsClient client = getConversationsSyncClient(httpClient, serviceVersion);
 
-        RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
+        RequestOptions requestOptions
+            = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
         assertThrows(Exception.class, () -> client.getConversationService().create(requestOptions));
     }
 }