WIP: timeout tests

Author: jpalvarezl

sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/http/HttpClientHelper.java

@@ -75,7 +75,14 @@ public HttpResponse execute(HttpRequest request, RequestOptions requestOptions)
             Objects.requireNonNull(requestOptions, "requestOptions");
 
             com.azure.core.http.HttpRequest azureRequest = buildAzureRequest(request);
-            com.azure.core.http.HttpResponse azureResponse = this.httpPipeline.sendSync(azureRequest, Context.NONE);
+
+            Context requestContext = Context.NONE;
+            Timeout timeout = requestOptions.getTimeout();
+            if (timeout != null && !timeout.read().isZero() && !timeout.read().isNegative()) {
+                requestContext = requestContext.addData("azure-response-timeout", timeout.request());
+            }
+
+            com.azure.core.http.HttpResponse azureResponse = this.httpPipeline.sendSync(azureRequest, requestContext);
             return new AzureHttpResponseAdapter(azureResponse);
         }
 
@@ -98,8 +105,8 @@ public CompletableFuture<HttpResponse> executeAsync(HttpRequest request, Request
 
             Context requestContext = new Context("azure-eagerly-read-response", true);
             Timeout timeout = requestOptions.getTimeout();
-            if (timeout != null && !timeout.connect().isZero() && !timeout.connect().isNegative()) {
-                requestContext = requestContext.addData("azure-response-timeout", timeout.connect());
+            if (timeout != null && !timeout.read().isZero() && !timeout.read().isNegative()) {
+                requestContext = requestContext.addData("azure-response-timeout", timeout.read());
             }
 
             return this.httpPipeline.send(azureRequest, requestContext)

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsAsyncTests.java

@@ -7,6 +7,8 @@
 import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.logging.LogLevel;
 import com.openai.core.JsonValue;
+import com.openai.core.RequestOptions;
+import com.openai.core.Timeout;
 import com.openai.models.conversations.Conversation;
 import com.openai.models.conversations.ConversationDeletedResource;
 import com.openai.models.conversations.ConversationUpdateParams;
@@ -18,6 +20,7 @@
 import org.junit.jupiter.params.provider.MethodSource;
 import org.junit.platform.commons.util.StringUtils;
 
+import java.time.Duration;
 import java.util.concurrent.ExecutionException;
 
 import static com.azure.ai.agents.TestUtils.DISPLAY_NAME_WITH_ARGUMENTS;
@@ -133,4 +136,14 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
         assertEquals(conversationId, conversationWithDeletedItem.id());
 
     }
+
+    @ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
+    @MethodSource("com.azure.ai.agents.TestUtils#getTestParameters")
+    public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) throws ExecutionException, InterruptedException {
+        ConversationsAsyncClient client = getConversationsAsyncClient(httpClient, serviceVersion);
+        RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
+
+        // creation - conversation
+        assertThrows(Exception.class, () -> client.getConversationServiceAsync().create(requestOptions).get());
+    }
 }

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsTests.java

@@ -5,6 +5,8 @@
 
 import com.azure.core.http.HttpClient;
 import com.openai.core.JsonValue;
+import com.openai.core.RequestOptions;
+import com.openai.core.Timeout;
 import com.openai.models.conversations.*;
 import com.openai.models.conversations.items.*;
 import com.openai.models.responses.EasyInputMessage;
@@ -13,6 +15,8 @@
 import org.junit.jupiter.params.provider.MethodSource;
 import org.junit.platform.commons.util.StringUtils;
 
+import java.time.Duration;
+
 import static com.azure.ai.agents.TestUtils.DISPLAY_NAME_WITH_ARGUMENTS;
 import static org.junit.jupiter.api.Assertions.*;
 
@@ -115,4 +119,14 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
         assertNotNull(conversationWithDeletedItem);
         assertEquals(conversationId, conversationWithDeletedItem.id());
     }
+
+    @ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
+    @MethodSource("com.azure.ai.agents.TestUtils#getTestParameters")
+    public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) {
+        ConversationsClient client = getConversationsSyncClient(httpClient, serviceVersion);
+
+        RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
+        // creation - conversation
+        assertThrows(Exception.class, () -> client.getConversationService().create(requestOptions));
+    }
 }