Remove addRequestCallback method entirely as requested by @alzimmermsft

Co-authored-by: alzimmermsft <[email protected]>

Author: Copilot

sdk/clientcore/annotation-processor-test/src/test/java/io/clientcore/annotation/processor/test/TestInterfaceServiceClientGenerationTests.java

@@ -1516,7 +1516,7 @@ public void requestContextChangesBody() {
 
         HttpBinJSON response = service.put(getServerUri(isSecure()), 42,
             RequestContext.builder()
-                .addRequestCallback(httpRequest -> httpRequest.setBody(BinaryData.fromString("24")))
+                .addBeforeRequestHook(httpRequest -> httpRequest.setBody(BinaryData.fromString("24")))
                 .build());
 
         assertNotNull(response);
@@ -1533,7 +1533,7 @@ public void requestContextChangesBodyAndContentLength() {
 
         HttpBinJSON response = service.put(getServerUri(isSecure()), 42,
             RequestContext.builder()
-                .addRequestCallback(httpRequest -> httpRequest.setBody(BinaryData.fromString("4242"))
+                .addBeforeRequestHook(httpRequest -> httpRequest.setBody(BinaryData.fromString("4242"))
                     .getHeaders()
                     .add(HttpHeaderName.CONTENT_LENGTH, "4"))
                 .build());
@@ -1555,7 +1555,7 @@ public void requestContextAddAHeader() {
 
         HttpBinJSON response = service.put(getServerUri(isSecure()), 42,
             RequestContext.builder()
-                .addRequestCallback(
+                .addBeforeRequestHook(
                     httpRequest -> httpRequest.getHeaders().add(new HttpHeader(RANDOM_HEADER, "randomValue")))
                 .build());
 
@@ -1574,7 +1574,7 @@ public void requestContextSetsAHeader() {
 
         HttpBinJSON response = service.put(getServerUri(isSecure()), 42,
             RequestContext.builder()
-                .addRequestCallback(httpRequest -> httpRequest.getHeaders()
+                .addBeforeRequestHook(httpRequest -> httpRequest.getHeaders()
                     .add(new HttpHeader(RANDOM_HEADER, "randomValue"))
                     .add(RANDOM_HEADER, "randomValue2"))
                 .build());

sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/RequestContext.java

@@ -238,22 +238,6 @@ public static class Builder {
             this.context = context;
         }
 
-        /**
-         * Adds a custom request callback to modify the {@link HttpRequest} before it's sent by the {@link HttpClient}. The
-         * modifications made on a {@link RequestContext} object are applied in order on the request.
-         *
-         * @param requestCallback The request callback.
-         * @return The updated {@link Builder} object.
-         * @throws NullPointerException If {@code requestCallback} is null.
-         * @deprecated Use {@link #addBeforeRequestHook(Consumer)} as it better conveys that the hook executes before the request is sent.
-         */
-        @Deprecated
-        public Builder addRequestCallback(Consumer<HttpRequest> requestCallback) {
-            Objects.requireNonNull(requestCallback, "'requestCallback' cannot be null.");
-            this.requestCallback = this.requestCallback.andThen(requestCallback);
-            return this;
-        }
-
         /**
          * Adds a custom hook to modify the {@link HttpRequest} before it's sent by the {@link HttpClient}. The
          * modifications made on a {@link RequestContext} object are applied in order on the request.

sdk/clientcore/core/src/test/java/io/clientcore/core/http/models/RequestContextTests.java

@@ -73,21 +73,21 @@ public void addBeforeRequestHook() {
     }
 
     @Test
-    @SuppressWarnings("deprecation")
-    public void addRequestCallbackBackwardCompatibility() {
+    public void multipleBeforeRequestHooks() {
         final HttpRequest request
             = new HttpRequest().setMethod(HttpMethod.POST).setUri(URI.create("http://request.uri"));
 
         RequestContext context = RequestContext.builder()
-            .addRequestCallback(r -> r.getHeaders().add(new HttpHeader(X_MS_FOO, "legacy")))
+            .addBeforeRequestHook(r -> r.getHeaders().add(new HttpHeader(X_MS_FOO, "first")))
             .addBeforeRequestHook(r -> r.setMethod(HttpMethod.GET))
-            .addRequestCallback(r -> r.setUri("https://mixed.uri"))
+            .addBeforeRequestHook(r -> r.setUri("https://mixed.uri"))
+            .addBeforeRequestHook(r -> r.getHeaders().set(X_MS_FOO, "last"))
             .build();
 
         context.getRequestCallback().accept(request);
 
         HttpHeaders headers = request.getHeaders();
-        assertEquals("legacy", headers.getValue(X_MS_FOO));
+        assertEquals("last", headers.getValue(X_MS_FOO));
         assertEquals(HttpMethod.GET, request.getHttpMethod());
         assertEquals("https://mixed.uri", request.getUri().toString());
     }

sdk/clientcore/core/src/test/java/io/clientcore/core/implementation/http/rest/RequestContextTests.java

@@ -88,21 +88,20 @@ public void addBeforeRequestHook() {
     }
 
     @Test
-    @SuppressWarnings("deprecation")
-    public void addRequestCallbackStillWorks() {
+    public void addBeforeRequestHookWorks() {
         final HttpRequest request
             = new HttpRequest().setMethod(HttpMethod.POST).setUri(URI.create("http://request.uri"));
         RequestContext context = RequestContext.builder()
-            .addRequestCallback(request2 -> request2.setUri("https://deprecated.uri")
+            .addBeforeRequestHook(request2 -> request2.setUri("https://updated.uri")
                 .setMethod(HttpMethod.GET)
                 .getHeaders()
-                .set(X_MS_FOO, "deprecated"))
+                .set(X_MS_FOO, "updated"))
             .build();
         context.getRequestCallback().accept(request);
 
         HttpHeaders headers = request.getHeaders();
-        assertEquals("deprecated", headers.getValue(X_MS_FOO));
+        assertEquals("updated", headers.getValue(X_MS_FOO));
         assertEquals(HttpMethod.GET, request.getHttpMethod());
-        assertEquals("https://deprecated.uri", request.getUri().toString());
+        assertEquals("https://updated.uri", request.getUri().toString());
     }
 }