Deprecate SharedTokenCacheCredential and remove from DefaultAzureCredential chain

Co-authored-by: srnagar <[email protected]>

Author: Copilot

sdk/identity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredential.java

@@ -19,7 +19,6 @@
  * <li>{@link EnvironmentCredential}</li>
  * <li>{@link WorkloadIdentityCredential}</li>
  * <li>{@link ManagedIdentityCredential}</li>
- * <li>{@link SharedTokenCacheCredential}</li>
  * <li>{@link IntelliJCredential}</li>
  * <li>{@link AzureCliCredential}</li>
  * <li>{@link AzurePowerShellCredential}</li>

sdk/identity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredentialBuilder.java

@@ -292,7 +292,7 @@ private ArrayList<TokenCredential> getCredentialsChain() {
             useDeveloperCredentials = true;
         }
 
-        ArrayList<TokenCredential> output = new ArrayList<TokenCredential>(8);
+        ArrayList<TokenCredential> output = new ArrayList<TokenCredential>(7);
         if (useProductionCredentials) {
             output.add(new EnvironmentCredential(identityClientOptions.clone()));
             output.add(getWorkloadIdentityCredential());
@@ -301,8 +301,6 @@ private ArrayList<TokenCredential> getCredentialsChain() {
         }
 
         if (useDeveloperCredentials) {
-            output.add(new SharedTokenCacheCredential(null, IdentityConstants.DEVELOPER_SINGLE_SIGN_ON_ID, tenantId,
-                identityClientOptions.clone()));
             output.add(new IntelliJCredential(tenantId, identityClientOptions.clone()));
             output.add(new AzureCliCredential(tenantId, identityClientOptions.clone()));
             output.add(new AzurePowerShellCredential(tenantId, identityClientOptions.clone()));

sdk/identity/azure-identity/src/main/java/com/azure/identity/SharedTokenCacheCredential.java

@@ -27,7 +27,12 @@
  * <p>This credential is a legacy mechanism for authenticating clients using credentials provided to Visual Studio.</p>
  *
  * @see com.azure.identity
+ * @deprecated This credential was originally created to support authentication with Visual Studio. Since Visual Studio
+ * was the only application that wrote to this token cache, this credential has been deprecated in favor of other
+ * developer credentials like {@link AzureCliCredential}, {@link AzureDeveloperCliCredential}, 
+ * {@link AzurePowerShellCredential}, or {@link IntelliJCredential} for local development scenarios.
  */
+@Deprecated
 public class SharedTokenCacheCredential implements TokenCredential {
     private static final ClientLogger LOGGER = new ClientLogger(SharedTokenCacheCredential.class);
 

sdk/identity/azure-identity/src/main/java/com/azure/identity/SharedTokenCacheCredentialBuilder.java

@@ -10,7 +10,12 @@
  * This mechanism for Visual Studio authentication has been replaced by the {@link VisualStudioCodeCredential}/>.</p>
  *
  * @see SharedTokenCacheCredential
+ * @deprecated This credential was originally created to support authentication with Visual Studio. Since Visual Studio
+ * was the only application that wrote to this token cache, this credential has been deprecated in favor of other
+ * developer credentials like {@link AzureCliCredential}, {@link AzureDeveloperCliCredential}, 
+ * {@link AzurePowerShellCredential}, or {@link IntelliJCredential} for local development scenarios.
  */
+@Deprecated
 public class SharedTokenCacheCredentialBuilder extends AadCredentialBuilderBase<SharedTokenCacheCredentialBuilder> {
     private String username;
 

sdk/identity/azure-identity/src/test/java/com/azure/identity/DefaultAzureCredentialTest.java

@@ -301,11 +301,6 @@ public void testNoCredentialWorks() {
                 when(identityClient.authenticateWithManagedIdentityMsalClient(request)).thenReturn(
                     Mono.error(new CredentialUnavailableException("Cannot get token from managed identity")));
             });
-            MockedConstruction<SharedTokenCacheCredential> sharedTokenCacheCredentialMock
-                = mockConstruction(SharedTokenCacheCredential.class, (sharedTokenCacheCredential, context) -> {
-                    when(sharedTokenCacheCredential.getToken(request)).thenReturn(
-                        Mono.error(new CredentialUnavailableException("Cannot get token from shared token cache")));
-                });
             MockedConstruction<AzureDeveloperCliCredential> azureDeveloperCliCredentialMock
                 = mockConstruction(AzureDeveloperCliCredential.class, (AzureDeveloperCliCredential, context) -> {
                     when(AzureDeveloperCliCredential.getToken(request)).thenReturn(Mono.error(
@@ -335,7 +330,6 @@ public void testNoCredentialWorks() {
                     && t.getMessage().startsWith("EnvironmentCredential authentication unavailable. "))
                 .verify();
             Assertions.assertNotNull(identityClientMock);
-            Assertions.assertNotNull(sharedTokenCacheCredentialMock);
             Assertions.assertNotNull(azureCliCredentialMock);
             Assertions.assertNotNull(azureDeveloperCliCredentialMock);
             Assertions.assertNotNull(azurePowerShellCredentialMock);
@@ -663,15 +657,14 @@ public void testDeveloperOnlyCredentialsChain(String devValue) {
 
         List<TokenCredential> credentials = extractCredentials(credential);
 
-        // Only developer credentials should be present (5)
-        assertEquals(5, credentials.size());
+        // Only developer credentials should be present (4)
+        assertEquals(4, credentials.size());
 
         // Verify developer credentials in order
-        assertInstanceOf(SharedTokenCacheCredential.class, credentials.get(0));
-        assertInstanceOf(IntelliJCredential.class, credentials.get(1));
-        assertInstanceOf(AzureCliCredential.class, credentials.get(2));
-        assertInstanceOf(AzurePowerShellCredential.class, credentials.get(3));
-        assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(4));
+        assertInstanceOf(IntelliJCredential.class, credentials.get(0));
+        assertInstanceOf(AzureCliCredential.class, credentials.get(1));
+        assertInstanceOf(AzurePowerShellCredential.class, credentials.get(2));
+        assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(3));
     }
 
     @ParameterizedTest
@@ -702,16 +695,15 @@ public void testDefaultCredentialChainWithoutFilter() {
         // Extract credentials to check their types and order
         List<TokenCredential> credentials = extractCredentials(credential);
 
-        // Verify the complete chain with all 8 credentials
-        assertEquals(8, credentials.size());
+        // Verify the complete chain with all 7 credentials
+        assertEquals(7, credentials.size());
         assertInstanceOf(EnvironmentCredential.class, credentials.get(0));
         assertInstanceOf(WorkloadIdentityCredential.class, credentials.get(1));
         assertInstanceOf(ManagedIdentityCredential.class, credentials.get(2));
-        assertInstanceOf(SharedTokenCacheCredential.class, credentials.get(3));
-        assertInstanceOf(IntelliJCredential.class, credentials.get(4));
-        assertInstanceOf(AzureCliCredential.class, credentials.get(5));
-        assertInstanceOf(AzurePowerShellCredential.class, credentials.get(6));
-        assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(7));
+        assertInstanceOf(IntelliJCredential.class, credentials.get(3));
+        assertInstanceOf(AzureCliCredential.class, credentials.get(4));
+        assertInstanceOf(AzurePowerShellCredential.class, credentials.get(5));
+        assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(6));
     }
 
     /**