[azure-sdk-java-mcp] Fix typos and address comments on the initial pr (#46011)

* update according to comments

* fix the issue that pure `mvn` commands are run after running build java sdk

* Update eng/tools/mcp/azure-sdk-java-mcp/src/index.ts

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

Author: haolingdong-msft

.github/copilot-instructions.md

@@ -22,10 +22,14 @@ The Azure SDK for Java repository contains client libraries for Azure services,
 - **Management Libraries**: Libraries with Maven group `com.azure.resourcemanager`
 - **Spring Libraries**: Libraries with Maven group `com.azure.spring`
 
-## SDK Generation Guildlines
+## SDK Generation Guidelines
 
 ACTION: Use azure-sdk-java-mcp sdk tools to generate the SDK.
-ACTION: Use azure-sdk-java-mcp sdk tools to build the SDK.
+ACTION: Do not use pure `mvn` command to compile, build or package SDK, use `build_java_sdk` tool instead, it runs `mvn` command inside.
+ACTION: Use azure-sdk-java-mcp sdk tool `update_client_name` to update client name.
+ACTION: Do not clean Java source before generating the SDK because the generated code may have manual written customized code.
+ACTION: Only update the manual written code or class when you fix compile errors. Manual written class does not have `// Code generated by Microsoft (R) TypeSpec Code Generator.` header. Manual written functions or properties do not have `@Generated` annotation.
+
 
 ## Behavior
 

.github/workflows/azure-java-sdk-mcp-ci.yml

@@ -21,7 +21,7 @@ jobs:
     - name: Setup Node.js
       uses: actions/setup-node@v4
       with:
-        node-version: '20'
+        node-version: '22.x'
         cache: 'npm'
         cache-dependency-path: 'eng/tools/mcp/azure-sdk-java-mcp/package-lock.json'
 

eng/tools/mcp/azure-sdk-java-mcp/README.md

@@ -6,7 +6,7 @@ A Model Context Protocol (MCP) server that provides comprehensive tools for gene
 
 This MCP server provides the following tools:
 
-1. **sync_java_sdk** - Synchronize/Download TypeSpec source files for Java SDK generation from local or remote sources
+1. **sync_typespec_source_files** - Synchronize/Download TypeSpec source files for Java SDK generation from local or remote sources
 2. **generate_java_sdk** - Generate or update Java SDK code from TypeSpec definitions 
 3. **clean_java_source** - Clean and remove generated Java source files from SDK directory
 4. **build_java_sdk** - Compile and build the Java SDK with Maven for Azure services
@@ -23,7 +23,8 @@ Before using this MCP server, ensure you have:
 1. **Project Structure** - The tools can be run from either:
    - A service module directory containing `tsp-location.yaml` (e.g., `/azure-sdk-for-java/sdk/batch/azure-compute-batch`)
    - The SDK root directory (e.g., `/azure-sdk-for-java`)
-2. **Nodejs** installed.
+2. **Node.js** - Version 20.0.0 or higher installed.
+3. **MCP Client** - A compatible MCP client such as GitHub Copilot or Claude Desktop
 
 ## Configure MCP Server in VSCode
 
@@ -84,7 +85,7 @@ npm run test:run      # Run tests once
 
 ## Tools Documentation
 
-### 1. sync_java_sdk
+### 1. sync_typespec_source_files
 Synchronize/Download the TypeSpec source for a target service to generate Java SDK from. Always ask user to provide local tspconfig.yaml path or remote tspconfig.yaml url. The tool takes local tspconfig.yaml path or remote tspconfig.yaml url as input parameter.
 
 **Parameters:**
@@ -96,7 +97,7 @@ Synchronize/Download the TypeSpec source for a target service to generate Java S
 **Example:**
 ```json
 {
-  "name": "sync_java_sdk",
+  "name": "sync_typespec_source_files",
   "arguments": {
     "localTspConfigPath": "C:\\workspace\\azure-rest-api-specs\\specification\\communication\\Communication.Messages\\tspconfig.yaml"
   }
@@ -260,7 +261,9 @@ This flexibility allows you to work at the level that best suits your workflow.
 2. Add tests for new functionality in `src/**/*.spec.ts`
 3. Build the project with `npm run build`
 4. Test your changes with `npm test` and `npm start`
+5. Format and lint your code with `npm run format` and `npm run lint`
 
 ## License
 
 MIT
+

eng/tools/mcp/azure-sdk-java-mcp/src/build-java-sdk.ts

@@ -14,8 +14,8 @@ export async function buildJavaSdk(
 
         const mvnCmd = process.platform === "win32" ? "mvn.cmd" : "mvn";
 
-        // Run the Java SDK generation command
-        const generateResult = await spawnAsync(
+        // Run the Java SDK Build command
+        const buildResult = await spawnAsync(
             mvnCmd,
             [
                 "--no-transfer-progress",
@@ -33,24 +33,24 @@ export async function buildJavaSdk(
             ],
             {
                 cwd: process.cwd(),
-                shell: true, // Use shell to allow tsp-client command
+                shell: true,
                 timeout: 600000, // 10 minute timeout
             },
         );
 
         let result = `Java SDK Build Results:\n\n`;
 
-        if (generateResult.success) {
+        if (buildResult.success) {
             result += `✅ SDK build completed successfully!\n\n`;
         } else {
-            result += `❌ SDK build failed with exit code ${generateResult.exitCode}\n\n`;
+            result += `❌ SDK build failed with exit code ${buildResult.exitCode}\n\n`;
 
-            if (generateResult.stdout) {
-                result += `Output:\n${generateResult.stdout}\n`;
+            if (buildResult.stdout) {
+                result += `Output:\n${buildResult.stdout}\n`;
             }
 
-            if (generateResult.stderr) {
-                result += `\nErrors:\n${generateResult.stderr}\n`;
+            if (buildResult.stderr) {
+                result += `\nErrors:\n${buildResult.stderr}\n`;
             }
         }
 

eng/tools/mcp/azure-sdk-java-mcp/src/index.ts

@@ -146,9 +146,9 @@ server.registerTool(
     },
 );
 
-// Tool: sync_java_sdk
+// Tool: sync_typespec_source_files
 server.registerTool(
-    "sync_java_sdk",
+    "sync_typespec_source_files",
     {
         description:
             "Synchronize or download the TypeSpec source for a target service to enable Java SDK generation. Accepts either a local absolute path to tspconfig.yaml or a remote URL (with commit id, not branch name).",
@@ -167,11 +167,11 @@ server.registerTool(
                 ),
         },
         annotations: {
-            title: "Sync Java SDK",
+            title: "Sync TypeSpec Source Files",
         },
     },
     async (args) => {
-        logToolCall("sync_java_sdk");
+        logToolCall("sync_typespec_source_files");
         const result = await initJavaSdk(args.localTspConfigPath, args.remoteTspConfigUrl);
         return result;
     },
@@ -182,7 +182,7 @@ server.registerTool(
     "generate_java_sdk",
     {
         description:
-            "Generate the Java SDK from TypeSpec source files located in the 'TempTypeSpecFiles' directory within the specified working directory. If 'TempTypeSpecFiles' is not present, prompt the user to specify whether to generate from a local or remote TypeSpec source, and use the sync_java_sdk tool as needed before proceeding.",
+            "Generate the Java SDK from TypeSpec source files located in the 'TempTypeSpecFiles' directory within the specified working directory. If 'TempTypeSpecFiles' is not present, prompt the user to specify whether to generate from a local or remote TypeSpec source, and use the sync_typespec_source_files tool as needed before proceeding.",
         inputSchema: {
             cwd: z
                 .string()

eng/tools/mcp/azure-sdk-java-mcp/src/init-java-sdk.ts

@@ -19,8 +19,6 @@ export async function initJavaSdk(localTspConfigPath?: string, remoteTspConfigUr
                     localTspConfigPath,
                     "--local-spec-repo",
                     localTspConfigPath,
-                    "--commit",
-                    "123",
                     "--save-inputs",
                 ],
                 {