Generic approach to install java 8 on macOS (#46593)

* Added separte step to install java8

* Install java 8 in the install-latest-jdk template and set java_home

* Check null for the Java_Home

* Cleaned up code

Author: raych1

eng/pipelines/templates/jobs/ci.tests.yml

@@ -110,8 +110,6 @@ jobs:
           ServiceDirectory: ${{parameters.ServiceDirectory}}
           ExcludePaths: ${{parameters.ExcludePaths}}
 
-      - template: /eng/pipelines/templates/steps/install-java8-macos.yml
-
       - template: /eng/common/testproxy/test-proxy-tool.yml
         parameters:
           runProxy: true

eng/pipelines/templates/steps/install-java8-macos.yml

@@ -31,3 +31,13 @@ steps:
       Write-Host "Latest JDK: $Env:JAVA_HOME_${{ parameters.LatestJdkFeatureVersion }}_X64"
     displayName: 'Verify Latest JDK Install'
     condition: eq(variables['IsLatestNonLtsJdk'], 'true')
+
+  - task: PowerShell@2
+    displayName: 'Install JDK 8 on macOS'
+    inputs:
+      pwsh: true
+      arguments: >
+        -JdkFeatureVersion 8
+      workingDirectory: $(Agent.BuildDirectory)
+      filePath: eng/scripts/Install-Latest-JDK.ps1
+    condition: eq(variables['Agent.OS'], 'Darwin')

eng/pipelines/templates/steps/install-latest-jdk.yml

@@ -16,6 +16,19 @@ if ($IsWindows) {
   $os = "linux"
 }
 
+$jdkFeatureVersionJavaHome = "JAVA_HOME_" + $JdkFeatureVersion + "_X64"
+Write-Host "Checking if $jdkFeatureVersionJavaHome is already set and exists..."
+$javaHomeValue = [System.Environment]::GetEnvironmentVariable($jdkFeatureVersionJavaHome)
+if ($javaHomeValue) {
+    $jdkBinPath = Join-Path -Path $javaHomeValue -ChildPath "bin/java"
+    if (Test-Path -Path $jdkBinPath) {
+        Write-Host "$jdkFeatureVersionJavaHome is already set to $javaHomeValue"
+        exit 0
+    }
+} else {
+    Write-Host "$jdkFeatureVersionJavaHome is not set, proceeding with installation..."
+}
+
 $getInstalls = "$adoptiumApiUrl/v3/assets/latest/$JdkFeatureVersion/hotspot?architecture=x64&image_type=jdk&os=$os&vendor=eclipse"
 $jdkUnzipName = "jdk-$JdkFeatureVersion"
 
@@ -43,11 +56,22 @@ if (!(Test-Path -Path $jdkUnzipName -PathType container)) {
 }
 
 $javaHome = (Convert-Path $jdkUnzipName)
-Write-Host "Latest JDK: $javaHome"
 
+if ($IsMacOS) {
+    # On macOS, the JDK is inside a subdirectory of the unzipped folder.
+    $correctJavaHome = Join-Path -Path $javaHome -ChildPath "Contents/Home"
+    $javaBinPath = Join-Path -Path $correctJavaHome -ChildPath "bin/java"
+    if (Test-Path $javaBinPath) {
+        $javaHome = $correctJavaHome
+        Write-Host "Updated JAVA_HOME on macOS: $correctJavaHome"
+    } else {
+        Write-Error "Failed to find Java at: $correctJavaHome"
+        exit 1
+    }
+}
+
+Write-Host "Latest JDK: $javaHome"
 Write-Host "Current JAVA_HOME: $Env:JAVA_HOME"
 Write-Host "##vso[task.setvariable variable=JAVA_HOME;]$javaHome"
-Write-Host "Updated JAVA_HOME: $Env:JAVA_HOME"
-
-$jdkFeatureVersionJavaHome = "JAVA_HOME_" + $JdkFeatureVersion + "_X64"
+Write-Host "Updated JAVA_HOME to : $javaHome"
 Write-Host "##vso[task.setvariable variable=$jdkFeatureVersionJavaHome;]$javaHome"