Skip to content

Commit 65d7238

Browse files
committed
Fetched package properties by groupId and pkgName
1 parent 72f01aa commit 65d7238

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

eng/scripts/Generate-Patch.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function GetRemoteName($MainRemoteUrl) {
8282
return $null
8383
}
8484

85-
function ResetSourcesToReleaseTag($ArtifactName, $ServiceDirectoryName, $ReleaseVersion, $RepoRoot, $RemoteName) {
85+
function ResetSourcesToReleaseTag($ArtifactName, $ServiceDirectoryName, $ReleaseVersion, $RepoRoot, $RemoteName, $GroupId = "com.azure") {
8686
$ReleaseTag = "${ArtifactName}_${ReleaseVersion}"
8787
Write-Information "Resetting the $ArtifactName sources to the release $ReleaseTag."
8888

@@ -92,7 +92,7 @@ function ResetSourcesToReleaseTag($ArtifactName, $ServiceDirectoryName, $Release
9292
$ArtifactDirPath = Join-Path $ServiceDirPath $ArtifactName
9393
TestPathThrow -Path $ArtifactDirPath -PathName 'ArtifactDirPath'
9494

95-
$pkgProperties = Get-PkgProperties -PackageName $ArtifactName -ServiceDirectory $ServiceDirectoryName
95+
$pkgProperties = Get-PkgProperties -PackageName $ArtifactName -ServiceDirectory $ServiceDirectoryName -GroupId $GroupId
9696
$currentPackageVersion = $pkgProperties.Version
9797
if($currentPackageVersion -eq $ReleaseVersion) {
9898
Write-Information "We do not have to reset the sources."
@@ -162,7 +162,7 @@ function CreatePatchRelease($ArtifactName, $ServiceDirectoryName, $PatchVersion,
162162
$EngVersioningDir = Join-Path $EngDir "versioning"
163163
$SetVersionFilePath = Join-Path $EngVersioningDir "set_versions.py"
164164
$UpdateVersionFilePath = Join-Path $EngVersioningDir "update_versions.py"
165-
$pkgProperties = Get-PkgProperties -PackageName $ArtifactName -ServiceDirectory $ServiceDirectoryName
165+
$pkgProperties = Get-PkgProperties -PackageName $ArtifactName -ServiceDirectory $ServiceDirectoryName -GroupId $GroupId
166166
$ChangelogPath = $pkgProperties.ChangeLogPath
167167
$PomFilePath = Join-Path $pkgProperties.DirectoryPath "pom.xml"
168168

@@ -264,7 +264,7 @@ try {
264264

265265
## Hard resetting it to the contents of the release tag.
266266
## Fetching all the tags from the remote branch
267-
ResetSourcesToReleaseTag -ArtifactName $ArtifactName -ServiceDirectoryName $ServiceDirectoryName -ReleaseVersion $ReleaseVersion -RepoRoot $RepoRoot -RemoteName $RemoteName
267+
ResetSourcesToReleaseTag -ArtifactName $ArtifactName -ServiceDirectoryName $ServiceDirectoryName -ReleaseVersion $ReleaseVersion -RepoRoot $RepoRoot -RemoteName $RemoteName -GroupId $GroupId
268268
CreatePatchRelease -ArtifactName $ArtifactName -ServiceDirectoryName $ServiceDirectoryName -PatchVersion $PatchVersion -RepoRoot $RepoRoot
269269
$cmdOutput = git add $RepoRoot
270270
if($LASTEXITCODE -ne 0) {

eng/scripts/Language-Settings.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ function Get-java-PackageInfoFromPackageFile ($pkg, $workingDirectory)
350350
PackageId = $pkgId
351351
GroupId = $groupId
352352
PackageVersion = $pkgVersion
353-
ReleaseTag = "$($pkgId)_$($pkgVersion)"
353+
ReleaseTag = "$($groupId)+$($pkgId)_$($pkgVersion)"
354354
Deployable = $forceCreate -or !(IsMavenPackageVersionPublished -pkgId $pkgId -pkgVersion $pkgVersion -groupId $groupId.Replace(".", "/"))
355355
ReleaseNotes = $releaseNotes
356356
ReadmeContent = $readmeContent
@@ -548,7 +548,7 @@ function SetPackageVersion ($PackageName, $Version, $ServiceDirectory, $ReleaseD
548548
# -ll option says "only update README and CHANGELOG entries for libraries that are on the list"
549549
python "$EngDir/versioning/update_versions.py" --library-list $fullLibraryName
550550
& "$EngCommonScriptsDir/Update-ChangeLog.ps1" -Version $Version -ServiceDirectory $ServiceDirectory -PackageName $PackageName `
551-
-Unreleased $False -ReplaceLatestEntryTitle $ReplaceLatestEntryTitle -ReleaseDate $ReleaseDate
551+
-Unreleased $False -ReplaceLatestEntryTitle $ReplaceLatestEntryTitle -ReleaseDate $ReleaseDate -GroupId $GroupId
552552
}
553553

554554
function GetExistingPackageVersions ($PackageName, $GroupId=$null)

eng/scripts/bomhelpers.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ function GeneratePatch($PatchInfo, [string]$BranchName, [string]$RemoteName, [st
305305

306306
$releaseTag = "$($artifactId)_$($releaseVersion)"
307307
if (!$currentPomFileVersion -or !$artifactDirPath -or !$changelogPath) {
308-
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName $artifactId -ServiceDirectory $serviceDirectoryName)
308+
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName $artifactId -ServiceDirectory $serviceDirectoryName -GroupId $GroupId)
309309
$artifactDirPath = $pkgProperties.DirectoryPath
310310
$currentPomFileVersion = $pkgProperties.Version
311311
$changelogPath = $pkgProperties.ChangeLogPath

eng/scripts/patchhelpers.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ function UpdateCIInformation($ArtifactInfos) {
8989
$serviceDirectory = $arInfo.ServiceDirectoryName
9090

9191
if (!$serviceDirectory) {
92-
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName $artifactId -ServiceDirectory $serviceDirectory)
92+
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName $artifactId -ServiceDirectory $serviceDirectory -GroupId $arInfo.GroupId)
9393
$arInfo.ServiceDirectoryName = $pkgProperties.ServiceDirectory
9494
$arInfo.ArtifactDirPath = $pkgProperties.DirectoryPath
9595
$arInfo.CurrentPomFileVersion = $pkgProperties.Version
@@ -188,7 +188,7 @@ function UpdateDependenciesInVersionClient([hashtable]$ArtifactInfos) {
188188

189189
# Get the release version for the next bom artifact.
190190
function GetNextBomVersion() {
191-
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName "azure-sdk-bom")
191+
$pkgProperties = [PackageProps](Get-PkgProperties -PackageName "azure-sdk-bom" -GroupId "com.azure")
192192
$currentVersion = $pkgProperties.Version
193193

194194
$patchVersion = GetPatchVersion -ReleaseVersion $currentVersion

0 commit comments

Comments
 (0)