Skip to content

Commit 88ab157

Browse files
committed
Update tests.
1 parent 7ebb88b commit 88ab157

File tree

2 files changed

+11
-45
lines changed

2 files changed

+11
-45
lines changed

sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/implementation/jms/ServiceBusJmsAutoConfigurationTests.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,6 @@ void nativeConnectionFactoryBeanConfiguredByDefaultInJmsListenerContainerFactory
296296
assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class);
297297
assertThat(context).doesNotHaveBean(CachingConnectionFactory.class);
298298
assertThat(context).doesNotHaveBean(JmsPoolConnectionFactory.class);
299-
assertThat(context).getBean("jmsListenerContainerFactory")
300-
.extracting("connectionFactory")
301-
.isSameAs(context.getBean(ServiceBusJmsConnectionFactory.class));
302-
assertThat(context).getBean("topicJmsListenerContainerFactory")
303-
.extracting("connectionFactory")
304-
.isSameAs(context.getBean(ServiceBusJmsConnectionFactory.class));
305299
});
306300
}
307301

@@ -438,9 +432,6 @@ void nativeConnectionFactoryBeanConfiguredByPoolDisableCacheDisable(String prici
438432
assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class);
439433
assertThat(context).doesNotHaveBean(CachingConnectionFactory.class);
440434
assertThat(context).doesNotHaveBean(JmsPoolConnectionFactory.class);
441-
assertThat(context).getBean("jmsListenerContainerFactory")
442-
.extracting("connectionFactory")
443-
.isSameAs(context.getBean(ServiceBusJmsConnectionFactory.class));
444435
}
445436
);
446437
}

sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/implementation/jms/ServiceBusJmsConnectionFactoryConfigurationTests.java

Lines changed: 11 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@ void useDefaultPoolConnection(String pricingTier) {
4848
.withPropertyValues(
4949
"spring.jms.servicebus.pricing-tier=" + pricingTier
5050
)
51-
.run(context -> {
52-
assertThat(context).hasSingleBean(JmsPoolConnectionFactory.class);
53-
});
51+
.run(context -> assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class));
5452
}
5553

5654
@ParameterizedTest
@@ -61,36 +59,18 @@ void enablePoolConnection(String pricingTier) {
6159
"spring.jms.servicebus.pricing-tier=" + pricingTier,
6260
"spring.jms.servicebus.pool.enabled=true"
6361
)
64-
.run(context -> {
65-
assertThat(context).hasSingleBean(JmsPoolConnectionFactory.class);
66-
});
62+
.run(context -> assertThat(context).hasSingleBean(JmsPoolConnectionFactory.class));
6763
}
6864

6965
@ParameterizedTest
7066
@ValueSource(strings = { "org.messaginghub.pooled.jms.JmsPoolConnectionFactory", "org.apache.commons.pool2.PooledObject" })
71-
void poolEnabledButNoPoolClasses(String poolClass) {
72-
this.contextRunner
73-
.withClassLoader(new FilteredClassLoader(poolClass))
74-
.withPropertyValues(
75-
"spring.jms.servicebus.pricing-tier=premium",
76-
"spring.jms.servicebus.pool.enabled=true"
77-
)
78-
.run(context -> {
79-
assertThat(context).hasSingleBean(CachingConnectionFactory.class);
80-
});
81-
}
82-
83-
@ParameterizedTest
84-
@ValueSource(strings = { "org.messaginghub.pooled.jms.JmsPoolConnectionFactory", "org.apache.commons.pool2.PooledObject" })
85-
void fallbackUseCachingConnectionDueNoPoolClasses(String poolClass) {
67+
void fallbackDefaultJmsConnectionDueNoPoolClasses(String poolClass) {
8668
this.contextRunner
8769
.withClassLoader(new FilteredClassLoader(poolClass))
8870
.withPropertyValues(
8971
"spring.jms.servicebus.pricing-tier=premium"
9072
)
91-
.run(context -> {
92-
assertThat(context).hasSingleBean(CachingConnectionFactory.class);
93-
});
73+
.run(context -> assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class));
9474
}
9575

9676
@ParameterizedTest
@@ -99,11 +79,9 @@ void useCacheConnection(String pricingTier) {
9979
this.contextRunner
10080
.withPropertyValues(
10181
"spring.jms.servicebus.pricing-tier=" + pricingTier,
102-
"spring.jms.servicebus.pool.enabled=false"
82+
"spring.jms.cache.enabled=true"
10383
)
104-
.run(context -> {
105-
assertThat(context).hasSingleBean(CachingConnectionFactory.class);
106-
});
84+
.run(context -> assertThat(context).hasSingleBean(CachingConnectionFactory.class));
10785
}
10886

10987
@ParameterizedTest
@@ -134,9 +112,7 @@ void useServiceBusJmsConnection(String pricingTier) {
134112
"spring.jms.servicebus.pool.enabled=false",
135113
"spring.jms.cache.enabled=false"
136114
)
137-
.run(context -> {
138-
assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class);
139-
});
115+
.run(context -> assertThat(context).hasSingleBean(ServiceBusJmsConnectionFactory.class));
140116
}
141117

142118
@ParameterizedTest
@@ -145,11 +121,10 @@ void useCacheConnectionViaAdditionConfigurationFile(String pricingTier) {
145121
this.contextRunner
146122
.withConfiguration(AutoConfigurations.of(AdditionalPropertySourceConfiguration.class))
147123
.withPropertyValues(
148-
"spring.jms.servicebus.pricing-tier=" + pricingTier
124+
"spring.jms.servicebus.pricing-tier=" + pricingTier,
125+
"spring.jms.cache.enabled=true"
149126
)
150-
.run(context -> {
151-
assertThat(context).hasSingleBean(CachingConnectionFactory.class);
152-
});
127+
.run(context -> assertThat(context).hasSingleBean(CachingConnectionFactory.class));
153128
}
154129

155130
@Test
@@ -232,7 +207,7 @@ void cachingConnectionFactoryReusesSameProducerForSameDestination() throws Excep
232207
// Cleanup
233208
connection.close();
234209
}
235-
210+
236211
/**
237212
* Creates a ServiceBusJmsSession instance using reflection since the constructor is package-private.
238213
*/

0 commit comments

Comments
 (0)