Reverting production changes

Author: FabianMeiswinkel

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/AsyncDocumentClient.java

@@ -329,14 +329,7 @@ public AsyncDocumentClient build() {
                     operationPolicies,
                     isPerPartitionAutomaticFailoverEnabled);
 
-            try {
-                client.init(state, null);
-            } catch (Throwable t) {
-                client.close();
-                // TODO - should we map this to a CosmosException?
-                throw t;
-            }
-
+            client.init(state, null);
             return client;
         }
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java

@@ -417,60 +417,46 @@ private Mono<RxDocumentServiceResponse> toDocumentServiceResponse(Mono<HttpRespo
                 .map(bodyByteBuf -> leakDetectionDebuggingEnabled
                     ? bodyByteBuf.retain().touch(this)
                     : bodyByteBuf.retain())
-                .publishOn(CosmosSchedulers.TRANSPORT_RESPONSE_BOUNDED_ELASTIC)
-                .doOnDiscard(ByteBuf.class, buf -> {
-                    if (buf.refCnt() > 0) {
-                        io.netty.util.ReferenceCountUtil.safeRelease(buf);
-                    }
-                });
+                .publishOn(CosmosSchedulers.TRANSPORT_RESPONSE_BOUNDED_ELASTIC);
 
             return contentObservable
                 .map(content -> {
                     if (leakDetectionDebuggingEnabled) {
                         content.touch(this);
                     }
 
-                    try {
-                        // Capture transport client request timeline
-                        ReactorNettyRequestRecord reactorNettyRequestRecord = httpResponse.request().reactorNettyRequestRecord();
-                        if (reactorNettyRequestRecord != null) {
-                            reactorNettyRequestRecord.setTimeCompleted(Instant.now());
-                        }
-
-                        StoreResponse rsp = request
-                            .getEffectiveHttpTransportSerializer(this)
-                            .unwrapToStoreResponse(httpRequest.uri().toString(), request, httpResponseStatus, httpResponseHeaders, content);
-
-                        if (reactorNettyRequestRecord != null) {
-                            rsp.setRequestTimeline(reactorNettyRequestRecord.takeTimelineSnapshot());
+                    // Capture transport client request timeline
+                    ReactorNettyRequestRecord reactorNettyRequestRecord = httpResponse.request().reactorNettyRequestRecord();
+                    if (reactorNettyRequestRecord != null) {
+                        reactorNettyRequestRecord.setTimeCompleted(Instant.now());
+                    }
 
-                            if (this.gatewayServerErrorInjector != null) {
-                                // only configure when fault injection is used
-                                rsp.setFaultInjectionRuleId(
-                                    request
-                                        .faultInjectionRequestContext
-                                        .getFaultInjectionRuleId(reactorNettyRequestRecord.getTransportRequestId()));
+                    StoreResponse rsp = request
+                        .getEffectiveHttpTransportSerializer(this)
+                        .unwrapToStoreResponse(httpRequest.uri().toString(), request, httpResponseStatus, httpResponseHeaders, content);
 
-                                rsp.setFaultInjectionRuleEvaluationResults(
-                                    request
-                                        .faultInjectionRequestContext
-                                        .getFaultInjectionRuleEvaluationResults(reactorNettyRequestRecord.getTransportRequestId()));
-                            }
-                        }
+                    if (reactorNettyRequestRecord != null) {
+                        rsp.setRequestTimeline(reactorNettyRequestRecord.takeTimelineSnapshot());
 
-                        if (request.requestContext.cosmosDiagnostics != null) {
-                            BridgeInternal.recordGatewayResponse(request.requestContext.cosmosDiagnostics, request, rsp, globalEndpointManager);
-                        }
+                        if (this.gatewayServerErrorInjector != null) {
+                            // only configure when fault injection is used
+                            rsp.setFaultInjectionRuleId(
+                                request
+                                    .faultInjectionRequestContext
+                                    .getFaultInjectionRuleId(reactorNettyRequestRecord.getTransportRequestId()));
 
-                        return rsp;
-                    } catch (Throwable t) {
-                        if (content.refCnt() > 0) {
-                            // Unwrap failed before StoreResponse took ownership -> release our retain
-                            io.netty.util.ReferenceCountUtil.safeRelease(content);
+                            rsp.setFaultInjectionRuleEvaluationResults(
+                                request
+                                    .faultInjectionRequestContext
+                                    .getFaultInjectionRuleEvaluationResults(reactorNettyRequestRecord.getTransportRequestId()));
                         }
+                    }
 
-                        throw t;
+                    if (request.requestContext.cosmosDiagnostics != null) {
+                        BridgeInternal.recordGatewayResponse(request.requestContext.cosmosDiagnostics, request, rsp, globalEndpointManager);
                     }
+
+                    return rsp;
                 })
                 .single();