Migrate azure-storage-blob to azure-xml (#40622)

* wip :(

* blobflatsegment fix

* blobhierarchylistsegment wip

* pre regeneration

* fix for BlobServiceStatistics and (i think) BlobHierarchyListSegment

* revapi ignore

* adding javadoc for BlobSignedIdentifierWrapper, removing instances of RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE from spotbugs, and ignoring other spotbugs errors.

* removing the revapi things i accidentally added back in

* jsonSerializable wip

* removing jackson from ImmutableStorageWithVersioningTests

* manual spotbugs exclude additions

* revapi ignore done with JacksonDatabindRemovalTransform

* corrected (?) revapi ignore in JacksonDatabindRemovalTransform

* oops

* OOPS

* removing duplicated implementation in ImmutableStorageWithVersioningAsyncTests

* adding ByteBufferBackedOutputStreamUtil

* style and spotbugs excludes

Author: ibrandes

eng/code-quality-reports/src/main/java/com/azure/tools/revapi/transforms/JacksonDatabindRemovalTransform.java

@@ -134,6 +134,10 @@ private static boolean shouldDiscard(String packageName) {
             } else if (packageName.regionMatches(18, "queue.models", 0, 12)) {
                 // Queue
                 return true;
+            } else if (packageName.regionMatches(18, "blob.", 0, 5)) {
+                // Blob
+                return packageName.regionMatches(23, "models", 0, 6)
+                    || packageName.regionMatches(23, "options", 0, 7);
             }
         } else if (packageName.regionMatches(10, "communication.", 0, 14)) {
             if (packageName.regionMatches(24, "jobrouter.models", 0, 16)) {

sdk/storage/azure-storage-blob/checkstyle-suppressions.xml

@@ -19,7 +19,6 @@
   <suppress files="com.azure.storage.blob.implementation.util.ModelHelper.java" checks="MissingJavadocMethodCheck" />
   <suppress files="com.azure.storage.blob.implementation.models.PageListHelper.java" checks="MissingJavadocTypeCheck" />
   <suppress files="com.azure.storage.blob.implementation.util.BlobRequestConditionProperty.java" checks="MissingJavadocTypeCheck" />
-  <suppress files="com.azure.storage.blob.implementation.util.CustomHierarchicalListingDeserializer.java" checks="MissingJavadocTypeCheck" />
   <suppress files="com.azure.storage.blob.implementation.BlobsImpl.java" checks="com.azure.tools.checkstyle.checks.DenyListedWordsCheck" />
   <suppress files="com.azure.storage.blob.implementation.BlockBlobsImpl.java" checks="com.azure.tools.checkstyle.checks.DenyListedWordsCheck" />
   <suppress files="com.azure.storage.blob.implementation.PageBlobsImpl.java" checks="com.azure.tools.checkstyle.checks.DenyListedWordsCheck" />

sdk/storage/azure-storage-blob/pom.xml

@@ -89,9 +89,9 @@
     </dependency>
 
     <dependency>
-      <groupId>com.fasterxml.jackson.dataformat</groupId>
-      <artifactId>jackson-dataformat-xml</artifactId>
-      <version>2.13.5</version> <!-- {x-version-update;com.fasterxml.jackson.dataformat:jackson-dataformat-xml;external_dependency} -->
+      <groupId>com.azure</groupId>
+      <artifactId>azure-xml</artifactId>
+      <version>1.0.0</version> <!-- {x-version-update;com.azure:azure-xml;dependency} -->
     </dependency>
 
     <!-- Added this dependency to include necessary annotations used by reactor core.
@@ -187,25 +187,6 @@
     </dependency>
   </dependencies>
 
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-enforcer-plugin</artifactId>
-        <version>3.4.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-enforcer-plugin;external_dependency} -->
-        <configuration>
-          <rules>
-            <bannedDependencies>
-              <includes>
-                <include>com.fasterxml.jackson.dataformat:jackson-dataformat-xml:[2.13.5]</include> <!-- {x-include-update;com.fasterxml.jackson.dataformat:jackson-dataformat-xml;external_dependency} -->
-              </includes>
-            </bannedDependencies>
-          </rules>
-        </configuration>
-      </plugin>
-    </plugins>
-  </build>
-
   <profiles>
     <profile>
       <id>inject-sas-service-version</id>

sdk/storage/azure-storage-blob/spotbugs-exclude.xml

@@ -21,22 +21,28 @@
       <Class name="com.azure.storage.blob.BlobClient" />
       <Class name="com.azure.storage.blob.BlobUrlParts" />
       <Class name="com.azure.storage.blob.implementation.AzureBlobStorageImpl" />
-      <Class name="com.azure.storage.blob.implementation.SignedIdentifiersWrapper" />
+      <Class name="com.azure.storage.blob.implementation.models.ArrowConfiguration" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobContainersSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobFlatListSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobHierarchyListSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobItemInternal" />
       <Class name="com.azure.storage.blob.implementation.models.BlobPropertiesInternalConstructorProperties" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobSignedIdentifierWrapper" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobTags" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsDownloadHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsGetPropertiesHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsQueryHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.ContainersGetPropertiesHeaders" />
+      <Class name="com.azure.storage.blob.implementation.models.FilterBlobSegment" />
       <Class name="com.azure.storage.blob.implementation.models.PageListCollection" />
       <Class name="com.azure.storage.blob.implementation.models.PageListSegment" />
       <Class name="com.azure.storage.blob.models.BlobContainerAccessPolicies" />
       <Class name="com.azure.storage.blob.models.BlobContainerItem" />
       <Class name="com.azure.storage.blob.models.BlobContainerProperties" />
       <Class name="com.azure.storage.blob.models.BlobItem" />
       <Class name="com.azure.storage.blob.models.BlobSeekableByteChannelReadResult" />
+      <Class name="com.azure.storage.blob.models.BlobServiceProperties" />
+      <Class name="com.azure.storage.blob.models.BlockList" />
       <Class name="com.azure.storage.blob.models.BlockLookupList" />
       <Class name="com.azure.storage.blob.models.PageList" />
       <Class name="com.azure.storage.blob.models.TaggedBlobItem" />
@@ -81,22 +87,29 @@
       <Class name="com.azure.storage.blob.BlobServiceClientBuilder" />
       <Class name="com.azure.storage.blob.BlobUrlParts" />
       <Class name="com.azure.storage.blob.implementation.AzureBlobStorageImplBuilder" />
-      <Class name="com.azure.storage.blob.implementation.SignedIdentifiersWrapper" />
+      <Class name="com.azure.storage.blob.implementation.models.ArrowConfiguration" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobContainersSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobFlatListSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobHierarchyListSegment" />
       <Class name="com.azure.storage.blob.implementation.models.BlobItemInternal" />
       <Class name="com.azure.storage.blob.implementation.models.BlobPropertiesInternalConstructorProperties" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobSignedIdentifierWrapper" />
+      <Class name="com.azure.storage.blob.implementation.models.BlobTags" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsDownloadHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsGetPropertiesHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.BlobsQueryHeaders" />
       <Class name="com.azure.storage.blob.implementation.models.ContainersGetPropertiesHeaders" />
+      <Class name="com.azure.storage.blob.implementation.models.FilterBlobSegment" />
       <Class name="com.azure.storage.blob.implementation.models.PageListCollection" />
       <Class name="com.azure.storage.blob.implementation.models.PageListSegment" />
+      <Class name="com.azure.storage.blob.implementation.util.ByteBufferBackedOutputStreamUtil" />
       <Class name="com.azure.storage.blob.models.BlobContainerAccessPolicies" />
       <Class name="com.azure.storage.blob.models.BlobContainerItem" />
       <Class name="com.azure.storage.blob.models.BlobContainerProperties" />
       <Class name="com.azure.storage.blob.models.BlobItem" />
       <Class name="com.azure.storage.blob.models.BlobSeekableByteChannelReadResult" />
+      <Class name="com.azure.storage.blob.models.BlobServiceProperties" />
+      <Class name="com.azure.storage.blob.models.BlockList" />
       <Class name="com.azure.storage.blob.models.BlockLookupList" />
       <Class name="com.azure.storage.blob.models.PageList" />
       <Class name="com.azure.storage.blob.models.TaggedBlobItem" />

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerAsyncClient.java

@@ -868,7 +868,7 @@ Mono<Response<BlobContainerAccessPolicies>> getAccessPolicyWithResponse(String l
             containerName, null, leaseId, null, context)
             .map(response -> new SimpleResponse<>(response,
                 new BlobContainerAccessPolicies(response.getDeserializedHeaders().getXMsBlobPublicAccess(),
-                response.getValue())));
+                response.getValue().items())));
     }
 
     /**
@@ -1454,9 +1454,7 @@ private Mono<PagedResponse<TaggedBlobItem>> findBlobsByTags(
             this.azureBlobStorage.getContainers().filterBlobsWithResponseAsync(containerName, null, null,
                 options.getQuery(), marker, options.getMaxResultsPerPage(), null, context), timeout)
             .map(response -> {
-                List<TaggedBlobItem> value = response.getValue().getBlobs() == null
-                    ? Collections.emptyList()
-                    : response.getValue().getBlobs().stream()
+                List<TaggedBlobItem> value = response.getValue().getBlobs().stream()
                     .map(ModelHelper::populateTaggedBlobItem)
                     .collect(Collectors.toList());
 
@@ -1520,8 +1518,7 @@ public Mono<Response<StorageAccountInfo>> getAccountInfoWithResponse() {
 
     Mono<Response<StorageAccountInfo>> getAccountInfoWithResponse(Context context) {
         context = context == null ? Context.NONE : context;
-        return this.azureBlobStorage.getContainers().getAccountInfoWithResponseAsync(containerName, null,
-            null, context)
+        return this.azureBlobStorage.getContainers().getAccountInfoWithResponseAsync(containerName, context)
             .map(rb -> {
                 ContainersGetAccountInfoHeaders hd = rb.getDeserializedHeaders();
                 return new SimpleResponse<>(rb, new StorageAccountInfo(hd.getXMsSkuName(), hd.getXMsAccountKind()));

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceAsyncClient.java

@@ -54,7 +54,6 @@
 import java.time.Duration;
 import java.time.OffsetDateTime;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.function.BiFunction;
@@ -614,9 +613,7 @@ private Mono<PagedResponse<TaggedBlobItem>> findBlobsByTags(
             this.azureBlobStorage.getServices().filterBlobsWithResponseAsync(null, null,
                 options.getQuery(), marker, options.getMaxResultsPerPage(), null, context), timeout)
             .map(response -> {
-                List<TaggedBlobItem> value = response.getValue().getBlobs() == null
-                    ? Collections.emptyList()
-                    : response.getValue().getBlobs().stream()
+                List<TaggedBlobItem> value = response.getValue().getBlobs().stream()
                     .map(ModelHelper::populateTaggedBlobItem)
                     .collect(Collectors.toList());
 
@@ -838,13 +835,11 @@ Mono<Response<Void>> setPropertiesWithResponse(BlobServiceProperties properties,
             }
 
             // CORS
-            if (properties.getCors() != null) {
-                List<BlobCorsRule> corsRules = new ArrayList<>();
-                for (BlobCorsRule rule : properties.getCors()) {
-                    corsRules.add(validatedCorsRule(rule));
-                }
-                finalProperties.setCors(corsRules);
+            List<BlobCorsRule> corsRules = new ArrayList<>();
+            for (BlobCorsRule rule : properties.getCors()) {
+                corsRules.add(validatedCorsRule(rule));
             }
+            finalProperties.setCors(corsRules);
 
             // Default Service Version
             finalProperties.setDefaultServiceVersion(properties.getDefaultServiceVersion());
@@ -1071,7 +1066,7 @@ public Mono<Response<StorageAccountInfo>> getAccountInfoWithResponse() {
 
     Mono<Response<StorageAccountInfo>> getAccountInfoWithResponse(Context context) {
         throwOnAnonymousAccess();
-        return this.azureBlobStorage.getServices().getAccountInfoWithResponseAsync(null, null, context)
+        return this.azureBlobStorage.getServices().getAccountInfoWithResponseAsync(context)
             .map(rb -> {
                 ServicesGetAccountInfoHeaders hd = rb.getDeserializedHeaders();
                 return new SimpleResponse<>(rb, new StorageAccountInfo(hd.getXMsSkuName(), hd.getXMsAccountKind(),