do not allow unreleased test dependencies (#14382)

Author: JimSuplizio

eng/versioning/scan_for_unreleased_dependencies.ps1

@@ -9,7 +9,7 @@ param(
 
 # Given an input groupId, artifactId and root service directory, scan the service directory for the
 # POM file that matches the group/artifact. If the POM file is found, scan for any unreleased_ dependency
-# tags otherwise report an error. If there are unreleased dependency tags then report them and return an 
+# tags otherwise report an error. If there are unreleased dependency tags then report them and return an
 # error, otherwise report success and allow the release to continue.
 
 $script:FoundPomFile = $false
@@ -60,13 +60,20 @@ Get-ChildItem -Path $serviceDirectory -Filter pom*.xml -Recurse -File | ForEach-
                 $versionUpdateTag = $versionNode.NextSibling.Value.Trim()
                 if ($versionUpdateTag -match "{x-version-update;unreleased_$($groupId)")
                 {
-                    # before reporting an error, check to see if there's a scope element and
-                    # if the scope is test then don't fail
-                    $scopeNode = $dependencyNode.GetElementsByTagName("scope")[0]
-                    if ($scopeNode -and $scopeNode.InnerText.Trim() -eq "test")
-                    {
-                        continue
-                    }
+                    # mvn dependency:copy-dependencies is used to copy the dependencies from maven for analysis
+                    # as part of the doc build which requires pulling down all dependencies including test
+                    # dependencies. Until such a time that a better solution is found, disable release of a
+                    # library with unreleased test dependencies. When a better solution is found, just uncomment
+                    # the code below.
+
+                    # # before reporting an error, check to see if there's a scope element and
+                    # # if the scope is test then don't fail
+                    # $scopeNode = $dependencyNode.GetElementsByTagName("scope")[0]
+                    # if ($scopeNode -and $scopeNode.InnerText.Trim() -eq "test")
+                    # {
+                    #    continue
+                    # }
+
                     $script:FoundError = $true
                     Write-Error-With-Color "Error: Cannot release libraries with unreleased dependencies. dependency=$($versionUpdateTag)"
                     continue