Skip to content

Commit e658dce

Browse files
Copilotsamvaity
andcommitted
Fix confusing disableAutoComplete() examples in README and sample files
Co-authored-by: samvaity <[email protected]>
1 parent 234cea1 commit e658dce

File tree

6 files changed

+0
-16
lines changed

6 files changed

+0
-16
lines changed

sdk/servicebus/azure-messaging-servicebus/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder()
265265
.disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon).
266266
.processMessage(processMessage)
267267
.processError(processError)
268-
.disableAutoComplete()
269268
.buildProcessorClient();
270269

271270
// Starts the processor in the background. Control returns immediately.
@@ -302,15 +301,13 @@ TokenCredential tokenCredential = new DefaultAzureCredentialBuilder().build();
302301

303302
// Create the processor client via the builder and its sub-builder
304303
// 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net"
305-
// 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon).
306304
ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder()
307305
.credential(fullyQualifiedNamespace, tokenCredential)
308306
.processor()
309307
.queueName(queueName)
310308
.receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE)
311309
.processMessage(processMessage)
312310
.processError(processError)
313-
.disableAutoComplete()
314311
.buildProcessorClient();
315312

316313
// Starts the processor in the background. Control returns immediately.
@@ -385,7 +382,6 @@ created the same way as shown below. Learn more about dead-letter queue [here][d
385382
TokenCredential credential = new DefaultAzureCredentialBuilder().build();
386383

387384
// 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net"
388-
// 'disableAutoComplete' indicates that users will explicitly settle their message.
389385
ServiceBusReceiverClient receiver = new ServiceBusClientBuilder()
390386
.credential(fullyQualifiedNamespace, credential)
391387
.receiver() // Use this for session or non-session enabled queue or topic/subscriptions

sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@
254254
* .disableAutoComplete&#40;&#41; &#47;&#47; Make sure to explicitly opt in to manual settlement &#40;e.g. complete, abandon&#41;.
255255
* .processMessage&#40;processMessage&#41;
256256
* .processError&#40;processError&#41;
257-
* .disableAutoComplete&#40;&#41;
258257
* .buildProcessorClient&#40;&#41;;
259258
*
260259
* &#47;&#47; Starts the processor in the background. Control returns immediately.
@@ -2333,7 +2332,6 @@ private ServiceBusSessionReceiverAsyncClient buildAsyncClient(boolean isForSyncM
23332332
* .disableAutoComplete&#40;&#41; &#47;&#47; Make sure to explicitly opt in to manual settlement &#40;e.g. complete, abandon&#41;.
23342333
* .processMessage&#40;processMessage&#41;
23352334
* .processError&#40;processError&#41;
2336-
* .disableAutoComplete&#40;&#41;
23372335
* .buildProcessorClient&#40;&#41;;
23382336
*
23392337
* &#47;&#47; Starts the processor in the background. Control returns immediately.
@@ -2370,15 +2368,13 @@ private ServiceBusSessionReceiverAsyncClient buildAsyncClient(boolean isForSyncM
23702368
*
23712369
* &#47;&#47; Create the processor client via the builder and its sub-builder
23722370
* &#47;&#47; 'fullyQualifiedNamespace' will look similar to &quot;&#123;your-namespace&#125;.servicebus.windows.net&quot;
2373-
* &#47;&#47; 'disableAutoComplete&#40;&#41;' will opt in to manual settlement &#40;e.g. complete, abandon&#41;.
23742371
* ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder&#40;&#41;
23752372
* .credential&#40;fullyQualifiedNamespace, tokenCredential&#41;
23762373
* .processor&#40;&#41;
23772374
* .queueName&#40;queueName&#41;
23782375
* .receiveMode&#40;ServiceBusReceiveMode.RECEIVE_AND_DELETE&#41;
23792376
* .processMessage&#40;processMessage&#41;
23802377
* .processError&#40;processError&#41;
2381-
* .disableAutoComplete&#40;&#41;
23822378
* .buildProcessorClient&#40;&#41;;
23832379
*
23842380
* &#47;&#47; Starts the processor in the background. Control returns immediately.

sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
* .disableAutoComplete&#40;&#41; &#47;&#47; Make sure to explicitly opt in to manual settlement &#40;e.g. complete, abandon&#41;.
8080
* .processMessage&#40;processMessage&#41;
8181
* .processError&#40;processError&#41;
82-
* .disableAutoComplete&#40;&#41;
8382
* .buildProcessorClient&#40;&#41;;
8483
*
8584
* &#47;&#47; Starts the processor in the background. Control returns immediately.
@@ -116,15 +115,13 @@
116115
*
117116
* &#47;&#47; Create the processor client via the builder and its sub-builder
118117
* &#47;&#47; 'fullyQualifiedNamespace' will look similar to &quot;&#123;your-namespace&#125;.servicebus.windows.net&quot;
119-
* &#47;&#47; 'disableAutoComplete&#40;&#41;' will opt in to manual settlement &#40;e.g. complete, abandon&#41;.
120118
* ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder&#40;&#41;
121119
* .credential&#40;fullyQualifiedNamespace, tokenCredential&#41;
122120
* .processor&#40;&#41;
123121
* .queueName&#40;queueName&#41;
124122
* .receiveMode&#40;ServiceBusReceiveMode.RECEIVE_AND_DELETE&#41;
125123
* .processMessage&#40;processMessage&#41;
126124
* .processError&#40;processError&#41;
127-
* .disableAutoComplete&#40;&#41;
128125
* .buildProcessorClient&#40;&#41;;
129126
*
130127
* &#47;&#47; Starts the processor in the background. Control returns immediately.

sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/package-info.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@
184184
* .disableAutoComplete&#40;&#41; &#47;&#47; Make sure to explicitly opt in to manual settlement &#40;e.g. complete, abandon&#41;.
185185
* .processMessage&#40;processMessage&#41;
186186
* .processError&#40;processError&#41;
187-
* .disableAutoComplete&#40;&#41;
188187
* .buildProcessorClient&#40;&#41;;
189188
*
190189
* &#47;&#47; Starts the processor in the background. Control returns immediately.

sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusProcessorClientJavaDocCodeSamples.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ public void createServiceBusProcessorClientInPeekLockMode() {
8484
.disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon).
8585
.processMessage(processMessage)
8686
.processError(processError)
87-
.disableAutoComplete()
8887
.buildProcessorClient();
8988

9089
// Starts the processor in the background. Control returns immediately.
@@ -125,15 +124,13 @@ public void createServiceBusProcessorClientInReceiveAndDeleteMode() {
125124

126125
// Create the processor client via the builder and its sub-builder
127126
// 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net"
128-
// 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon).
129127
ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder()
130128
.credential(fullyQualifiedNamespace, tokenCredential)
131129
.processor()
132130
.queueName(queueName)
133131
.receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE)
134132
.processMessage(processMessage)
135133
.processError(processError)
136-
.disableAutoComplete()
137134
.buildProcessorClient();
138135

139136
// Starts the processor in the background. Control returns immediately.

sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusReceiverClientJavaDocCodeSamples.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ public void instantiateDeadLetterQueue() {
114114
TokenCredential credential = new DefaultAzureCredentialBuilder().build();
115115

116116
// 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net"
117-
// 'disableAutoComplete' indicates that users will explicitly settle their message.
118117
ServiceBusReceiverClient receiver = new ServiceBusClientBuilder()
119118
.credential(fullyQualifiedNamespace, credential)
120119
.receiver() // Use this for session or non-session enabled queue or topic/subscriptions

0 commit comments

Comments
 (0)