Merge remote-tracking branch 'upstream/main' into wangamber/transcription

Author: amber-yujueWang

.github/CODEOWNERS

@@ -276,8 +276,11 @@
 # AzureSdkOwners:                                                  @samvaity
 # ServiceOwners:                                                   @assafi
 
+# PRLabel: %Cognitive - Translator
+/sdk/translation/                                                  @jrjrguo @SG-MS @Azure/azure-java-sdk
+
 # ServiceLabel: %Cognitive - Translator
-# ServiceOwners:                                                   @swmachan @MikeyMCZ
+# ServiceOwners:                                                   @swmachan @jrjrguo @SG-MS
 
 # ServiceLabel: %Commerce
 # ServiceOwners:                                                   @ms-premp @qiaozha
@@ -851,12 +854,6 @@
 # AzureSdkOwners:                                                  @jairmyree
 # ServiceOwners:                                                   @klaaslanghout
 
-# PRLabel: %Text Translation
-/sdk/translation/azure-ai-translation-text/                        @MikeyMCZ @Azure/azure-java-sdk
-
-# ServiceLabel: %Text Translation
-# ServiceOwners:                                                   @MikeyMCZ
-
 # ServiceLabel: %TimeseriesInsights
 # ServiceOwners:                                                   @Shipra1Mishra
 

.github/copilot-instructions.md

@@ -25,7 +25,10 @@ The Azure SDK for Java repository contains client libraries for Azure services,
 ### Prerequisites
 
 - To use Azure MCP tool calls, users must have PowerShell installed. Provide [PowerShell installation instructions](https://learn.microsoft.com/powershell/scripting/install/installing-powershell) if not installed, and recommend restarting the IDE to start the MCP server.
-- Always run the [`azsdk_verify_setup`](../eng/common/instructions/azsdk-tools/verify-setup.instructions.md) tool to check the user's development environment setup for using SDK MCP tools. DO NOT PROCEED with running other tools before completing this step. Only skip for queries that don't need tools.
+- When using Copilot from Visual Studio or VS Code (not applicable when using Coding Agent on Github.com):
+  - **Always run** the [`azsdk_verify_setup`](../eng/common/instructions/azsdk-tools/verify-setup.instructions.md) tool first to validate the user's development environment for SDK MCP tools.
+  - **Do not proceed** with any other tool execution until this step is complete.
+  - **Skip this check only** for queries that do not require tool execution.
 
 ## Behavior
 

eng/common/instructions/azsdk-tools/check-package-readiness.instructions.md

@@ -15,7 +15,7 @@ Check the release readiness of an SDK package by collecting the required informa
       - Go
 
 2. **Execute Readiness Check**:
-    - Use the `azsdk_check_package_release_readiness` tool with the provided package name and selected language
+    - Use the `azsdk_release_sdk` tool with the provided package name, selected language, and set checkReady to true.
     - Do not check for existing pull requests to run this step.
     - Do not ask the user to create a release plan to run this step.
 

eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

@@ -5,10 +5,16 @@ description: "Guide the user to generate and build SDKs locally for a TypeSpec b
 # Goal
 
 Help the user generate and build SDKs locally from TypeSpec API specifications using the `azure-sdk-mcp` tools.
+High level steps involved:
+1. Generate SDK locally
+2. Build / Compile SDK locally
+3. Run package checks
+4. Run package tests
+5. Update change log, metadata and version
 
 ---
 
-## Part A: Generate SDK Locally
+## Generate SDK Locally
 
 ### Step 1: Outline workflow
 
@@ -20,9 +26,10 @@ Help the user generate and build SDKs locally from TypeSpec API specifications u
   2. Verify SDK repository
   3. Validate repository path
   4. Identify path to configuration file
-  5. Generate SDK using `azsdk_package_generate_code` MCP tool
-  6. Identify SDK project path
-  7. Build/Compile SDK using `azsdk_package_build_code` MCP tool
+  5. Verify setup for the selected language
+  6. Generate SDK using `azsdk_package_generate_code` MCP tool
+  7. Identify SDK project path
+  8. Build/Compile SDK using `azsdk_package_build_code` MCP tool
 - Ask the user to confirm readiness to proceed.
 
 ---
@@ -89,15 +96,20 @@ Help the user generate and build SDKs locally from TypeSpec API specifications u
 
 ---
 
-### Step 6: Generate SDK
-
+### Step 6: Verify setup for selected language
 **Actions**:
+- Run `azsdk_verify_setup` MCP tool to ensure the local environment is correctly configured for the selected SDK language.
+
+---
 
+### Step 7: Generate SDK
+
+**Actions**:
 - Run `azsdk_package_generate_code` MCP tool to generate the SDK locally.
 
 ---
 
-## Part B: Build / Compile SDK Locally
+##  Build / Compile SDK Locally
 
 ### Step 1: Identify SDK project path
 
@@ -117,3 +129,29 @@ Help the user generate and build SDKs locally from TypeSpec API specifications u
 **Actions**:
 
 - Run `azsdk_package_build_code` MCP tool to compile the SDK in the identified project directory.
+
+---
+
+### Step 3: Run package validation
+
+**Actions**:
+
+- Run `azsdk_package_run_check` MCP tool to validate the generated SDK package in the identified project directory.
+
+---
+
+### Step 4: Run package tests
+
+**Actions**:
+
+- Run `azsdk_package_run_tests` MCP tool to run tests on the generated SDK package in the identified project directory.
+
+---
+
+### Step 5: Update change log, metadata and version
+
+**Actions**:
+
+- Run `azsdk_package_update_metadata` MCP tool to update metadata in the identified project directory.
+- Run `azsdk_package_update_changelog_content` MCP tool to update change log in the identified project directory.
+- Run `azsdk_package_update_version` MCP tool to update version in the identified project directory.

eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

@@ -17,8 +17,28 @@ Pre-requisites:
 # SDK generation steps
 
 ## Step: Generate SDKs
-**Goal**: Generate SDKs
-**Message to user**: "SDK generation will take approximately 15-20 minutes. Currently, SDKs are generated using the Azure DevOps pipeline. SDK generation is supported only from a merged API spec or from an API spec pull request in the https://github.com/Azure/azure-rest-api-specs repository."
+
+As a first step, you must prompt the user to understand the intention of SDK generation. Based on the user input, you can either run SDK generation locally or use SDK generation pipeline.
+
+Generate SDK locally in cases below:
+- If the user wants to walk through each SDK generation step locally. This approach requires user to have the setup for each language to generate SDK locally. User can create a pull request for each language after completing all the steps in SDK generation successfully to get the generated SDK reviewed and merged.
+- If SDK or client.tsp customizations are needed before creating a pull request.
+- If the user wants to add tests, samples or any customization to the generated SDK.
+
+Generate SDK using pipeline:
+- If the user wants to generate SDK and get a PR automatically created in Azure SDK language repositories. This approach can be followed if the user does not want to setup local environment for each language.
+
+### Generate SDK locally:
+
+**Condition**: If user chooses to generate SDK locally
+**Message to user**: "Generating SDKs locally requires you to have the development environment set up for each language. Prompt the user to create a pull request for each language after completing the following steps successfully: generation, validation, build, test and update of metadata, change log, and version."
+**Actions**:
+Follow the steps in #file:local-sdk-workflow.instructions.md to generate and build SDKs locally from TypeSpec project.
+
+### Generate SDK using pipeline:
+
+**Condition**: If user chooses to generate the SDK using pipeline or when generating SDK by GitHub coding agent
+**Message to user**: "SDK generation will take approximately 15-20 minutes. SDKs are generated using the Azure DevOps pipeline. SDK generation is supported only from a merged API spec or from an API spec pull request in the https://github.com/Azure/azure-rest-api-specs repository."
 **Actions**:
 1. Identify whether TypeSpec is for Management Plane or Data Plane based on project structure and files. tspconfig.yaml file contains `resource-manager` for management plane and `data-plane` for data plane as resource provider.
   - Execute the SDK generation pipeline with the following required parameters for all languages:
@@ -33,7 +53,8 @@ Pre-requisites:
 2. Monitor pipeline status after 15 minutes and provide updates. If pipeline is in progress, inform user that it may take additional time and check the status later.
 3. Display generated SDK PR links when available. If pipeline fails, inform user with error details and suggest to check pipeline logs for more information.
 4. If SDK pull request is available for all languages, ask user to review generated SDK pull request and mark them as ready for review when they are ready to get them reviewed and merged.
-5. If SDK pull request was created for test purposes, inform user to close the test SDK pull request.
+5. Inform the user that they can checkout generated SDK pull request locally and add more tests, samples or code customizations if needed using local SDK generation tools.
+6. If SDK pull request was created for test purposes, inform user to close the test SDK pull request.
 **Success Criteria**: SDK generation pipeline initiated and SDKs generated
 
 ## Step: SDK release plan

eng/common/instructions/azsdk-tools/verify-setup.instructions.md

@@ -5,7 +5,7 @@ description: 'Verify Setup'
 ## Goal
 This tool verifies the developer's environment for SDK development and release tasks. It returns what requirements are missing for the specified languages and repo, or success if all requirements are satisfied.
 
-Your goal is to identify the project repo root, and pass in the `packagePath` to the Verify Setup tool. For a language repo, pass in the language of the repo.
+Your goal is to identify the project repo root, and pass in the `packagePath` to the Verify Setup tool. For a language repo, pass in the language of the repo. 
 
 ## Examples
 - in `azure-sdk-for-js`, run `azsdk_verify_setup` with `(langs=javascript, packagePath=<path>/azure-sdk-for-js)`.
@@ -14,6 +14,8 @@ Your goal is to identify the project repo root, and pass in the `packagePath` to
 The user can specify multiple languages to check. If the user wants to check all languages, pass in ALL supported languages. Passing in no languages will only check the core requirements.
 
 ## Output
-Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed and how to resolve them.
+Display clear, step-by-step instructions on how to resolve any missing requirements identified. Explain why the requirement is necessary if it has a `reason` field. Organize requirements into categorical sections. 
+
+Based on the user's shell environment, enhance the tool instructions with shell-specific commands for resolving missing dependencies.
 
 When Python tool requirements fail, inform the user about the `AZSDKTOOLS_PYTHON_VENV_PATH` environment variable if they have setup issues. The verify-setup tool can only check Python requirements within the virtual environment specified by this environment variable.

eng/common/pipelines/ai-evals-tests.yml

@@ -1,6 +1,4 @@
-trigger: none
-
-pr:
+trigger:
   branches:
     include:
       - main
@@ -9,6 +7,8 @@ pr:
       - .github/copilot-instructions.md
       - eng/common/instructions/azsdk-tools/**
 
+pr: none
+
 parameters:
   - name: EvalProject
     type: string
@@ -45,4 +45,4 @@ extends:
     EvalRepoCommit: ${{ parameters.EvalRepoCommit }}
     TargetRepoOwner: $(TargetRepoOwner)
     TargetRepoName: $(TargetRepoName)
-    TargetRepoCommit: $(TargetRepoCommit)
+    TargetRepoCommit: $(TargetRepoCommit)

eng/common/pipelines/templates/steps/create-apireview.yml

@@ -37,30 +37,29 @@ steps:
       parameters:
         WorkingDirectory: ${{ parameters.SourceRootPath }}
 
-    - task: Powershell@2
-      inputs:
-        filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1
-        # PackageInfoFiles example: @('a/file1.json','a/file2.json')
-        arguments: >
-          -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}')
-          -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
-          -ArtifactPath '${{parameters.ArtifactPath}}'
-          -ArtifactName ${{ parameters.ArtifactName }}
-          -APIKey '$(azuresdk-apiview-apikey)'
-          -PackageName '${{parameters.PackageName}}'
-          -SourceBranch '$(Build.SourceBranchName)'
-          -DefaultBranch '$(DefaultBranch)'
-          -ConfigFileDir '${{parameters.ConfigFileDir}}'
-          -BuildId '$(Build.BuildId)'
-          -RepoName '$(Build.Repository.Name)'
-          -MarkPackageAsShipped $${{parameters.MarkPackageAsShipped}}
-        pwsh: true
-      displayName: Create API Review
-      condition: >-
-        and(
-          succeededOrFailed(),
-          ne(variables['Skip.CreateApiReview'], 'true'),
-          ne(variables['Build.Reason'],'PullRequest'),
-          eq(variables['System.TeamProject'], 'internal'),
-          not(endsWith(variables['Build.Repository.Name'], '-pr'))
-        )
+    - ${{ if and(eq(variables['System.TeamProject'], 'internal'), ne(variables['Build.Reason'], 'PullRequest'), not(endsWith(variables['Build.Repository.Name'], '-pr'))) }}:
+      - task: AzureCLI@2
+        inputs:
+          azureSubscription: 'APIView prod deployment'
+          scriptType: pscore
+          scriptLocation: scriptPath
+          scriptPath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1
+          # PackageInfoFiles example: @('a/file1.json','a/file2.json')
+          arguments: >
+            -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}')
+            -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
+            -ArtifactPath '${{parameters.ArtifactPath}}'
+            -ArtifactName ${{ parameters.ArtifactName }}
+            -PackageName '${{parameters.PackageName}}'
+            -SourceBranch '$(Build.SourceBranchName)'
+            -DefaultBranch '$(DefaultBranch)'
+            -ConfigFileDir '${{parameters.ConfigFileDir}}'
+            -BuildId '$(Build.BuildId)'
+            -RepoName '$(Build.Repository.Name)'
+            -MarkPackageAsShipped $${{parameters.MarkPackageAsShipped}}
+        displayName: Create API Review
+        condition: >-
+          and(
+            succeededOrFailed(),
+            ne(variables['Skip.CreateApiReview'], 'true')
+          )

eng/common/pipelines/templates/steps/set-test-pipeline-version.yml

@@ -14,9 +14,9 @@ parameters:
 - name: TestPipeline
   type: boolean
   default: false
-- name: ArtifactsJson
-  type: string
-  default: ''
+- name: Artifacts
+  type: object
+  default: []
 
 steps:
 - ${{ if eq(parameters.TestPipeline, true) }}:
@@ -31,5 +31,5 @@ steps:
           -PackageNames '${{ coalesce(parameters.PackageName, parameters.PackageNames) }}'
           -ServiceDirectory '${{ parameters.ServiceDirectory }}'
           -TagSeparator '${{ parameters.TagSeparator }}'
-          -ArtifactsJson '${{ parameters.ArtifactsJson }}'
+          -Artifacts @('${{ replace(convertToJson(parameters.Artifacts), '''', '`''') }}' | ConvertFrom-Json)
         pwsh: true

eng/common/scripts/Create-APIReview.ps1

@@ -4,25 +4,42 @@ Param (
   [array] $ArtifactList,
   [Parameter(Mandatory=$True)]
   [string] $ArtifactPath,
-  [Parameter(Mandatory=$True)]
-  [string] $APIKey,
   [string] $SourceBranch,
   [string] $DefaultBranch,
   [string] $RepoName,
   [string] $BuildId,
   [string] $PackageName = "",
   [string] $ConfigFileDir = "",
-  [string] $APIViewUri = "https://apiview.dev/AutoReview",
+  [string] $APIViewUri = "https://apiview.dev/autoreview",
   [string] $ArtifactName = "packages",
   [bool] $MarkPackageAsShipped = $false,
   [Parameter(Mandatory=$False)]
   [array] $PackageInfoFiles
 )
 
 Set-StrictMode -Version 3
+
 . (Join-Path $PSScriptRoot common.ps1)
 . (Join-Path $PSScriptRoot Helpers ApiView-Helpers.ps1)
 
+# Get Bearer token for APIView authentication
+# In Azure DevOps, this uses the service connection's Managed Identity/Service Principal
+function Get-ApiViewBearerToken()
+{
+    try {
+        $tokenResponse = az account get-access-token --resource "api://apiview" --output json 2>&1
+        if ($LASTEXITCODE -ne 0) {
+            Write-Error "Failed to acquire access token: $tokenResponse"
+            return $null
+        }
+        return ($tokenResponse | ConvertFrom-Json).accessToken
+    }
+    catch {
+        Write-Error "Failed to acquire access token: $($_.Exception.Message)"
+        return $null
+    }
+}
+
 # Submit API review request and return status whether current revision is approved or pending or failed to create review
 function Upload-SourceArtifact($filePath, $apiLabel, $releaseStatus, $packageVersion, $packageType)
 {
@@ -78,9 +95,17 @@ function Upload-SourceArtifact($filePath, $apiLabel, $releaseStatus, $packageVer
         Write-Host "Request param, compareAllRevisions: true"
     }
 
-    $uri = "${APIViewUri}/UploadAutoReview"
+    $uri = "${APIViewUri}/upload"
+    
+    # Get Bearer token for authentication
+    $bearerToken = Get-ApiViewBearerToken
+    if (-not $bearerToken) {
+        Write-Error "Failed to acquire Bearer token for APIView authentication."
+        return [System.Net.HttpStatusCode]::Unauthorized
+    }
+    
     $headers = @{
-        "ApiKey" = $apiKey;
+        "Authorization" = "Bearer $bearerToken";
         "content-type" = "multipart/form-data"
     }
 
@@ -115,20 +140,28 @@ function Upload-ReviewTokenFile($packageName, $apiLabel, $releaseStatus, $review
     if($MarkPackageAsShipped) {
         $params += "&setReleaseTag=true"
     }
-    $uri = "${APIViewUri}/CreateApiReview?${params}"
+    $uri = "${APIViewUri}/create?${params}"
     if ($releaseStatus -and ($releaseStatus -ne "Unreleased"))
     {
         $uri += "&compareAllRevisions=true"
     }
 
     Write-Host "Request to APIView: $uri"
+    
+    # Get Bearer token for authentication
+    $bearerToken = Get-ApiViewBearerToken
+    if (-not $bearerToken) {
+        Write-Error "Failed to acquire Bearer token for APIView authentication."
+        return [System.Net.HttpStatusCode]::Unauthorized
+    }
+    
     $headers = @{
-        "ApiKey" = $APIKey;
+        "Authorization" = "Bearer $bearerToken"
     }
 
     try
     {
-        $Response = Invoke-WebRequest -Method 'GET' -Uri $uri -Headers $headers
+        $Response = Invoke-WebRequest -Method 'POST' -Uri $uri -Headers $headers
         Write-Host "API review: $($Response.Content)"
         $StatusCode = $Response.StatusCode
     }