Skip to content

Conversation

@v-huizhu2
Copy link
Contributor

disable local authentication in namespace creation

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

- Added disableLocalAuth() method call to ServiceBus namespace creation
- Applied disableLocalAuth() to BASIC and STANDARD SKU configurations
- Updated queue and topic creation tests with disableLocalAuth()
- Ensured consistent security configuration across all namespace types
- Updated tag from java/servicebus/azure-resourcemanager-servicebus_9d62dd8d9d to java/servicebus/azure-resourcemanager-servicebus_660023c6a4
Copilot AI review requested due to automatic review settings December 10, 2025 06:37
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes live test failures in the Service Bus management library by disabling local authentication for all Service Bus namespace creations in the test suite. The change ensures that namespaces created during testing align with the updated Azure Service Bus security requirements.

  • Adds .disableLocalAuth() to all 7 namespace creation calls across the test file
  • Updates test recording assets to reflect the new namespace configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/servicebus/azure-resourcemanager-servicebus/src/test/java/com/azure/resourcemanager/servicebus/ServiceBusOperationsTests.java Adds .disableLocalAuth() call to all Service Bus namespace creations in test methods to ensure namespaces are created with local authentication disabled, fixing live test failures
sdk/servicebus/azure-resourcemanager-servicebus/assets.json Updates test recording tag from _9d62dd8d9d to _660023c6a4 to reflect updated test recordings with the new namespace configuration

@weidongxu-microsoft
Copy link
Member

/check-enforcer evaluate

@weidongxu-microsoft
Copy link
Member

/check-enforcer override

@weidongxu-microsoft weidongxu-microsoft merged commit 36b5a7d into Azure:main Dec 15, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants