Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner December 11, 2025 17:55
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the eng/common directory with azure-sdk-tools PR 13235, migrating the APIView integration from API key-based authentication to Azure CLI bearer token authentication using Managed Identity/Service Principal.

Key Changes:

  • Replaced API key authentication with Azure CLI bearer token authentication for improved security
  • Updated APIView endpoint URLs to use lowercase paths (/autoreview, /upload, /create)
  • Changed HTTP method from GET to POST for the review token upload endpoint

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
eng/common/scripts/Create-APIReview.ps1 Removed APIKey parameter, added Get-ApiViewBearerToken function, updated both upload functions to use bearer token authentication, and changed API endpoint URLs to lowercase paths
eng/common/pipelines/templates/steps/create-apireview.yml Changed from Powershell@2 to AzureCLI@2 task, added azureSubscription configuration for 'APIView prod deployment', and removed APIKey parameter from script arguments

@AlitzelMendez
Copy link
Member

/check-enforcer evaluate

@github-actions
Copy link
Contributor

Check Enforcer evaluate was requested, but no Azure Pipelines or Github Actions have been triggered for the changed files.

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

@AlitzelMendez
Copy link
Member

/check-enforcer evaluate

@azure-sdk azure-sdk merged commit a5a2bb7 into main Dec 11, 2025
3 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-stop-using-apikey-13235 branch December 11, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants