-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Sync eng/common directory with azure-sdk-tools for PR 13235 #47543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR synchronizes the eng/common directory with azure-sdk-tools PR 13235, migrating the APIView integration from API key-based authentication to Azure CLI bearer token authentication using Managed Identity/Service Principal.
Key Changes:
- Replaced API key authentication with Azure CLI bearer token authentication for improved security
- Updated APIView endpoint URLs to use lowercase paths (/autoreview, /upload, /create)
- Changed HTTP method from GET to POST for the review token upload endpoint
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/scripts/Create-APIReview.ps1 | Removed APIKey parameter, added Get-ApiViewBearerToken function, updated both upload functions to use bearer token authentication, and changed API endpoint URLs to lowercase paths |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changed from Powershell@2 to AzureCLI@2 task, added azureSubscription configuration for 'APIView prod deployment', and removed APIKey parameter from script arguments |
|
/check-enforcer evaluate |
|
Check Enforcer evaluate was requested, but no Azure Pipelines or Github Actions have been triggered for the changed files. If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run For help using check enforcer, see https://aka.ms/azsdk/checkenforcer |
|
/check-enforcer evaluate |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow