Skip to content

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jan 7, 2026

registrytasks be on old 2019 tag (the one we used for stable release)

excel https://microsoftapc-my.sharepoint.com/:x:/g/personal/qiaozha_microsoft_com/IQDZU9WvZMkAQICngLvxYZMTAbA7ynhR8GnHWefTg_eJeoQ?e=NzIQnO

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-containerregistry

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 7, 2026 09:03
Copilot AI review requested due to automatic review settings January 7, 2026 09:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Azure Container Registry management client by splitting it into two separate internal clients to support different API versions. The registry tasks functionality now uses the older 2019-06-01-preview API version (matching the stable release), while the main registry operations use the newer 2025-11-01 API version.

Key Changes:

  • Created a new ContainerRegistryTasksManagementClient for task-related operations using API version 2019-06-01-preview
  • Removed task-related clients (AgentPools, Runs, TaskRuns, Tasks) from the main ContainerRegistryManagementClient
  • Updated all references from serviceClient() to taskClient() for task operations
  • Removed auto-generated sample files for task operations
  • Updated native image configurations to reflect the split

Reviewed changes

Copilot reviewed 117 out of 142 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ContainerRegistryTasksManagementClientImpl.java New client implementation for task operations with 2019-06-01-preview API
ContainerRegistryTasksManagementClientBuilder.java Builder for the new task client
RegistryTasksClientImpl.java New client for registry task operations (scheduleRun, getBuildSourceUploadUrl)
ContainerRegistryManagementClientImpl.java Removed task-related clients, added apiVersion field
TasksClientImpl.java Updated to use new ContainerRegistryTasksManagementClient
TaskRunsClientImpl.java Updated to use new ContainerRegistryTasksManagementClient
RunsClientImpl.java Updated to use new ContainerRegistryTasksManagementClient
RegistriesClientImpl.java Removed scheduleRun and getBuildSourceUploadUrl methods
RegistryTasksImpl.java Updated to use taskClient() instead of serviceClient()
RegistryTaskRunsImpl.java Updated to use taskClient() instead of serviceClient()
RegistryTaskImpl.java Updated to use taskClient() instead of serviceClient()
RegistryTaskRunImpl.java Updated to use taskClient() instead of serviceClient()
RegistryImpl.java Updated to use taskClient().getRegistryTasks()
RegistriesImpl.java Updated to use taskClient().getRegistryTasks()
RegistryTaskTests.java Updated to use taskClient().getRuns()
api-specs.json Added containerregistrytasks configuration
Various sample files Removed auto-generated samples for task operations
Native image configs Updated proxy-config.json files to reflect client split
Various model files Removed "Code generated" comment lines

Copy link
Member

@haolingdong-msft haolingdong-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haolingdong-msft
Copy link
Member

haolingdong-msft commented Jan 7, 2026

nit: Do we want to add the issue or thread link to note the decision on spliting ACR mgmt to two clients in this PR's description?

@weidongxu-microsoft
Copy link
Member Author

/check-enforcer override

@weidongxu-microsoft
Copy link
Member Author

nit: Do we want to add the issue or thread link to note the decision on spliting ACR mgmt to two clients in this PR's description?

We don't exactly have a "final" decision doc. The closest one is this https://microsoftapc-my.sharepoint.com/:x:/g/personal/qiaozha_microsoft_com/IQDZU9WvZMkAQICngLvxYZMTAbA7ynhR8GnHWefTg_eJeoQ?e=NzIQnO

Logged in PR desc as well.

@weidongxu-microsoft weidongxu-microsoft merged commit 88037ad into Azure:main Jan 8, 2026
21 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_acr-split-two-clients branch January 8, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants