-
Notifications
You must be signed in to change notification settings - Fork 2.1k
mgmt, ACR, split to 2 internal clients #47639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, ACR, split to 2 internal clients #47639
Conversation
...ples/java/com/azure/resourcemanager/containerregistry/generated/AgentPoolsCreateSamples.java
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-containerregistry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Azure Container Registry management client by splitting it into two separate internal clients to support different API versions. The registry tasks functionality now uses the older 2019-06-01-preview API version (matching the stable release), while the main registry operations use the newer 2025-11-01 API version.
Key Changes:
- Created a new
ContainerRegistryTasksManagementClientfor task-related operations using API version 2019-06-01-preview - Removed task-related clients (AgentPools, Runs, TaskRuns, Tasks) from the main
ContainerRegistryManagementClient - Updated all references from
serviceClient()totaskClient()for task operations - Removed auto-generated sample files for task operations
- Updated native image configurations to reflect the split
Reviewed changes
Copilot reviewed 117 out of 142 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ContainerRegistryTasksManagementClientImpl.java | New client implementation for task operations with 2019-06-01-preview API |
| ContainerRegistryTasksManagementClientBuilder.java | Builder for the new task client |
| RegistryTasksClientImpl.java | New client for registry task operations (scheduleRun, getBuildSourceUploadUrl) |
| ContainerRegistryManagementClientImpl.java | Removed task-related clients, added apiVersion field |
| TasksClientImpl.java | Updated to use new ContainerRegistryTasksManagementClient |
| TaskRunsClientImpl.java | Updated to use new ContainerRegistryTasksManagementClient |
| RunsClientImpl.java | Updated to use new ContainerRegistryTasksManagementClient |
| RegistriesClientImpl.java | Removed scheduleRun and getBuildSourceUploadUrl methods |
| RegistryTasksImpl.java | Updated to use taskClient() instead of serviceClient() |
| RegistryTaskRunsImpl.java | Updated to use taskClient() instead of serviceClient() |
| RegistryTaskImpl.java | Updated to use taskClient() instead of serviceClient() |
| RegistryTaskRunImpl.java | Updated to use taskClient() instead of serviceClient() |
| RegistryImpl.java | Updated to use taskClient().getRegistryTasks() |
| RegistriesImpl.java | Updated to use taskClient().getRegistryTasks() |
| RegistryTaskTests.java | Updated to use taskClient().getRuns() |
| api-specs.json | Added containerregistrytasks configuration |
| Various sample files | Removed auto-generated samples for task operations |
| Native image configs | Updated proxy-config.json files to reflect client split |
| Various model files | Removed "Code generated" comment lines |
haolingdong-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...istry/src/main/java/com/azure/resourcemanager/containerregistry/fluent/AgentPoolsClient.java
Show resolved
Hide resolved
|
nit: Do we want to add the issue or thread link to note the decision on spliting ACR mgmt to two clients in this PR's description? |
|
/check-enforcer override |
We don't exactly have a "final" decision doc. The closest one is this https://microsoftapc-my.sharepoint.com/:x:/g/personal/qiaozha_microsoft_com/IQDZU9WvZMkAQICngLvxYZMTAbA7ynhR8GnHWefTg_eJeoQ?e=NzIQnO Logged in PR desc as well. |
registrytasks be on old 2019 tag (the one we used for stable release)
excel https://microsoftapc-my.sharepoint.com/:x:/g/personal/qiaozha_microsoft_com/IQDZU9WvZMkAQICngLvxYZMTAbA7ynhR8GnHWefTg_eJeoQ?e=NzIQnO
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines