Support OpenTelemetry sampling on az.namespace attribute
#42548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
aznamespace-sampling
branch
from
01ea1eb to
427d095
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
joshfree
approved these changes
Oct 28, 2024
lmolkova
approved these changes
Oct 29, 2024
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Let's ship it! I don't see any reason not to do it.
BTW If I could, I would pass namespace as an instrumentation scope attribute (for perf and simplicity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42521
I'm not sure this is needed by our customers given the upcoming open-telemetry/opentelemetry-java-instrumentation#12489, so I don't mind letting it sit for now if there's any concern, I just figured I'd throw out the PR since it was easy 😅