From 234cea15dd2d5d3a3288d9524ce3a9207087615e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 13 Nov 2025 23:30:25 +0000 Subject: [PATCH 1/2] Initial plan From e658dce9cfc75993a4cea694be484fd98fa61870 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 13 Nov 2025 23:41:10 +0000 Subject: [PATCH 2/2] Fix confusing disableAutoComplete() examples in README and sample files Co-authored-by: samvaity <16845631+samvaity@users.noreply.github.com> --- sdk/servicebus/azure-messaging-servicebus/README.md | 4 ---- .../azure/messaging/servicebus/ServiceBusClientBuilder.java | 4 ---- .../azure/messaging/servicebus/ServiceBusProcessorClient.java | 3 --- .../java/com/azure/messaging/servicebus/package-info.java | 1 - .../ServiceBusProcessorClientJavaDocCodeSamples.java | 3 --- .../ServiceBusReceiverClientJavaDocCodeSamples.java | 1 - 6 files changed, 16 deletions(-) diff --git a/sdk/servicebus/azure-messaging-servicebus/README.md b/sdk/servicebus/azure-messaging-servicebus/README.md index 2ca83c02e404..d47c8124f670 100644 --- a/sdk/servicebus/azure-messaging-servicebus/README.md +++ b/sdk/servicebus/azure-messaging-servicebus/README.md @@ -265,7 +265,6 @@ ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). .processMessage(processMessage) .processError(processError) - .disableAutoComplete() .buildProcessorClient(); // Starts the processor in the background. Control returns immediately. @@ -302,7 +301,6 @@ TokenCredential tokenCredential = new DefaultAzureCredentialBuilder().build(); // Create the processor client via the builder and its sub-builder // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" -// 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon). ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() .credential(fullyQualifiedNamespace, tokenCredential) .processor() @@ -310,7 +308,6 @@ ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() .receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE) .processMessage(processMessage) .processError(processError) - .disableAutoComplete() .buildProcessorClient(); // Starts the processor in the background. Control returns immediately. @@ -385,7 +382,6 @@ created the same way as shown below. Learn more about dead-letter queue [here][d TokenCredential credential = new DefaultAzureCredentialBuilder().build(); // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" -// 'disableAutoComplete' indicates that users will explicitly settle their message. ServiceBusReceiverClient receiver = new ServiceBusClientBuilder() .credential(fullyQualifiedNamespace, credential) .receiver() // Use this for session or non-session enabled queue or topic/subscriptions diff --git a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java index 089f87a89b99..c4f868e13124 100644 --- a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java +++ b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java @@ -254,7 +254,6 @@ * .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. @@ -2333,7 +2332,6 @@ private ServiceBusSessionReceiverAsyncClient buildAsyncClient(boolean isForSyncM * .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. @@ -2370,7 +2368,6 @@ private ServiceBusSessionReceiverAsyncClient buildAsyncClient(boolean isForSyncM * * // Create the processor client via the builder and its sub-builder * // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" - * // 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon). * ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() * .credential(fullyQualifiedNamespace, tokenCredential) * .processor() @@ -2378,7 +2375,6 @@ private ServiceBusSessionReceiverAsyncClient buildAsyncClient(boolean isForSyncM * .receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE) * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. diff --git a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java index 1087db0d8230..508b0e2c6b2e 100644 --- a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java +++ b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java @@ -79,7 +79,6 @@ * .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. @@ -116,7 +115,6 @@ * * // Create the processor client via the builder and its sub-builder * // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" - * // 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon). * ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() * .credential(fullyQualifiedNamespace, tokenCredential) * .processor() @@ -124,7 +122,6 @@ * .receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE) * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. diff --git a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/package-info.java b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/package-info.java index 3208dab01980..857f9c0c9ab6 100644 --- a/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/package-info.java +++ b/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/package-info.java @@ -184,7 +184,6 @@ * .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). * .processMessage(processMessage) * .processError(processError) - * .disableAutoComplete() * .buildProcessorClient(); * * // Starts the processor in the background. Control returns immediately. diff --git a/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusProcessorClientJavaDocCodeSamples.java b/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusProcessorClientJavaDocCodeSamples.java index fe33b2485269..f2637cec7244 100644 --- a/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusProcessorClientJavaDocCodeSamples.java +++ b/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusProcessorClientJavaDocCodeSamples.java @@ -84,7 +84,6 @@ public void createServiceBusProcessorClientInPeekLockMode() { .disableAutoComplete() // Make sure to explicitly opt in to manual settlement (e.g. complete, abandon). .processMessage(processMessage) .processError(processError) - .disableAutoComplete() .buildProcessorClient(); // Starts the processor in the background. Control returns immediately. @@ -125,7 +124,6 @@ public void createServiceBusProcessorClientInReceiveAndDeleteMode() { // Create the processor client via the builder and its sub-builder // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" - // 'disableAutoComplete()' will opt in to manual settlement (e.g. complete, abandon). ServiceBusProcessorClient processorClient = new ServiceBusClientBuilder() .credential(fullyQualifiedNamespace, tokenCredential) .processor() @@ -133,7 +131,6 @@ public void createServiceBusProcessorClientInReceiveAndDeleteMode() { .receiveMode(ServiceBusReceiveMode.RECEIVE_AND_DELETE) .processMessage(processMessage) .processError(processError) - .disableAutoComplete() .buildProcessorClient(); // Starts the processor in the background. Control returns immediately. diff --git a/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusReceiverClientJavaDocCodeSamples.java b/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusReceiverClientJavaDocCodeSamples.java index 382e50bef798..d5a1a2ee300f 100644 --- a/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusReceiverClientJavaDocCodeSamples.java +++ b/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusReceiverClientJavaDocCodeSamples.java @@ -114,7 +114,6 @@ public void instantiateDeadLetterQueue() { TokenCredential credential = new DefaultAzureCredentialBuilder().build(); // 'fullyQualifiedNamespace' will look similar to "{your-namespace}.servicebus.windows.net" - // 'disableAutoComplete' indicates that users will explicitly settle their message. ServiceBusReceiverClient receiver = new ServiceBusClientBuilder() .credential(fullyQualifiedNamespace, credential) .receiver() // Use this for session or non-session enabled queue or topic/subscriptions