Skip to content

Commit 4d8911e

Browse files
jeremymengjeremymeng
authored
[core] remove core-http from main branch (#27994)
We plan to deprecate `@azure/core-http` soon and it has been maintained and released from `sotrage/stable` branch for a while. This PR removes it from main branch of the repo. - remove sdk/core/core-http directory - update references to core-http in documentation - publish communication-sms samples so previous change of moving from core-http to core-util is reflected.
1 parent 07dcc9e commit 4d8911e

File tree

158 files changed

+89
-25378
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

158 files changed

+89
-25378
lines changed

‎common/config/rush/pnpm-lock.yaml‎

Lines changed: 5 additions & 376 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎rush.json‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -530,14 +530,6 @@
530530
"projectFolder": "sdk/core/core-client",
531531
"versionPolicyName": "core"
532532
},
533-
{
534-
"packageName": "@azure/core-http",
535-
"projectFolder": "sdk/core/core-http",
536-
"decoupledLocalDependencies": [
537-
"@azure/core-tracing"
538-
],
539-
"versionPolicyName": "core"
540-
},
541533
{
542534
"packageName": "@azure/core-rest-pipeline",
543535
"projectFolder": "sdk/core/core-rest-pipeline",

‎sdk/communication/communication-sms/samples/v1/javascript/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ node sendSms.js
5151
Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
5252

5353
```bash
54-
npx cross-env COMMUNICATION_SAMPLES_CONNECTION_STRING="<communication samples connection string>" FROM_PHONE_NUMBER="<from phone number>" AZURE_PHONE_NUMBER="<azure phone number>" TO_PHONE_NUMBERS="<to phone numbers>" AZURE_PHONE_NUMBER="<azure phone number>" node sendSms.js
54+
npx cross-env COMMUNICATION_SAMPLES_CONNECTION_STRING="<communication samples connection string>" FROM_PHONE_NUMBER="<from phone number>" TO_PHONE_NUMBERS="<to phone numbers>" AZURE_PHONE_NUMBER="<azure phone number>" node sendSms.js
5555
```
5656

5757
## Next Steps

‎sdk/communication/communication-sms/samples/v1/javascript/package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"dependencies": {
2828
"@azure/communication-sms": "latest",
2929
"dotenv": "latest",
30-
"@azure/communication-common": "^2.1.0",
31-
"@azure/core-rest-pipeline": "^1.8.0",
32-
"@azure/identity": "^2.0.1"
30+
"@azure/communication-common": "^2.2.0",
31+
"@azure/core-util": "^1.0.0",
32+
"@azure/identity": "^3.3.0"
3333
}
3434
}

‎sdk/communication/communication-sms/samples/v1/javascript/sendSms.js‎

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
const { SmsClient } = require("@azure/communication-sms");
99

1010
// Load the .env file if it exists
11-
const dotenv = require("dotenv");
12-
dotenv.config();
11+
require("dotenv").config();
1312

1413
async function main() {
1514
console.log("== Send SMS Message ==");
@@ -23,13 +22,19 @@ async function main() {
2322
const client = new SmsClient(connectionString);
2423

2524
// construct send request
25+
let phoneNumbers;
26+
if (process.env.TO_PHONE_NUMBERS !== undefined) {
27+
phoneNumbers = process.env.TO_PHONE_NUMBERS.split(",");
28+
} else if (process.env.AZURE_PHONE_NUMBER !== undefined) {
29+
phoneNumbers = [process.env.AZURE_PHONE_NUMBER];
30+
} else {
31+
phoneNumbers = ["<to-phone-number-1>", "<to-phone-number-2>"];
32+
}
33+
2634
const sendRequest = {
2735
from: process.env.FROM_PHONE_NUMBER || process.env.AZURE_PHONE_NUMBER || "<from-phone-number>",
28-
to: process.env.TO_PHONE_NUMBERS?.split(",") || [process.env.AZURE_PHONE_NUMBER] || [
29-
"<to-phone-number-1>",
30-
"<to-phone-number-2>"
31-
],
32-
message: "Hello World via SMS!"
36+
to: phoneNumbers,
37+
message: "Hello World via SMS!",
3338
};
3439

3540
// send sms with request
@@ -52,3 +57,5 @@ main().catch((error) => {
5257
console.error("Encountered an error while sending SMS: ", error);
5358
process.exit(1);
5459
});
60+
61+
module.exports = { main };

‎sdk/communication/communication-sms/samples/v1/javascript/sendSmsWithOptions.js‎

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
const { SmsClient } = require("@azure/communication-sms");
99

1010
// Load the .env file if it exists
11-
const dotenv = require("dotenv");
12-
dotenv.config();
11+
require("dotenv").config();
1312

1413
async function main() {
1514
console.log("== Send SMS Message With Options ==");
@@ -23,21 +22,27 @@ async function main() {
2322
const client = new SmsClient(connectionString);
2423

2524
// construct send request
25+
let phoneNumbers;
26+
if (process.env.TO_PHONE_NUMBERS !== undefined) {
27+
phoneNumbers = process.env.TO_PHONE_NUMBERS.split(",");
28+
} else if (process.env.AZURE_PHONE_NUMBER !== undefined) {
29+
phoneNumbers = [process.env.AZURE_PHONE_NUMBER];
30+
} else {
31+
phoneNumbers = ["<to-phone-number-1>", "<to-phone-number-2>"];
32+
}
33+
2634
const sendRequest = {
2735
from: process.env.FROM_PHONE_NUMBER || process.env.AZURE_PHONE_NUMBER || "<from-phone-number>",
28-
to: process.env.TO_PHONE_NUMBERS?.split(",") || [process.env.AZURE_PHONE_NUMBER] || [
29-
"<to-phone-number-1>",
30-
"<to-phone-number-2>"
31-
],
32-
message: "Hello World via SMS!"
36+
to: phoneNumbers,
37+
message: "Hello World via SMS!",
3338
};
3439

3540
// construct send options
3641
const sendOptions = {
3742
//delivery reports are delivered via EventGrid
3843
enableDeliveryReport: true,
3944
//tags are applied to the delivery report
40-
tag: "marketing"
45+
tag: "marketing",
4146
};
4247

4348
// send sms with request and options
@@ -60,3 +65,5 @@ main().catch((error) => {
6065
console.error("Encountered an error while sending SMS: ", error);
6166
process.exit(1);
6267
});
68+
69+
module.exports = { main };

‎sdk/communication/communication-sms/samples/v1/javascript/usingAadAuth.js‎

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@
77

88
const { parseConnectionString } = require("@azure/communication-common");
99
const { SmsClient } = require("@azure/communication-sms");
10-
const { isNode } = require("@azure/core-http");
10+
const { isNode } = require("@azure/core-util");
1111
const { ClientSecretCredential, DefaultAzureCredential } = require("@azure/identity");
1212

1313
// Load the .env file if it exists
14-
const dotenv = require("dotenv");
15-
dotenv.config();
14+
require("dotenv").config();
1615

1716
async function main() {
1817
console.log("== Send SMS Message With AAD Authentication ==");
@@ -29,7 +28,7 @@ async function main() {
2928
!process.env.AZURE_CLIENT_SECRET
3029
) {
3130
console.error(
32-
"Azure AD authentication information not provided, but it is required to run this sample. Exiting."
31+
"Azure AD authentication information not provided, but it is required to run this sample. Exiting.",
3332
);
3433
return;
3534
}
@@ -40,20 +39,26 @@ async function main() {
4039
: new ClientSecretCredential(
4140
process.env.AZURE_TENANT_ID,
4241
process.env.AZURE_CLIENT_ID,
43-
process.env.AZURE_CLIENT_SECRET
42+
process.env.AZURE_CLIENT_SECRET,
4443
);
4544

4645
// create new client with endpoint and credentials
4746
const client = new SmsClient(endpoint, credential);
4847

4948
// construct send request
49+
let phoneNumbers;
50+
if (process.env.TO_PHONE_NUMBERS !== undefined) {
51+
phoneNumbers = process.env.TO_PHONE_NUMBERS.split(",");
52+
} else if (process.env.AZURE_PHONE_NUMBER !== undefined) {
53+
phoneNumbers = [process.env.AZURE_PHONE_NUMBER];
54+
} else {
55+
phoneNumbers = ["<to-phone-number-1>", "<to-phone-number-2>"];
56+
}
57+
5058
const sendRequest = {
5159
from: process.env.FROM_PHONE_NUMBER || process.env.AZURE_PHONE_NUMBER || "<from-phone-number>",
52-
to: process.env.TO_PHONE_NUMBERS?.split(",") || [process.env.AZURE_PHONE_NUMBER] || [
53-
"<to-phone-number-1>",
54-
"<to-phone-number-2>"
55-
],
56-
message: "Hello World via SMS!"
60+
to: phoneNumbers,
61+
message: "Hello World via SMS!",
5762
};
5863

5964
// send sms with request
@@ -72,3 +77,5 @@ main().catch((error) => {
7277
console.error("Encountered an error while sending SMS: ", error);
7378
process.exit(1);
7479
});
80+
81+
module.exports = { main };

‎sdk/communication/communication-sms/samples/v1/typescript/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ node dist/sendSms.js
6363
Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
6464

6565
```bash
66-
npx cross-env COMMUNICATION_SAMPLES_CONNECTION_STRING="<communication samples connection string>" FROM_PHONE_NUMBER="<from phone number>" AZURE_PHONE_NUMBER="<azure phone number>" TO_PHONE_NUMBERS="<to phone numbers>" AZURE_PHONE_NUMBER="<azure phone number>" node dist/sendSms.js
66+
npx cross-env COMMUNICATION_SAMPLES_CONNECTION_STRING="<communication samples connection string>" TO_PHONE_NUMBERS="<to phone numbers>" TO_PHONE_NUMBERS="<to phone numbers>" AZURE_PHONE_NUMBER="<azure phone number>" AZURE_PHONE_NUMBER="<azure phone number>" FROM_PHONE_NUMBER="<from phone number>" AZURE_PHONE_NUMBER="<azure phone number>" node dist/sendSms.js
6767
```
6868

6969
## Next Steps

‎sdk/communication/communication-sms/samples/v1/typescript/package.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@
3131
"dependencies": {
3232
"@azure/communication-sms": "latest",
3333
"dotenv": "latest",
34-
"@azure/communication-common": "^2.1.0",
35-
"@azure/core-rest-pipeline": "^1.8.0",
36-
"@azure/identity": "^2.0.1"
34+
"@azure/communication-common": "^2.2.0",
35+
"@azure/core-util": "^1.0.0",
36+
"@azure/identity": "^3.3.0"
3737
},
3838
"devDependencies": {
39+
"@types/node": "^18.0.0",
3940
"typescript": "~5.2.0",
4041
"rimraf": "latest"
4142
}

‎sdk/communication/communication-sms/samples/v1/typescript/src/sendSms.ts‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,17 @@ export async function main() {
2525
// construct send request
2626
let phoneNumbers: string[];
2727
if (process.env.TO_PHONE_NUMBERS !== undefined) {
28-
phoneNumbers = process.env.TO_PHONE_NUMBERS.split(",")
29-
}
30-
else if (process.env.AZURE_PHONE_NUMBER !== undefined) {
31-
phoneNumbers = [process.env.AZURE_PHONE_NUMBER]
32-
}
33-
else {
34-
phoneNumbers = ["<to-phone-number-1>", "<to-phone-number-2>"]
28+
phoneNumbers = process.env.TO_PHONE_NUMBERS.split(",");
29+
} else if (process.env.AZURE_PHONE_NUMBER !== undefined) {
30+
phoneNumbers = [process.env.AZURE_PHONE_NUMBER];
31+
} else {
32+
phoneNumbers = ["<to-phone-number-1>", "<to-phone-number-2>"];
3533
}
3634

3735
const sendRequest: SmsSendRequest = {
3836
from: process.env.FROM_PHONE_NUMBER || process.env.AZURE_PHONE_NUMBER || "<from-phone-number>",
3937
to: phoneNumbers,
40-
message: "Hello World via SMS!"
38+
message: "Hello World via SMS!",
4139
};
4240

4341
// send sms with request

0 commit comments

Comments
 (0)