builds and runs, need to fix implementation

Author: maorleger

pnpm-lock.yaml

@@ -5,10 +5,10 @@
 ```ts
 
 import { AzureKeyCredential } from '@azure/core-auth';
-import { ClientOptions } from '@azure-rest/core-client';
+import type { ClientOptions } from '@azure-rest/core-client';
 import type { KeyCredential } from '@azure/core-auth';
 import type { OperationOptions } from '@azure-rest/core-client';
-import type { Pipeline } from '@azure/core-rest-pipeline';
+import { Pipeline } from '@azure/core-rest-pipeline';
 import type { RestError } from '@azure/core-rest-pipeline';
 import type { TokenCredential } from '@azure/core-auth';
 

sdk/search/search-documents/review/search-documents-node.api.md

@@ -6,7 +6,10 @@
 import type { KeyCredential, TokenCredential } from "@azure/core-auth";
 import { isTokenCredential } from "@azure/core-auth";
 import type { Pipeline } from "@azure/core-rest-pipeline";
-import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
+import {
+  bearerTokenAuthenticationPolicy,
+  bearerTokenAuthenticationPolicyName,
+} from "@azure/core-rest-pipeline";
 import type {
   KnowledgeBaseRetrievalRequest,
   KnowledgeBaseRetrievalResponse,
@@ -124,6 +127,9 @@ export class KnowledgeRetrievalClient {
 
     this.pipeline = this.client.pipeline;
 
+    // TODO: consider leaving the policy in-place instead of removing and re-adding
+    this.pipeline.removePolicy({ name: bearerTokenAuthenticationPolicyName });
+
     if (isTokenCredential(credential)) {
       const scope: string = options.audience
         ? `${options.audience}/.default`

sdk/search/search-documents/src/knowledgeRetrievalClient.ts

@@ -5,8 +5,11 @@
 
 import type { KeyCredential, TokenCredential } from "@azure/core-auth";
 import { isTokenCredential } from "@azure/core-auth";
-import type { Pipeline } from "@azure/core-rest-pipeline";
-import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
+import {
+  bearerTokenAuthenticationPolicy,
+  bearerTokenAuthenticationPolicyName,
+  type Pipeline,
+} from "@azure/core-rest-pipeline";
 import { decode, encode } from "./base64.js";
 import type {
   AutocompleteResult,
@@ -17,10 +20,8 @@ import type {
   SearchRequest as GeneratedSearchRequest,
   VectorQueryUnion as GeneratedVectorQuery,
 } from "./models/azure/search/documents/index.js";
-import {
-  SearchClient as GeneratedClient,
-  SearchClientOptionalParams,
-} from "./search/searchClient.js";
+import type { SearchClientOptionalParams } from "./search/searchClient.js";
+import { SearchClient as GeneratedClient } from "./search/searchClient.js";
 import { IndexDocumentsBatch } from "./indexDocumentsBatch.js";
 import type {
   AutocompleteOptions,
@@ -58,8 +59,8 @@ import type { IndexDocumentsClient } from "./searchIndexingBufferedSender.js";
 import { deserialize, serialize } from "./serialization.js";
 import * as utils from "./serviceUtils.js";
 import { createSpan, tracingClient } from "./tracing.js";
-import { ClientOptions, OperationOptions } from "@azure-rest/core-client";
-import { GetDocumentOptionalParams, SuggestPostOptionalParams } from "./search/index.js";
+import type { ClientOptions, OperationOptions } from "@azure-rest/core-client";
+import type { GetDocumentOptionalParams, SuggestPostOptionalParams } from "./search/index.js";
 
 /**
  * Client options used to configure AI Search API requests.
@@ -207,11 +208,13 @@ export class SearchClient<TModel extends object> implements IndexDocumentsClient
 
     this.pipeline = this.client.pipeline;
 
+    // TODO: consider leaving the policy in-place instead of removing and re-adding
+    this.pipeline.removePolicy({ name: bearerTokenAuthenticationPolicyName });
+
     if (isTokenCredential(credential)) {
       const scope: string = options.audience
         ? `${options.audience}/.default`
         : `${KnownSearchAudience.AzurePublicCloud}/.default`;
-
       this.client.pipeline.addPolicy(
         bearerTokenAuthenticationPolicy({ credential, scopes: scope }),
       );

sdk/search/search-documents/src/searchClient.ts

@@ -6,7 +6,10 @@
 import type { KeyCredential, TokenCredential } from "@azure/core-auth";
 import { isTokenCredential } from "@azure/core-auth";
 import type { Pipeline } from "@azure/core-rest-pipeline";
-import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
+import {
+  bearerTokenAuthenticationPolicy,
+  bearerTokenAuthenticationPolicyName,
+} from "@azure/core-rest-pipeline";
 import type {
   AnalyzeResult,
   // KnowledgeSourceStatus,
@@ -182,6 +185,9 @@ export class SearchIndexClient {
     this.client = new GeneratedClient(this.endpoint, credential, internalClientPipelineOptions);
     this.pipeline = this.client.pipeline;
 
+    // TODO: consider leaving the policy in-place instead of removing and re-adding
+    this.pipeline.removePolicy({ name: bearerTokenAuthenticationPolicyName });
+
     if (isTokenCredential(credential)) {
       const scope: string = this.options.audience
         ? `${this.options.audience}/.default`

sdk/search/search-documents/src/searchIndexClient.ts

@@ -4,12 +4,13 @@
 import type { KeyCredential, TokenCredential } from "@azure/core-auth";
 import { isTokenCredential } from "@azure/core-auth";
 import type { Pipeline } from "@azure/core-rest-pipeline";
-import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
-import type { SearchIndexerStatus } from "./models/azure/search/documents/indexes/index.js";
 import {
-  SearchIndexerClient as GeneratedClient,
-  SearchIndexerClientOptionalParams,
-} from "./searchIndexer/searchIndexerClient.js";
+  bearerTokenAuthenticationPolicy,
+  bearerTokenAuthenticationPolicyName,
+} from "@azure/core-rest-pipeline";
+import type { SearchIndexerStatus } from "./models/azure/search/documents/indexes/index.js";
+import type { SearchIndexerClientOptionalParams } from "./searchIndexer/searchIndexerClient.js";
+import { SearchIndexerClient as GeneratedClient } from "./searchIndexer/searchIndexerClient.js";
 import { logger } from "./logger.js";
 import { createOdataMetadataPolicy } from "./odataMetadataPolicy.js";
 import { createSearchApiKeyCredentialPolicy } from "./searchApiKeyCredentialPolicy.js";
@@ -41,7 +42,7 @@ import type {
 } from "./serviceModels.js";
 import * as utils from "./serviceUtils.js";
 import { tracingClient } from "./tracing.js";
-import { ClientOptions } from "@azure-rest/core-client";
+import type { ClientOptions } from "@azure-rest/core-client";
 
 /**
  * Client options used to configure AI Search API requests.
@@ -142,6 +143,9 @@ export class SearchIndexerClient {
     this.client = new GeneratedClient(this.endpoint, credential, internalClientPipelineOptions);
     this.pipeline = this.client.pipeline;
 
+    // TODO: consider leaving the policy in-place instead of removing and re-adding
+    this.pipeline.removePolicy({ name: bearerTokenAuthenticationPolicyName });
+
     if (isTokenCredential(credential)) {
       const scope: string = options.audience
         ? `${options.audience}/.default`