Commit d1b2cc5
Fix abort signal propagation in memory store update poller (#36707)
The `buildRunningOperation` function wasn't receiving the user-provided
`options.abortSignal`, preventing proper cancellation of ongoing poll
requests.
**Changes:**
- Pass `options` parameter to `buildRunningOperation` to capture
user-provided abort signal
- Update `sendPollRequest` to listen to both `options.abortSignal` and
`pollOptions?.abortSignal`
- Add event listeners for both signals with proper cleanup in finally
block
This aligns with the reference implementation in `pollingHelpers.ts`
lines 53-94.
```typescript
// Before: only pollOptions abort signal was handled
sendPollRequest: async (path: string, pollOptions?: { abortSignal?: AbortSignalLike }) => {
if (pollOptions?.abortSignal?.aborted) {
pollAbortController.abort();
}
// ...
}
// After: both user-provided and poll-specific signals are handled
sendPollRequest: async (path: string, pollOptions?: { abortSignal?: AbortSignalLike }) => {
if (options?.abortSignal?.aborted) {
pollAbortController.abort();
} else if (pollOptions?.abortSignal?.aborted) {
pollAbortController.abort();
} else if (!abortSignal.aborted) {
options?.abortSignal?.addEventListener("abort", abortListener, { once: true });
pollOptions?.abortSignal?.addEventListener("abort", abortListener, { once: true });
}
// ...
}
```
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
---------
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: glharper <[email protected]>1 parent cae1fc3 commit d1b2cc5
File tree
1 file changed
+10
-1
lines changed- sdk/ai/ai-projects/src/api/memoryStores
1 file changed
+10
-1
lines changedLines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| |||
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| 150 | + | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
152 | 154 | | |
153 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
154 | 158 | | |
155 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
156 | 163 | | |
157 | 164 | | |
158 | 165 | | |
| |||
162 | 169 | | |
163 | 170 | | |
164 | 171 | | |
| 172 | + | |
165 | 173 | | |
166 | 174 | | |
167 | 175 | | |
| |||
191 | 199 | | |
192 | 200 | | |
193 | 201 | | |
| 202 | + | |
194 | 203 | | |
195 | 204 | | |
196 | 205 | | |
| |||
0 commit comments