[test][core] replace assert.ok/notOk with more specific assertions (#36393)

Author: jeremymeng

sdk/core/core-amqp/test/cbs.spec.ts

@@ -23,7 +23,7 @@ describe("CbsClient", function () {
         await cbsClient.init({ abortSignal: signal });
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal((err as Error).name, "AbortError");
       }
     });
@@ -55,7 +55,7 @@ describe("CbsClient", function () {
         await cbsClient.init({ abortSignal: signal });
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal((err as Error).name, "AbortError");
       }
     });
@@ -76,7 +76,7 @@ describe("CbsClient", function () {
         await cbsClient.init({ abortSignal: signal });
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal((err as Error).name, "AbortError");
       }
     });
@@ -91,7 +91,7 @@ describe("CbsClient", function () {
         await cbsClient.negotiateClaim("audience", "token", TokenType.CbsTokenTypeSas);
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal(
           (err as Error).message,
           "Attempted to negotiate a claim but the CBS link does not exist.",
@@ -116,7 +116,7 @@ describe("CbsClient", function () {
           });
           throw new Error(TEST_FAILURE);
         } catch (err) {
-          assert.ok(isError(err));
+          assert.isTrue(isError(err));
           assert.equal((err as Error).name, "AbortError");
         }
       });
@@ -139,7 +139,7 @@ describe("CbsClient", function () {
           });
           throw new Error(TEST_FAILURE);
         } catch (err) {
-          assert.ok(isError(err));
+          assert.isTrue(isError(err));
           assert.equal((err as Error).name, "AbortError");
         }
       });

sdk/core/core-amqp/test/message.spec.ts

@@ -27,7 +27,7 @@ describe("message", function () {
       const annotatedMessage = AmqpAnnotatedMessage.fromRheaMessage(rhMsg);
 
       const expectedTtl = rhMsg.absolute_expiry_time!.getTime() - rhMsg.creation_time!.getTime();
-      assert.ok(
+      assert.isDefined(
         annotatedMessage.header?.timeToLive,
         "Expecting valid annotatedMsg.header.timeToLive",
       );
@@ -43,7 +43,7 @@ describe("message", function () {
       const annotatedMessage = AmqpAnnotatedMessage.fromRheaMessage(rhMsg);
 
       const expectedTtl = 49 * 24 * 60 * 60 * 1000;
-      assert.ok(
+      assert.isDefined(
         annotatedMessage.header?.timeToLive,
         "Expecting valid annotatedMsg.header.timeToLive",
       );
@@ -61,8 +61,8 @@ describe("message", function () {
       const rhMsg = AmqpAnnotatedMessage.toRheaMessage(input);
 
       assert.equal(Constants.maxUint32Value, rhMsg.ttl);
-      assert.ok(rhMsg.creation_time);
-      assert.ok(rhMsg.absolute_expiry_time);
+      assert.isDefined(rhMsg.creation_time);
+      assert.isDefined(rhMsg.absolute_expiry_time);
       assert.equal(
         rhMsg.creation_time!.getTime() + oneHundredDaysInMs,
         rhMsg.absolute_expiry_time!.getTime(),
@@ -121,8 +121,8 @@ describe("message", function () {
       const rhMsg = AmqpAnnotatedMessage.toRheaMessage(input);
 
       assert.equal(rhMsg.ttl, sevenDayInMs);
-      assert.ok(rhMsg.creation_time);
-      assert.ok(rhMsg.absolute_expiry_time);
+      assert.isDefined(rhMsg.creation_time);
+      assert.isDefined(rhMsg.absolute_expiry_time);
       assert.equal(
         rhMsg.absolute_expiry_time!.getTime(),
         rhMsg.creation_time!.getTime() + sevenDayInMs,

sdk/core/core-amqp/test/requestResponse.spec.ts

@@ -55,7 +55,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
         await RequestResponseLink.create(connection, {}, {}, { abortSignal: signal });
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal((err as Error).name, "AbortError");
       }
     });
@@ -73,7 +73,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
         await RequestResponseLink.create(connection, {}, {}, { abortSignal: signal });
         throw new Error(TEST_FAILURE);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         assert.equal((err as Error).name, "AbortError");
       }
     });
@@ -321,7 +321,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
       await failedRequest;
       throw new Error("Test failure");
     } catch (err) {
-      assert.ok(isError(err));
+      assert.isTrue(isError(err));
       assert.notEqual((err as Error).message, "Test failure");
     }
 
@@ -467,7 +467,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
       await link.sendRequest(request, { abortSignal: signal, requestName: "foo" });
       throw new Error(`Test failure`);
     } catch (err) {
-      assert.ok(isError(err));
+      assert.isTrue(isError(err));
       const error = err as Error;
       assert.equal(error.name, "AbortError", `Error name ${error.name} is not as expected`);
       assert.equal(
@@ -541,7 +541,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
       });
       throw new Error(`Test failure`);
     } catch (err) {
-      assert.ok(isError(err));
+      assert.isTrue(isError(err));
       const error = err as Error;
       assert.equal(error.name, "AbortError", `Error name ${error.name} is not as expected`);
       assert.equal(
@@ -606,7 +606,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
       await link.sendRequest(request, { abortSignal: signal, requestName: "foo" });
       throw new Error(`Test failure`);
     } catch (err) {
-      assert.ok(isError(err));
+      assert.isTrue(isError(err));
       const error = err as Error;
       assert.equal(error.name, "AbortError", `Error name ${error.name} is not as expected`);
       assert.equal(
@@ -684,7 +684,7 @@ describe.skipIf(isBrowser)("RequestResponseLink", function () {
         await link.sendRequest(request, { timeoutInMs: 120000, requestName: "foo" });
         throw new Error(testFailureMessage);
       } catch (err) {
-        assert.ok(isError(err));
+        assert.isTrue(isError(err));
         const error = err as Error;
         assert.notEqual(error.message, testFailureMessage);
       }

sdk/core/core-auth/test/index.spec.ts

@@ -144,7 +144,7 @@ describe("AzureSASCredential", () => {
 
 describe("isTokenCredential", function () {
   it("should return true for an object that resembles a TokenCredential", () => {
-    assert.ok(
+    assert.isTrue(
       isTokenCredential({
         getToken() {
           return Promise.resolve({
@@ -207,7 +207,7 @@ describe("isTokenCredential", function () {
 
 describe("isNamedKeyCredential", function () {
   it("should return true for an object that resembles a NamedKeyCredential", () => {
-    assert.ok(isNamedKeyCredential({ name: "foo", key: "bar" }));
+    assert.isTrue(isNamedKeyCredential({ name: "foo", key: "bar" }));
   });
 
   it("should return false for an object that does not resemble a NamedKeyCredential", () => {
@@ -217,7 +217,7 @@ describe("isNamedKeyCredential", function () {
 
 describe("isSASCredential", function () {
   it("should return true for an object that resembles a isSASCredential", () => {
-    assert.ok(isSASCredential({ signature: "sig" }));
+    assert.isTrue(isSASCredential({ signature: "sig" }));
   });
 
   it("should return false for an object that does not resemble a isSASCredential", () => {
@@ -227,7 +227,7 @@ describe("isSASCredential", function () {
 
 describe("isKeyCredential", function () {
   it("should return true for an object that resembles a KeyCredential", () => {
-    assert.ok(isKeyCredential({ key: "bar" }));
+    assert.isTrue(isKeyCredential({ key: "bar" }));
   });
 
   it("should return false for an object that does not resemble a KeyCredential", () => {

sdk/core/core-client/test/serviceClient.spec.ts

@@ -1264,7 +1264,7 @@ describe("ServiceClient", function () {
       },
     });
     const response = await client.sendOperationRequest<{ body: Date }>({}, operationSpec);
-    assert.ok(response.body);
+    assert.isDefined(response.body);
   });
 
   it("should catch the mandatory parameter missing error", async function () {

sdk/core/core-lro/test/public/lro.spec.ts

@@ -2546,7 +2546,7 @@ matrix(
                 (state as any).x = 1;
                 setState = true;
               } else {
-                assert.ok((state as any).x);
+                assert.isDefined((state as any).x);
                 check = true;
               }
             },
@@ -2591,7 +2591,7 @@ matrix(
                 (state as any).x = 1;
                 setState = true;
               } else {
-                assert.ok((state as any).x);
+                assert.isDefined((state as any).x);
                 check = true;
               }
             },

sdk/core/core-rest-pipeline/test/browser/userAgentPlatform.spec.ts

@@ -11,6 +11,6 @@ describe("userAgentPlatform", () => {
     await setPlatformSpecificData(map);
 
     // Switch if we're using a different browser runner
-    assert.ok(map.has("Chromium"));
+    assert.isTrue(map.has("Chromium"));
   });
 });

sdk/core/core-rest-pipeline/test/formDataPolicy.spec.ts

@@ -41,7 +41,7 @@ describe("formDataPolicy", function () {
       });
 
       const parts = (result.request.multipartBody as MultipartRequestBody).parts;
-      assert.ok(parts.length === 1, "expected 1 part");
+      assert.equal(parts.length, 1, "expected 1 part");
       assert.deepEqual(
         parts[0].headers,
         createHttpHeaders({

sdk/core/core-rest-pipeline/test/multipartPolicy.spec.ts

@@ -77,7 +77,7 @@ describe("multipartPolicy", function () {
         },
       });
 
-      assert.ok(request.headers.has("content-type"), "content-type header expected");
+      assert.isTrue(request.headers.has("content-type"), "content-type header expected");
       assert.match(
         request.headers.get("content-type")!,
         /multipart\/mixed; boundary=[0-9a-zA-Z'()+,-./:=?]+/,
@@ -134,7 +134,7 @@ describe("multipartPolicy", function () {
         },
       });
 
-      assert.ok(request.headers.has("content-type"), "content-type header expected");
+      assert.isTrue(request.headers.has("content-type"), "content-type header expected");
       assert.match(
         request.headers.get("content-type")!,
         /multipart\/alternative; boundary=[0-9a-zA-Z'()+,-./:=?]+/,

sdk/core/core-rest-pipeline/test/node/bearerTokenAuthenticationPolicyChallenge.spec.ts

@@ -496,7 +496,7 @@ describe("bearerTokenAuthenticationPolicy with challenge", function () {
       error = e;
     }
 
-    assert.ok(error);
+    assert.isDefined(error);
     assert.equal(error?.message, "Failed sendRequest error");
   });
 });