[storage] Update to use randomUUID (#28026)

mpodwysocki · web-flow · commit d81e15714ab6 · 2023-12-12T09:31:13.000-08:00
### Packages impacted by this PR - @azure/storage-blob - @azure/storage-file-share - @azure-rest/synapse-access-control ### Issues associated with this PR ### Describe the problem that is addressed by this PR Removes UUID package in favor of core-util randomUUID ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
diff --git a/sdk/storage/perf-tests/storage-blob-track-1/package.json b/sdk/storage/perf-tests/storage-blob-track-1/package.json
@@ -8,12 +8,11 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
+    "@azure/core-util": "^1.6.1",
     "@azure/storage-blob": "^10.5.0",
     "@azure/test-utils-perf": "file:../../../test-utils/perf/azure-test-utils-perf-1.0.0.tgz",
     "@types/node": "^18.0.0",
-    "@types/uuid": "^8.0.0",
     "dotenv": "^16.0.0",
-    "uuid": "^8.3.0",
     "tslib": "^2.0.0",
     "rimraf": "^3.0.0",
     "ts-node": "^8.3.0",
diff --git a/sdk/storage/perf-tests/storage-blob-track-1/test/download.spec.ts b/sdk/storage/perf-tests/storage-blob-track-1/test/download.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { Aborter, BlobURL, BlockBlobURL } from "@azure/storage-blob";
 import { PerfOptionDictionary, drainStream } from "@azure/test-utils-perf";
 import { StorageBlobTest } from "./storageTest.spec";
@@ -17,11 +17,11 @@ export class StorageBlobDownloadTest extends StorageBlobTest<StorageBlobDownload
       description: "Size in bytes",
       shortName: "sz",
       longName: "size",
-      defaultValue: 10240
-    }
+      defaultValue: 10240,
+    },
   };
 
-  static blobName = generateUuid();
+  static blobName = randomUUID();
   blockBlobClient: BlockBlobURL;
 
   constructor() {
diff --git a/sdk/storage/perf-tests/storage-blob-track-1/test/listBlobs.spec.ts b/sdk/storage/perf-tests/storage-blob-track-1/test/listBlobs.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { Aborter, BlockBlobURL } from "@azure/storage-blob";
 import { executeParallel, PerfOptionDictionary } from "@azure/test-utils-perf";
 import { StorageBlobTest } from "./storageTest.spec";
@@ -15,15 +15,15 @@ export class StorageBlobListTest extends StorageBlobTest<StorageBlobListTestOpti
       required: true,
       description: "Number of blobs to be listed",
       longName: "count",
-      defaultValue: 10
-    }
+      defaultValue: 10,
+    },
   };
 
   public async globalSetup() {
     await super.globalSetup();
     await executeParallel(
       async (_count: number, _parallelIndex: number) => {
-        const blockBlobClient = BlockBlobURL.fromContainerURL(this.containerClient, generateUuid());
+        const blockBlobClient = BlockBlobURL.fromContainerURL(this.containerClient, randomUUID());
         blockBlobClient.upload(Aborter.none, Buffer.alloc(0), 0);
       },
       this.parsedOptions.count.value!,
diff --git a/sdk/storage/perf-tests/storage-blob-track-1/test/storageTest.spec.ts b/sdk/storage/perf-tests/storage-blob-track-1/test/storageTest.spec.ts
@@ -1,13 +1,13 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import {
   Aborter,
   ContainerURL,
   ServiceURL,
   SharedKeyCredential,
-  StorageURL
+  StorageURL,
 } from "@azure/storage-blob";
 import { PerfTest, getEnvVar } from "@azure/test-utils-perf";
 
@@ -18,7 +18,7 @@ dotenv.config();
 export abstract class StorageBlobTest<TOptions> extends PerfTest<TOptions> {
   blobServiceClient: ServiceURL;
   containerClient: ContainerURL;
-  static containerName = generateUuid();
+  static containerName = randomUUID();
 
   constructor() {
     super();
diff --git a/sdk/storage/perf-tests/storage-blob-track-1/test/upload.spec.ts b/sdk/storage/perf-tests/storage-blob-track-1/test/upload.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { Aborter, BlockBlobURL } from "@azure/storage-blob";
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import { StorageBlobTest } from "./storageTest.spec";
@@ -19,13 +19,13 @@ export class StorageBlobUploadTest extends StorageBlobTest<StorageBlobUploadTest
       description: "Size in bytes",
       shortName: "sz",
       longName: "size",
-      defaultValue: 10240
-    }
+      defaultValue: 10240,
+    },
   };
 
   constructor() {
     super();
-    this.blobName = generateUuid();
+    this.blobName = randomUUID();
     this.blockBlobClient = BlockBlobURL.fromContainerURL(this.containerClient, this.blobName);
     this.buffer = Buffer.alloc(this.parsedOptions.size.value!);
   }
diff --git a/sdk/storage/perf-tests/storage-blob/package.json b/sdk/storage/perf-tests/storage-blob/package.json
@@ -9,14 +9,12 @@
   "license": "ISC",
   "dependencies": {
     "@azure/core-rest-pipeline": "^1.1.0",
-    "@azure/core-util": "^1.3.2",
+    "@azure/core-util": "^1.6.1",
     "@azure/storage-blob": "^12.23.0-beta.1",
     "@azure/test-utils-perf": "^1.0.0",
-    "dotenv": "^16.0.0",
-    "uuid": "^8.3.0"
+    "dotenv": "^16.0.0"
   },
   "devDependencies": {
-    "@types/uuid": "^8.0.0",
     "@types/node": "^18.0.0",
     "@types/node-fetch": "^2.5.0",
     "eslint": "^8.0.0",
diff --git a/sdk/storage/perf-tests/storage-blob/test/utils/utils.ts b/sdk/storage/perf-tests/storage-blob/test/utils/utils.ts
@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 export function getValueInConnString(
   connectionString: string,
   argument:
diff --git a/sdk/storage/perf-tests/storage-file-datalake/package.json b/sdk/storage/perf-tests/storage-file-datalake/package.json
@@ -8,13 +8,12 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
+    "@azure/core-util": "^1.6.1",
     "@azure/storage-file-datalake": "^12.11.0-beta.2",
     "@azure/test-utils-perf": "^1.0.0",
-    "dotenv": "^16.0.0",
-    "uuid": "^8.3.0"
+    "dotenv": "^16.0.0"
   },
   "devDependencies": {
-    "@types/uuid": "^8.0.0",
     "@types/node": "^18.0.0",
     "eslint": "^8.0.0",
     "prettier": "^2.5.1",
diff --git a/sdk/storage/perf-tests/storage-file-datalake/test/append.spec.ts b/sdk/storage/perf-tests/storage-file-datalake/test/append.spec.ts
@@ -4,7 +4,8 @@
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import { StorageDFSTest } from "./storageTest.spec";
 import { DataLakeFileClient } from "@azure/storage-file-datalake";
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
+
 interface StorageDFSAppendTestOptions {
   size: number;
 }
@@ -24,7 +25,7 @@ export class StorageDFSAppendTest extends StorageDFSTest<StorageDFSAppendTestOpt
 
   constructor() {
     super();
-    this.fileClient = this.directoryClient.getFileClient(generateUuid());
+    this.fileClient = this.directoryClient.getFileClient(randomUUID());
     this.buffer = Buffer.alloc(this.parsedOptions.size.value!);
   }
 
diff --git a/sdk/storage/perf-tests/storage-file-datalake/test/read.spec.ts b/sdk/storage/perf-tests/storage-file-datalake/test/read.spec.ts
@@ -4,7 +4,8 @@
 import { drainStream, PerfOptionDictionary } from "@azure/test-utils-perf";
 import { StorageDFSTest } from "./storageTest.spec";
 import { DataLakeFileClient } from "@azure/storage-file-datalake";
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
+
 interface StorageDFSReadTestOptions {
   size: number;
 }
@@ -19,7 +20,7 @@ export class StorageDFSReadTest extends StorageDFSTest<StorageDFSReadTestOptions
       defaultValue: 1024,
     },
   };
-  static fileName = generateUuid();
+  static fileName = randomUUID();
   fileClient: DataLakeFileClient;
 
   constructor() {
diff --git a/sdk/storage/perf-tests/storage-file-datalake/test/storageTest.spec.ts b/sdk/storage/perf-tests/storage-file-datalake/test/storageTest.spec.ts
@@ -11,16 +11,17 @@ import {
 } from "@azure/storage-file-datalake";
 
 // Expects the .env file at the same level as the "test" folder
-import * as dotenv from "dotenv";
-import { v4 as generateUuid } from "uuid";
+import dotenv from "dotenv";
+import { randomUUID } from "@azure/core-util";
+
 dotenv.config();
 
 export abstract class StorageDFSTest<TOptions> extends PerfTest<TOptions> {
   datalakeServiceClient: DataLakeServiceClient;
   fileSystemClient: DataLakeFileSystemClient;
   directoryClient: DataLakeDirectoryClient;
-  static fileSystemName = generateUuid();
-  static directoryName = generateUuid();
+  static fileSystemName = randomUUID();
+  static directoryName = randomUUID();
 
   constructor() {
     super();
diff --git a/sdk/storage/perf-tests/storage-file-datalake/test/upload.spec.ts b/sdk/storage/perf-tests/storage-file-datalake/test/upload.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import { DataLakeFileClient } from "@azure/storage-file-datalake";
 import { StorageDFSTest } from "./storageTest.spec";
@@ -25,7 +25,7 @@ export class StorageDFSUploadTest extends StorageDFSTest<StorageFileShareUploadT
 
   constructor() {
     super();
-    const fileName = generateUuid();
+    const fileName = randomUUID();
     this.fileClient = this.directoryClient.getFileClient(fileName);
     this.buffer = Buffer.alloc(this.parsedOptions.size.value!);
   }
diff --git a/sdk/storage/perf-tests/storage-file-datalake/test/uploadFromFile.spec.ts b/sdk/storage/perf-tests/storage-file-datalake/test/uploadFromFile.spec.ts
@@ -4,6 +4,7 @@
 import { StorageDFSUploadTest } from "./upload.spec";
 import fs from "fs";
 import util from "util";
+
 const writeFile = util.promisify(fs.writeFile);
 const fileExists = util.promisify(fs.exists);
 const mkdir = util.promisify(fs.mkdir);
diff --git a/sdk/storage/perf-tests/storage-file-share-track-1/package.json b/sdk/storage/perf-tests/storage-file-share-track-1/package.json
@@ -8,12 +8,11 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
+    "@azure/core-util": "^1.6.1",
     "@azure/storage-file": "^10.3.0",
     "@azure/test-utils-perf": "file:../../../test-utils/perf/azure-test-utils-perf-1.0.0.tgz",
-    "@types/uuid": "^8.0.0",
     "@types/node": "^18.0.0",
     "dotenv": "^16.0.0",
-    "uuid": "^8.3.0",
     "rimraf": "3.0.2",
     "tslib": "^2.0.0",
     "ts-node": "^8.3.0",
diff --git a/sdk/storage/perf-tests/storage-file-share/package.json b/sdk/storage/perf-tests/storage-file-share/package.json
@@ -8,13 +8,12 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
+    "@azure/core-util": "^1.6.1",
     "@azure/storage-file-share": "^12.11.1",
     "@azure/test-utils-perf": "^1.0.0",
-    "dotenv": "^16.0.0",
-    "uuid": "^8.3.0"
+    "dotenv": "^16.0.0"
   },
   "devDependencies": {
-    "@types/uuid": "^8.0.0",
     "@types/node": "^18.0.0",
     "eslint": "^8.0.0",
     "prettier": "^2.5.1",
diff --git a/sdk/storage/perf-tests/storage-file-share/test/download.spec.ts b/sdk/storage/perf-tests/storage-file-share/test/download.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { PerfOptionDictionary, drainStream } from "@azure/test-utils-perf";
 import { ShareFileClient } from "@azure/storage-file-share";
 
@@ -20,7 +20,7 @@ export class StorageFileShareDownloadTest extends StorageFileShareTest<StorageFi
       defaultValue: 1024,
     },
   };
-  static fileName = generateUuid();
+  static fileName = randomUUID();
   fileClient: ShareFileClient;
 
   constructor() {
diff --git a/sdk/storage/perf-tests/storage-file-share/test/downloadToFile.spec.ts b/sdk/storage/perf-tests/storage-file-share/test/downloadToFile.spec.ts
@@ -3,14 +3,15 @@
 
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import { ShareFileClient } from "@azure/storage-file-share";
+import { StorageFileShareTest } from "./storageTest.spec";
+import { randomUUID } from "@azure/core-util";
 import fs from "fs";
 import util from "util";
+
 const fileExists = util.promisify(fs.exists);
 const mkdir = util.promisify(fs.mkdir);
 const deleteFile = util.promisify(fs.unlink);
 
-import { StorageFileShareTest } from "./storageTest.spec";
-import { v4 as generateUuid } from "uuid";
 interface StorageFileShareDownloadTestOptions {
   size: number;
 }
@@ -27,7 +28,7 @@ export class StorageFileShareDownloadToFileTest extends StorageFileShareTest<Sto
       defaultValue: 1024,
     },
   };
-  static fileName = generateUuid();
+  static fileName = randomUUID();
   fileClient: ShareFileClient;
   localFileName: string;
 
@@ -36,7 +37,7 @@ export class StorageFileShareDownloadToFileTest extends StorageFileShareTest<Sto
     this.fileClient = this.directoryClient.getFileClient(
       StorageFileShareDownloadToFileTest.fileName
     );
-    this.localFileName = generateUuid();
+    this.localFileName = randomUUID();
   }
 
   public async globalSetup() {
diff --git a/sdk/storage/perf-tests/storage-file-share/test/storageTest.spec.ts b/sdk/storage/perf-tests/storage-file-share/test/storageTest.spec.ts
@@ -2,20 +2,20 @@
 // Licensed under the MIT license.
 
 import { PerfTest, getEnvVar } from "@azure/test-utils-perf";
-
 import { ShareClient, ShareDirectoryClient, ShareServiceClient } from "@azure/storage-file-share";
 
 // Expects the .env file at the same level as the "test" folder
-import * as dotenv from "dotenv";
-import { v4 as generateUuid } from "uuid";
+import dotenv from "dotenv";
+import { randomUUID } from "@azure/core-util";
+
 dotenv.config();
 
 export abstract class StorageFileShareTest<TOptions> extends PerfTest<TOptions> {
   shareServiceClient: ShareServiceClient;
   shareClient: ShareClient;
   directoryClient: ShareDirectoryClient;
-  static shareName = generateUuid();
-  static dirName = generateUuid();
+  static shareName = randomUUID();
+  static dirName = randomUUID();
 
   constructor() {
     super();
diff --git a/sdk/storage/perf-tests/storage-file-share/test/upload.spec.ts b/sdk/storage/perf-tests/storage-file-share/test/upload.spec.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import { ShareFileClient } from "@azure/storage-file-share";
 import { StorageFileShareTest } from "./storageTest.spec";
@@ -25,7 +25,7 @@ export class StorageFileShareUploadTest extends StorageFileShareTest<StorageFile
 
   constructor() {
     super();
-    const fileName = generateUuid();
+    const fileName = randomUUID();
     this.fileClient = this.directoryClient.getFileClient(fileName);
     this.buffer = Buffer.alloc(this.parsedOptions.size.value!);
   }
diff --git a/sdk/storage/perf-tests/storage-file-share/test/uploadFromFile.spec.ts b/sdk/storage/perf-tests/storage-file-share/test/uploadFromFile.spec.ts
@@ -1,11 +1,12 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { v4 as generateUuid } from "uuid";
+import { randomUUID } from "@azure/core-util";
 import { PerfOptionDictionary } from "@azure/test-utils-perf";
 import fs from "fs";
 import util from "util";
 import { ShareFileClient } from "@azure/storage-file-share";
+
 const writeFile = util.promisify(fs.writeFile);
 const fileExists = util.promisify(fs.exists);
 const mkdir = util.promisify(fs.mkdir);
@@ -33,7 +34,7 @@ export class StorageFileShareUploadFromFileTest extends StorageFileShareTest<Sto
 
   constructor() {
     super();
-    const fileName = generateUuid();
+    const fileName = randomUUID();
     this.fileClient = this.directoryClient.getFileClient(fileName);
   }
 
diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json
diff --git a/sdk/storage/storage-blob/src/BlobBatch.ts b/sdk/storage/storage-blob/src/BlobBatch.ts
diff --git a/sdk/storage/storage-blob/src/BlobLeaseClient.ts b/sdk/storage/storage-blob/src/BlobLeaseClient.ts
diff --git a/sdk/storage/storage-blob/src/Clients.ts b/sdk/storage/storage-blob/src/Clients.ts
diff --git a/sdk/storage/storage-blob/test/blobclient.spec.ts b/sdk/storage/storage-blob/test/blobclient.spec.ts
diff --git a/sdk/storage/storage-file-share/package.json b/sdk/storage/storage-file-share/package.json
diff --git a/sdk/storage/storage-file-share/src/Clients.ts b/sdk/storage/storage-file-share/src/Clients.ts
diff --git a/sdk/storage/storage-queue/package.json b/sdk/storage/storage-queue/package.json
diff --git a/sdk/synapse/synapse-access-control-rest/package.json b/sdk/synapse/synapse-access-control-rest/package.json
diff --git a/sdk/synapse/synapse-access-control-rest/samples-dev/createRoleAssignment.ts b/sdk/synapse/synapse-access-control-rest/samples-dev/createRoleAssignment.ts
