-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.Microsoft Playwright Testing
Description
Dedupe getPackageVersion implementation.
The code in https://github.com/azure/azure-sdk-for-js/blob/main/sdk/loadtesting/playwright/src/utils/getPackageVersion.ts and https://github.com/azure/azure-sdk-for-js/blob/main/sdk/loadtesting/playwright/src/utils/getPackageVersion-cjs.cts have almost identical implementations, except that the -cjs.cts uses CommonJS and the .ts uses ESM.
In order to reduce duplication:
- Move
getPackageVersion
back into https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/loadtesting/playwright/src/utils/utils.ts - Fix the imports in https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/loadtesting/playwright/src/utils/utils.ts after (1) by importing getPackageVersionFromFolder from "./getPackageVersion.js" - notice that
.js
is used either way
Copilot
Metadata
Metadata
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.Microsoft Playwright Testing