Skip to content

[mgmt] Mongocluster with modular #30102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 5, 2024
Merged

[mgmt] Mongocluster with modular #30102

merged 27 commits into from
Jul 5, 2024

Conversation

@kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Jun 19, 2024

No description provided.

@github-actions github-actions bot added Mgmt This issue is related to a management-plane library. test-utils Label for the issues related to the @azure/test-utils package labels Jun 19, 2024
MaryGao
MaryGao reviewed Jun 26, 2024
View reviewed changes
qiaozha
qiaozha reviewed Jun 28, 2024
View reviewed changes
qiaozha
qiaozha reviewed Jul 1, 2024
View reviewed changes
@kazrael2119 kazrael2119 mentioned this pull request Jul 1, 2024
Closed
MaryGao
MaryGao reviewed Jul 1, 2024
View reviewed changes
MaryGao
MaryGao reviewed Jul 1, 2024
View reviewed changes
@kazrael2119 kazrael2119 mentioned this pull request Jul 1, 2024
Closed
MaryGao
MaryGao reviewed Jul 1, 2024
View reviewed changes
@kazrael2119
Copy link
Member Author

kazrael2119 commented Jul 2, 2024

extra config before generate code:
add

@@clientName(Microsoft.DocumentDB,
  "MongoClusterManagementClient",
  "javascript"
);

in client .tsp

add

"@azure-tools/typespec-ts":
    azureSdkForJs: true
    isModularLibrary: true
    generateMetadata: true
    hierarchyClient: false
    experimentalExtensibleEnums: true
    package-name: "@azure/arm-mongocluster"
    flavor: "azure"
    packageDetails:
      name: "@azure/arm-mongocluster"
      description: "DocumentDB MongoCluster Service"

in tspconfig.yaml

qiaozha
qiaozha reviewed Jul 2, 2024
View reviewed changes
@kazrael2119 kazrael2119 mentioned this pull request Jul 3, 2024
Closed
@qiaozha
Copy link
Member

qiaozha commented Jul 5, 2024

/azp run js - mongocluster - mgmt - ci

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@kazrael2119 kazrael2119 marked this pull request as ready for review July 5, 2024 02:54
@qiaozha qiaozha merged commit a9397f7 into Azure:main Jul 5, 2024
@kazrael2119 kazrael2119 deleted the mongocluster-with-modular branch July 5, 2024 07:58
@qiaozha qiaozha mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaryGao MaryGao MaryGao left review comments

@joheredi joheredi joheredi left review comments

@qiaozha qiaozha qiaozha approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@ckairen ckairen Awaiting requested review from ckairen

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@bterlson bterlson Awaiting requested review from bterlson

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki

@maorleger maorleger Awaiting requested review from maorleger

+1 more reviewer

@wanlwanl wanlwanl wanlwanl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Mgmt This issue is related to a management-plane library. test-utils Label for the issues related to the @azure/test-utils package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kazrael2119 @qiaozha @MaryGao @joheredi @wanlwanl