bump dependencies for azure mgmt generator (#51938)

* first commit to refactor the existing visitor

* replace the diagnostic scope

* clean up

* Update eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/ResourceHelpers.cs

Co-authored-by: Copilot <[email protected]>

* bump version

* fix the issues in getnextresponse

* fix the implicit operator replacement

* format the code

* pin the version of nuget packages to avoid future issues

* fix test compilation issue

* regen

* cleanup

* cleanup

* cleanup

* minor

* regen

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Wei Hu <[email protected]>

Author: 3 people

eng/Packages.Data.props

@@ -458,6 +458,6 @@
   <PropertyGroup>
     <TestProxyVersion>1.0.0-dev.20250805.1</TestProxyVersion>
     <UnbrandedGeneratorVersion>1.0.0-alpha.20250813.2</UnbrandedGeneratorVersion>
-    <AzureGeneratorVersion>1.0.0-alpha.20250729.4</AzureGeneratorVersion>
+    <AzureGeneratorVersion>1.0.0-alpha.20250812.2</AzureGeneratorVersion>
   </PropertyGroup>
 </Project>

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Azure.Generator.Management.csproj

@@ -12,12 +12,6 @@
 		<PackageReference Include="Humanizer.Core" />
 	</ItemGroup>
 
-	<!-- temporarily. remove once Azure.Generator version update is done -->
-	<ItemGroup>
-		<PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" VersionOverride="1.0.0-alpha.20250731.2" />
-		<PackageReference Update="Microsoft.TypeSpec.Generator.Input" VersionOverride="1.0.0-alpha.20250731.2" />
-	</ItemGroup>
-
 	<Target Name="CheckEmitterBuild" BeforeTargets="Build">
 		<!-- Check if the folder does not exist -->
 		<Error Condition="!Exists('..\..\..\node_modules\@typespec\http-client-csharp')" Text="Emitter has not been built please run `npm ci` followed by `npm run build` from ./eng/packages/http-client-csharp folder." />

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/PaginationVisitor.cs

@@ -6,6 +6,7 @@
 using Microsoft.TypeSpec.Generator.Providers;
 using Microsoft.TypeSpec.Generator.Statements;
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using static Microsoft.TypeSpec.Generator.Snippets.Snippet;
 
@@ -37,25 +38,54 @@ internal class PaginationVisitor : ScmLibraryVisitor
     }
 
     private static bool IsAsPagesMethod(MethodProvider method) => method.Signature.Name.Equals("AsPages");
-    private static bool IsGetNextResponseMethod(MethodProvider method) => method.Signature.Name.Equals("GetNextResponse");
+    private static bool IsGetNextResponseMethod(MethodProvider method)
+        => method.Signature.Name.Equals("GetNextResponseAsync") || method.Signature.Name.Equals("GetNextResponse");
 
     private void DoVisitAsPagesMethodStatements(MethodBodyStatements statements, MethodProvider method)
     {
-        var doWhileStatement = statements.OfType<DoWhileStatement>().FirstOrDefault();
-        if (doWhileStatement is not null)
+        var whileStatement = statements.OfType<WhileStatement>().FirstOrDefault();
+        if (whileStatement is not null)
         {
             // we manually go over the body statements because currently the framework does not do this.
             // TODO -- we do not have to do this once https://github.com/microsoft/typespec/issues/8177 is fixed.
-            foreach (var statement in doWhileStatement.Body)
+            foreach (var statement in whileStatement.Body)
             {
-                if (statement is ExpressionStatement { Expression: AssignmentExpression assignment } expressionStatement)
+                if (statement is YieldReturnStatement
+                    {
+                        Value: InvokeMethodExpression
+                        {
+                            MethodName: "FromValues",
+                            Arguments: [CastExpression castExpression, ..]
+                        } invokeMethodExpression
+                    } &&
+                    castExpression.Inner is MemberExpression
+                    {
+                        Inner: CastExpression innerCastExpression,
+                        MemberName: var memberName
+                    } &&
+                    IsResponseToModelCastExpression(innerCastExpression))
+                {
+                    // convert the implicit cast expression to a method call
+                    var updatedExpression = ConvertCastToMethodCall(innerCastExpression)
+                                            .Property(memberName) // wrap back by a MemberExpression
+                                            .CastTo(castExpression.Type); // wrap back by the outer CastExpression
+                    // use the above updated expression as the first argument of this method call inside the yield return
+                    IReadOnlyList<ValueExpression> newArguments = [updatedExpression, .. invokeMethodExpression.Arguments.Skip(1)];
+                    invokeMethodExpression.Update(arguments: newArguments);
+                }
+                else if (statement is ExpressionStatement
                 {
-                    var updatedExpression = DoVisitAssignmentExpressionForAsPagesMethod(assignment, method);
-                    if (updatedExpression is not null)
+                    Expression: AssignmentExpression
                     {
-                        // update the expression in the statement.
-                        expressionStatement.Update(updatedExpression);
+                        Variable: var variable,
+                        Value: MemberExpression { Inner: CastExpression castExpression1, MemberName: var memberName1 }
                     }
+                } expressionStatement)
+                {
+                    var updatedExpression = variable.Assign(
+                                            ConvertCastToMethodCall(castExpression1)
+                                            .Property(memberName1)); // wrap back by a MemberExpression
+                    expressionStatement.Update(updatedExpression);
                 }
             }
         }
@@ -89,23 +119,17 @@ private void DoVisitAsPagesMethodStatements(MethodBodyStatements statements, Met
     {
         if (expression.Value is CastExpression castExpression && IsResponseToModelCastExpression(castExpression))
         {
-            var value = Static(castExpression.Type!).Invoke(SerializationVisitor.FromResponseMethodName, [castExpression.Inner!]);
+            var value = ConvertCastToMethodCall(castExpression);
             var variable = expression.Variable;
             return variable.Assign(value);
         }
         // do nothing if nothing is changed.
         return null;
+    }
 
-        static bool IsResponseToModelCastExpression(CastExpression castExpression)
-        {
-            if (castExpression.Inner is VariableExpression variableExpression &&
-                variableExpression.Type is { IsFrameworkType: true, FrameworkType: { } frameworkType } &&
-                frameworkType == typeof(Response))
-            {
-                return true;
-            }
-            return false;
-        }
+    private static ValueExpression ConvertCastToMethodCall(CastExpression castExpression)
+    {
+        return Static(castExpression.Type!).Invoke(SerializationVisitor.FromResponseMethodName, [castExpression.Inner!]);
     }
 
     private ValueExpression? DoVisitAssignmentExpressionForGetNextResponseMethod(AssignmentExpression expression, MethodProvider method)
@@ -131,4 +155,9 @@ static bool IsResponseToModelCastExpression(CastExpression castExpression)
         // do nothing if nothing is changed.
         return null;
     }
+
+    private static bool IsResponseToModelCastExpression(CastExpression castExpression)
+        => castExpression.Inner is VariableExpression variableExpression
+            && variableExpression.Type is { IsFrameworkType: true, FrameworkType: { } frameworkType }
+            && frameworkType == typeof(Response);
 }

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Azure.Generator.Mgmt.Tests.csproj

@@ -32,10 +32,4 @@
     <ProjectReference Include="Common\Azure.Generator.Management.Tests.Common.csproj" />
   </ItemGroup>
 
-	<!-- temporarily. remove once Azure.Generator version update is done -->
-	<ItemGroup>
-		<PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" VersionOverride="1.0.0-alpha.20250731.2" />
-		<PackageReference Update="Microsoft.TypeSpec.Generator.Input" VersionOverride="1.0.0-alpha.20250731.2" />
-	</ItemGroup>
-
 </Project>

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Common/Azure.Generator.Management.Tests.Common.csproj

@@ -18,10 +18,4 @@
 	  <ProjectReference Include="..\..\src\Azure.Generator.Management.csproj" />
 	</ItemGroup>
 
-	<!-- temporarily. remove once Azure.Generator version update is done -->
-	<ItemGroup>
-		<PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" VersionOverride="1.0.0-alpha.20250731.2" />
-		<PackageReference Update="Microsoft.TypeSpec.Generator.Input" VersionOverride="1.0.0-alpha.20250731.2" />
-	</ItemGroup>
-
 </Project>

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Common/InputFactory.cs

@@ -221,6 +221,7 @@ public static InputModelProperty Property(
                 access: null,
                 isDiscriminator,
                 serializedName ?? wireName ?? name.ToVariableName(),
+                false,
                 new(json: new(wireName ?? name)));
         }