Fix samples and start fixing the Memory stores, add couple of tests (#53943)

* Fix samples and start fixing the Memory stores, add couple of tests

* update headers to CRUD samples

* Fix

---------

Co-authored-by: Travis Wilson <[email protected]>

Author: nick863

sdk/ai/Azure.AI.Agents/samples/Sample2_Agents_CRUD.md

@@ -1,4 +1,4 @@
-# Sample for Create, Read, Update and Delete (CRUD) agent in Azure.AI.Agents.V2.
+# Sample for Agent Administration (creation, retrieval, update, deletion) in Azure.AI.Projects
 
 In this example we will demonstrate creation and basic use of an agent step by step.
 

sdk/ai/Azure.AI.Projects.OpenAI/README.md

@@ -106,14 +106,14 @@ The Azure.AI.Projects.OpenAI framework organized in a way that for each call, re
 
 Synchronous call:
 ```C# Snippet:Sample_CreateResponse_Sync
-OpenAIResponseClient responseClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 OpenAIResponse response = responseClient.CreateResponse("What is the size of France in square miles?");
 ```
 
 Asynchronous call:
 
 ```C# Snippet:Sample_CreateResponse_Async
-OpenAIResponseClient responseClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 OpenAIResponse response = await responseClient.CreateResponseAsync("What is the size of France in square miles?");
 ```
 
@@ -156,19 +156,13 @@ The code above will result in creation of `AgentVersion` object, which is the da
 OpenAI API allows you to get the response without creating an agent by using the response API. In this scenario we first create the response object.
 
 ```C# Snippet:Sample_CreateResponse_Async
-OpenAIResponseClient responseClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 OpenAIResponse response = await responseClient.CreateResponseAsync("What is the size of France in square miles?");
 ```
 
 After the response was created we need to wait for it to complete.
 
 ```C# Snippet:Sample_WriteOutput_ResponseBasic_Async
-while (response.Status != ResponseStatus.Incomplete || response.Status != ResponseStatus.Failed || response.Status != ResponseStatus.Completed)
-{
-    await Task.Delay(TimeSpan.FromMilliseconds(500));
-    response = await responseClient.GetResponseAsync(responseId: response.Id);
-}
-
 Console.WriteLine(response.GetOutputText());
 ```
 
@@ -363,17 +357,13 @@ AgentVersion agentVersion = await projectClient.Agents.CreateAgentVersionAsync(
 Now we can ask the agent a question, which requires running python code in the container.
 
 ```C# Snippet:Sample_CreateResponse_CodeInterpreter_Async
-OpenAIResponseClient responseClient = projectClient.OpenAI.GetOpenAIResponseClient(modelDeploymentName);
-ResponseCreationOptions responseOptions = new();
-responseOptions.Agent = agentVersion;
+AgentReference agentReference = new(name: agentVersion.Name, version: agentVersion.Version);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForAgent(agentReference);
 
-ResponseItem request = ResponseItem.CreateUserMessageItem("I need to solve the equation sin(x) + x^2 = 42");
-OpenAIResponse response = await responseClient.CreateResponseAsync(
-    [request],
-    responseOptions);
+OpenAIResponse response = await responseClient.CreateResponseAsync("I need to solve the equation sin(x) + x^2 = 42");
 ```
 
-### Computer tool
+### Computer use
 
 `ComputerTool` allows Agents to assist customer in computer related tasks. Its constructor is provided with description of an operation system and screen resolution.
 
@@ -415,7 +405,7 @@ int limitIteration = 10;
 OpenAIResponse response;
 do
 {
-    response = await CreateAndWaitForResponseAsync(
+    response = await CreateResponseAsync(
         responseClient,
         inputItems,
         responseOptions
@@ -643,41 +633,32 @@ AgentVersion agentVersion = await projectClient.Agents.CreateAgentVersionAsync(
     options: new(agentDefinition));
 ```
 
-To supply functions outputs, we will need to wait for response multiple times. We will define method `CreateAndWaitForResponseAsync` for brevity.
+To supply functions outputs, we will need to obtain responses multiple times. We will define method `CreateAndWaitForResponseAsync` for brevity.
 
-```C# Snippet:Sample_WaitForResponse_Function_Async
-public static async Task<OpenAIResponse> CreateAndWaitForResponseAsync(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items, ResponseCreationOptions options)
+```C# Snippet:Sample_CheckResponse_Function_Async
+public static async Task<OpenAIResponse> CreateAndCheckReponseAsync(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items)
 {
     OpenAIResponse response = await responseClient.CreateResponseAsync(
-        inputItems: items,
-        options: options);
-    while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed)
-    {
-        await Task.Delay(TimeSpan.FromMilliseconds(500));
-        response = await responseClient.GetResponseAsync(responseId: response.Id);
-    }
+        inputItems: items);
     Assert.That(response.Status, Is.EqualTo(ResponseStatus.Completed));
     return response;
 }
 ```
 
-Wait for the response; if the local function call is required, the response item will be of `FunctionCallResponseItem` type and will contain the function name needed by the Agent. In this case we will use our helper method `GetResolvedToolOutput` to get the `FunctionCallOutputResponseItem` with function call result. To provide the right answer, we need to supply all the response items to `CreateResponse` or `CreateResponseAsync` call. At the end we will print out the function response.
+If the local function call is required, the response item will be of `FunctionCallResponseItem` type and will contain the function name needed by the Agent. In this case we will use our helper method `GetResolvedToolOutput` to get the `FunctionCallOutputResponseItem` with function call result. To provide the right answer, we need to supply all the response items to `CreateResponse` or `CreateResponseAsync` call. At the end we will print out the function response.
 
 ```C# Snippet:Sample_CreateResponse_Function_Async
-OpenAIResponseClient responseClient = projectClient.OpenAI.GetOpenAIResponseClient(modelDeploymentName);
-ResponseCreationOptions responseOptions = new();
-responseOptions.Agent = agentVersion;
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForAgent(agentVersion.Name);
 
 ResponseItem request = ResponseItem.CreateUserMessageItem("What's the weather like in my favorite city?");
 List<ResponseItem> inputItems = [request];
 bool funcionCalled = false;
 OpenAIResponse response;
 do
 {
-    response = await CreateAndWaitForResponseAsync(
+    response = await CreateAndCheckReponseAsync(
         responseClient,
-        inputItems,
-        responseOptions);
+        inputItems);
     funcionCalled = false;
     foreach (ResponseItem responseItem in response.OutputItems)
     {

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample10_ComputerUse.md

@@ -137,37 +137,27 @@ private static string ProcessComputerUseCall(ComputerCallResponseItem item, stri
 }
 ```
 
-5. For brevity create the methods to wait for response to be returned.
+5. For brevity create the methods to get the response.
 
 Synchronous sample:
-```C# Snippet:Sample_WaitForResponse_ComputerUse_Sync
-public static OpenAIResponse CreateAndWaitForResponse(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items, ResponseCreationOptions options)
+```C# Snippet:Sample_CreateNextResponse_ComputerUse_Sync
+public static OpenAIResponse CreateResponse(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items, ResponseCreationOptions options)
 {
     OpenAIResponse response = responseClient.CreateResponse(
         inputItems: items,
         options: options);
-    while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed)
-    {
-        Thread.Sleep(TimeSpan.FromMilliseconds(500));
-        response = responseClient.GetResponse(responseId: response.Id);
-    }
     Assert.That(response.Status, Is.EqualTo(ResponseStatus.Completed));
     return response;
 }
 ```
 
 Asynchronous sample:
-```C# Snippet:Sample_WaitForResponse_ComputerUse_Async
-public static async Task<OpenAIResponse> CreateAndWaitForResponseAsync(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items, ResponseCreationOptions options)
+```C# Snippet:Sample_CreateNextResponse_ComputerUse_Async
+public static async Task<OpenAIResponse> CreateResponseAsync(OpenAIResponseClient responseClient, IEnumerable<ResponseItem> items, ResponseCreationOptions options)
 {
     OpenAIResponse response = await responseClient.CreateResponseAsync(
         inputItems: items,
         options: options);
-    while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed)
-    {
-        await Task.Delay(TimeSpan.FromMilliseconds(500));
-        response = await responseClient.GetResponseAsync(responseId: response.Id);
-    }
     Assert.That(response.Status, Is.EqualTo(ResponseStatus.Completed));
     return response;
 }
@@ -193,7 +183,7 @@ int limitIteration = 10;
 OpenAIResponse response;
 do
 {
-    response = CreateAndWaitForResponse(
+    response = CreateResponse(
         responseClient,
         inputItems,
         responseOptions);
@@ -233,7 +223,7 @@ int limitIteration = 10;
 OpenAIResponse response;
 do
 {
-    response = await CreateAndWaitForResponseAsync(
+    response = await CreateResponseAsync(
         responseClient,
         inputItems,
         responseOptions

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample11_FileSearch_Streaming.md

@@ -82,7 +82,7 @@ AgentVersion agentVersion = await projectClient.Agents.CreateAgentVersionAsync(
 );
 ```
 
-3. In this example we will ask a question to the file contents.
+3. Create the conversation to store respones.
 
 Synchronous sample:
 ```C# Snippet:Sample_CreateResponse_FileSearch_Streaming_Sync
@@ -92,8 +92,6 @@ ResponseCreationOptions responseOptions = new()
     Agent = agentVersion,
     AgentConversationId = conversation.Id,
 };
-
-ResponseItem request = ResponseItem.CreateUserMessageItem("Can you give me the documented codes for 'banana' and 'orange'?");
 ```
 
 Asynchronous sample:
@@ -104,8 +102,6 @@ ResponseCreationOptions responseOptions = new()
     Agent = agentVersion,
     AgentConversationId = conversation.Id,
 };
-
-ResponseItem request = ResponseItem.CreateUserMessageItem("Can you give me the documented codes for 'banana' and 'orange'?");
 ```
 
 4. To format streaming response output we will create a helper method `ParseResponse`. If the stream ends up in error state, it will throw an error. 
@@ -154,15 +150,15 @@ private static void ParseResponse(StreamingResponseUpdate streamResponse)
 
 Synchronous sample:
 ```C# Snippet:Sample_StreamingResponse_FileSearch_Streaming_Sync
-foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreaming([request], responseOptions))
+foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreaming("Can you give me the documented codes for 'banana' and 'orange'?", responseOptions))
 {
     ParseResponse(streamResponse);
 }
 ```
 
 Asynchronous sample:
 ```C# Snippet:Sample_StreamingResponse_FileSearch_Streaming_Async
-await foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreamingAsync([request], responseOptions))
+await foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreamingAsync("Can you give me the documented codes for 'banana' and 'orange'?", responseOptions))
 {
     ParseResponse(streamResponse);
 }
@@ -173,8 +169,7 @@ await foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Re
 Synchronous sample:
 ```C# Snippet:Sample_FollowUp_FileSearch_Streaming_Sync
 Console.WriteLine("Demonstrating follow-up query with streaming...");
-request = ResponseItem.CreateUserMessageItem("What was my previous question about?");
-foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreaming([request], responseOptions))
+foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreaming("What was my previous question about?", responseOptions))
 {
     ParseResponse(streamResponse);
 }
@@ -183,8 +178,7 @@ foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Response
 Asynchronous sample:
 ```C# Snippet:Sample_FollowUp_FileSearch_Streaming_Async
 Console.WriteLine("Demonstrating follow-up query with streaming...");
-request = ResponseItem.CreateUserMessageItem("What was my previous question about?");
-await foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreamingAsync([request], responseOptions))
+await foreach (StreamingResponseUpdate streamResponse in projectClient.OpenAI.Responses.CreateResponseStreamingAsync("What was my previous question about?", responseOptions))
 {
     ParseResponse(streamResponse);
 }

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample12_ResponseStreaming.md

@@ -7,15 +7,14 @@ In this example we will demonstrate how to get a response in streaming scenarios
 ```C# Snippet:Sample_CreateAgentClient_ResponseStreaming
 var projectEndpoint = System.Environment.GetEnvironmentVariable("PROJECT_ENDPOINT");
 var modelDeploymentName = System.Environment.GetEnvironmentVariable("MODEL_DEPLOYMENT_NAME");
-
-ProjectOpenAIClient client = new(projectEndpoint: new Uri(projectEndpoint), tokenProvider: new DefaultAzureCredential());
+AIProjectClient projectClient = new(endpoint: new Uri(projectEndpoint), tokenProvider: new DefaultAzureCredential());
 ```
 
 2. Use the client to create a `ProjectOpenAIResponseClient`, which will be used to create stream.
 
 Synchronous sample:
 ```C# Snippet:Sample_CreateResponseStreaming
-ProjectResponsesClient responsesClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responsesClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 ```
 
 3. Stream the results; raise the error if the request was not successful.

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample1_Agent_Versions.md

@@ -92,26 +92,15 @@ ResponseCreationOptions responseOptions = new()
 OpenAIResponse response = await responseClient.CreateResponseAsync("Hello, tell me a joke.");
 ```
 
-6. Wait for the agent to respond and print out the output; raise the error if the request was not successful.
+6. Print the output; raise the error if the request was not successful.
 
 Synchronous sample:
 ```C# Snippet:Sample_WriteOutput_Sync
-while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed)
-{
-    Thread.Sleep(TimeSpan.FromMilliseconds(500));
-    response = responseClient.GetResponse(responseId: response.Id);
-}
-
 Console.WriteLine(response.GetOutputText());
 ```
 
 Asynchronous sample:
 ```C# Snippet:Sample_WriteOutput_Async
-while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed){
-    await Task.Delay(TimeSpan.FromMilliseconds(500));
-    response = await responseClient.GetResponseAsync(responseId:  response.Id);
-}
-
 Console.WriteLine(response.GetOutputText());
 ```
 

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample2_Image_Generation.md

@@ -97,26 +97,7 @@ ProjectResponsesClient responseClient = openAIClient.GetProjectResponsesClientFo
 OpenAIResponse response = await responseClient.CreateResponseAsync("Generate parody of Newton with apple.");
 ```
 
-5. Waiting for response.
-
-Synchronous sample:
-```C# Snippet:Sample_WaitForRun_ImageGeneration_Sync
-while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed)
-{
-    Thread.Sleep(TimeSpan.FromMilliseconds(500));
-    response = responseClient.GetResponse(responseId: response.Id);
-}
-```
-
-Asynchronous sample:
-```C# Snippet:Sample_WaitForRun_ImageGeneration_Async
-while (response.Status != ResponseStatus.Incomplete && response.Status != ResponseStatus.Failed && response.Status != ResponseStatus.Completed){
-    await Task.Delay(TimeSpan.FromMilliseconds(500));
-    response = await responseClient.GetResponseAsync(responseId:  response.Id);
-}
-```
-
-6. Parse the `OpenAIResponse` object and save the generated image.
+5. Parse the `OpenAIResponse` object and save the generated image.
 
 ```C# Snippet:Sample_SaveImage_ImageGeneration
 foreach (ResponseItem item in response.OutputItems)
@@ -129,7 +110,7 @@ foreach (ResponseItem item in response.OutputItems)
 }
 ```
 
-7. Clean up resources by deleting the Agent.
+6. Clean up resources by deleting the Agent.
 
 Synchronous sample:
 ```C# Snippet:Sample_Cleanup_ImageGeneration_Sync

sdk/ai/Azure.AI.Projects.OpenAI/samples/Sample4_ResponseBasic.md

@@ -7,43 +7,31 @@ In this example we will demonstrate how to get a response without an Agent.
 ```C# Snippet:Sample_CreateAgentClient_ResponseBasic
 var projectEndpoint = System.Environment.GetEnvironmentVariable("PROJECT_ENDPOINT");
 var modelDeploymentName = System.Environment.GetEnvironmentVariable("MODEL_DEPLOYMENT_NAME");
-ProjectOpenAIClient client = GetTestProjectOpenAIClient();
+AIProjectClient projectClient = new(endpoint: new Uri(projectEndpoint), tokenProvider: new DefaultAzureCredential());
 ```
 
 2. Use the client to create a `Responses`, which will be used to create `OpenAIResponse` object.
 
 Synchronous sample:
 ```C# Snippet:Sample_CreateResponse_Sync
-OpenAIResponseClient responseClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 OpenAIResponse response = responseClient.CreateResponse("What is the size of France in square miles?");
 ```
 
 Asynchronous sample:
 ```C# Snippet:Sample_CreateResponse_Async
-OpenAIResponseClient responseClient = client.GetProjectResponsesClientForModel(modelDeploymentName);
+ProjectResponsesClient responseClient = projectClient.OpenAI.GetProjectResponsesClientForModel(modelDeploymentName);
 OpenAIResponse response = await responseClient.CreateResponseAsync("What is the size of France in square miles?");
 ```
 
-3. Wait for request to complete; raise the error if the request was not successful.
+3. Write the response output, raise the error if the request was not successful.
 
 Synchronous sample:
 ```C# Snippet:Sample_WriteOutput_ResponseBasic_Sync
-while (response.Status != ResponseStatus.Incomplete || response.Status != ResponseStatus.Failed || response.Status != ResponseStatus.Completed)
-{
-    Thread.Sleep(TimeSpan.FromMilliseconds(500));
-    response = responseClient.GetResponse(responseId: response.Id);
-}
-
 Console.WriteLine(response.GetOutputText());
 ```
 
 Asynchronous sample:
 ```C# Snippet:Sample_WriteOutput_ResponseBasic_Async
-while (response.Status != ResponseStatus.Incomplete || response.Status != ResponseStatus.Failed || response.Status != ResponseStatus.Completed)
-{
-    await Task.Delay(TimeSpan.FromMilliseconds(500));
-    response = await responseClient.GetResponseAsync(responseId: response.Id);
-}
-
 Console.WriteLine(response.GetOutputText());
 ```