Skip to content

Commit a004ad8

Browse files
feat: add ClientRequestId requestapi impl (#53661)
1 parent c04c8cf commit a004ad8

File tree

7 files changed

+20
-17
lines changed

7 files changed

+20
-17
lines changed

eng/Packages.Data.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@
473473

474474
<PropertyGroup>
475475
<TestProxyVersion>1.0.0-dev.20250930.1</TestProxyVersion>
476-
<UnbrandedGeneratorVersion>1.0.0-alpha.20251103.3</UnbrandedGeneratorVersion>
476+
<UnbrandedGeneratorVersion>1.0.0-alpha.20251103.8</UnbrandedGeneratorVersion>
477477
<AzureGeneratorVersion>1.0.0-alpha.20251022.3</AzureGeneratorVersion>
478478
</PropertyGroup>
479479
</Project>

eng/http-client-csharp-emitter-package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

eng/http-client-csharp-emitter-package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"main": "dist/src/index.js",
33
"dependencies": {
44
"client-plugin": "file:../../../../eng/packages/plugins/client",
5-
"@typespec/http-client-csharp": "1.0.0-alpha.20251103.3"
5+
"@typespec/http-client-csharp": "1.0.0-alpha.20251103.8"
66
},
77
"devDependencies": {
88
"@azure-tools/typespec-client-generator-core": "0.61.0",

eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
using Azure.Core;
55
using Microsoft.TypeSpec.Generator.ClientModel.Providers;
66
using Microsoft.TypeSpec.Generator.Expressions;
7+
using Microsoft.TypeSpec.Generator.Snippets;
78
using Microsoft.TypeSpec.Generator.Statements;
89
using System;
910
using System.Collections.Generic;
10-
using Microsoft.TypeSpec.Generator.Snippets;
1111
using static Microsoft.TypeSpec.Generator.Snippets.Snippet;
1212

1313
namespace Azure.Generator.Providers
@@ -29,6 +29,9 @@ public override ValueExpression Content()
2929
public override HttpRequestApi FromExpression(ValueExpression original)
3030
=> new HttpRequestProvider(original);
3131

32+
public override ValueExpression ClientRequestId()
33+
=> Original.Property(nameof(Request.ClientRequestId));
34+
3235
public override MethodBodyStatement SetHeaders(IReadOnlyList<ValueExpression> arguments)
3336
=> Original.Property(nameof(Request.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments).Terminate();
3437

eng/packages/http-client-csharp/generator/Azure.Generator/src/Visitors/RequestClientIdHeaderVisitor.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ internal class RequestClientIdHeaderVisitor : ScmLibraryVisitor
4646
var newStatements = new List<MethodBodyStatement>(originalBodyStatements[..^1]);
4747

4848
// Find the request variable
49-
VariableExpression? requestVariable = null;
49+
HttpRequestApi? requestVariable = null;
5050
foreach (var statement in newStatements)
5151
{
5252
if (statement is ExpressionStatement
@@ -57,7 +57,7 @@ internal class RequestClientIdHeaderVisitor : ScmLibraryVisitor
5757
var variable = declaration.Variable;
5858
if (variable.Type.Equals(variable.ToApi<HttpRequestApi>().Type))
5959
{
60-
requestVariable = variable;
60+
requestVariable = variable.ToApi<HttpRequestApi>();
6161
}
6262
}
6363
}
@@ -67,7 +67,7 @@ internal class RequestClientIdHeaderVisitor : ScmLibraryVisitor
6767
// Set the client-request-id header
6868
newStatements.Add(requestVariable.As<Request>().SetHeaderValue(
6969
clientRequestIdParameter.SerializedName,
70-
requestVariable.Property(nameof(Request.ClientRequestId))));
70+
requestVariable.ClientRequestId()));
7171
}
7272

7373
// Add the return statement back

eng/packages/http-client-csharp/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

eng/packages/http-client-csharp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"dist/generator/**"
3939
],
4040
"dependencies": {
41-
"@typespec/http-client-csharp": "1.0.0-alpha.20251103.3"
41+
"@typespec/http-client-csharp": "1.0.0-alpha.20251103.8"
4242
},
4343
"devDependencies": {
4444
"@azure-tools/azure-http-specs": "0.1.0-alpha.30",

0 commit comments

Comments
 (0)