Use parameter sets to determine filter expression, exit on failure of dotnet build (#54031)

* Use parameter sets to determine filter expression, exit on failure of dotnet build

* Re-add -ErrorAction SilentlyContinue

* Use runwithdevopslogging.ps1

* Parameter attribute

* Remove exit logic

* Use Invoke-LoggedMsbuildCommand directly

Author: danieljurek

eng/scripts/Export-API.ps1

@@ -1,10 +1,14 @@
 [CmdletBinding()]
 param (
-    [Parameter(Position=0)]
+    [Parameter(Position=0, Mandatory=$true, ParameterSetName='ServiceDirectory')]
     [string] $ServiceDirectory,
+
     [string] $SDKType = "all",
     [switch] $SpellCheckPublicApiSurface,
+
+    [Parameter(Mandatory=$true, ParameterSetName='PackagePath')]
     [string] $PackagePath,
+    [Parameter(Mandatory=$true, ParameterSetName='PackagePath')]
     [string] $SdkRepoPath
 )
 
@@ -13,10 +17,14 @@ if ($SpellCheckPublicApiSurface -and -not (Get-Command 'npx')) {
     exit 1
 }
 
-$relativePackagePath = if ($PackagePath) {
-    Resolve-Path -Relative -RelativeBasePath (Join-Path $SdkRepoPath "sdk") -Path $PackagePath
-} else {
-    $ServiceDirectory
+. $PSScriptRoot/../common/scripts/Helpers/CommandInvocation-Helpers.ps1
+
+$relativePackagePath = $ServiceDirectory
+$apiListingFilesFilter = "$PSScriptRoot/../../sdk/$ServiceDirectory/*/api/*.cs"
+
+if ($PSCmdlet.ParameterSetName -eq 'PackagePath') {
+    $relativePackagePath = Resolve-Path -Relative -RelativeBasePath (Join-Path $SdkRepoPath "sdk") -Path $PackagePath
+    $apiListingFilesFilter = "$PSScriptRoot/../../sdk/$relativePackagePath/api/*.cs"
 }
 
 $servicesProj = Resolve-Path "$PSScriptRoot/../service.proj"
@@ -25,11 +33,11 @@ $debugLogging = $env:SYSTEM_DEBUG -eq "true"
 $logsFolder = $env:BUILD_ARTIFACTSTAGINGDIRECTORY
 $diagnosticArguments = ($debugLogging -and $logsFolder) ? "/binarylogger:$logsFolder/exportapi.binlog" : ""
 
-dotnet build /t:ExportApi /p:RunApiCompat=false /p:InheritDocEnabled=false /p:GeneratePackageOnBuild=false /p:Configuration=Release /p:IncludeSamples=false /p:IncludePerf=false /p:IncludeStress=false /p:IncludeTests=false /p:Scope="$relativePackagePath" /p:SDKType=$SDKType /restore $servicesProj $diagnosticArguments
+Invoke-LoggedMsbuildCommand "dotnet build /t:ExportApi /p:RunApiCompat=false /p:InheritDocEnabled=false /p:GeneratePackageOnBuild=false /p:Configuration=Release /p:IncludeSamples=false /p:IncludePerf=false /p:IncludeStress=false /p:IncludeTests=false /p:Scope=`"$relativePackagePath`" /p:SDKType=$SDKType /restore $servicesProj $diagnosticArguments"
 
 # Normalize line endings to LF in generated API listing files
 Write-Host "Normalizing line endings in API listing files"
-$apiListingFiles = Get-ChildItem -Path "$PSScriptRoot/../../sdk/$relativePackagePath/*/api/*.cs" -ErrorAction SilentlyContinue
+$apiListingFiles = Get-ChildItem -Path $apiListingFilesFilter -ErrorAction SilentlyContinue
 foreach ($file in $apiListingFiles) {
     $content = Get-Content -Path $file.FullName -Raw
     if ($content) {