Refine constructor parameters and IEnumerable implementation for ResourceCollection (#53635)

* wip

* refine when to skip IEnumerable implementation

* refine

* regen

* rename

* convert parameter type for fields

Author: live1206

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ResourceCollectionClientProvider.cs

@@ -37,6 +37,7 @@ internal sealed class ResourceCollectionClientProvider : TypeProvider
         // Cached Get method providers
         private MethodProvider? _getAsyncMethodProvider;
         private MethodProvider? _getSyncMethodProvider;
+        private MethodProvider? _getAllSyncMethodProvider;
 
         // Support for multiple rest clients
         private readonly Dictionary<InputClient, RestClientInfo> _clientInfos;
@@ -52,14 +53,15 @@ internal ResourceCollectionClientProvider(ResourceClientProvider resource, Input
             _contextualPath = GetContextualRequestPattern(resourceMetadata);
             _resource = resource;
 
-            _pathParameterMap = BuildPathParameterMap();
-
             // Initialize client info dictionary using extension method
             _clientInfos = resourceMetadata.CreateClientInfosMap(this);
 
             _resourceTypeExpression = Static(_resource.Type).As<ArmResource>().ResourceType();
 
             InitializeMethods(resourceMethods, ref _get, ref _create, ref _getAll);
+
+            // this depends on _getAll being initialized
+            _pathParameterMap = BuildPathParameterMap();
         }
 
         /// <summary>
@@ -147,7 +149,7 @@ protected override CSharpType[] BuildImplements() =>
 
         private bool ShouldSkipIEnumerableImplementation()
         {
-            return _getAll is null || _getAll.InputMethod.Parameters.Any(p => p.DefaultValue != null);
+            return _getAllSyncMethodProvider is null || _getAllSyncMethodProvider.Signature.Parameters.Any(p => p.DefaultValue is null);
         }
 
         protected override PropertyProvider[] BuildProperties()
@@ -172,12 +174,14 @@ protected override PropertyProvider[] BuildProperties()
         private Dictionary<ParameterProvider, FieldProvider> BuildPathParameterMap()
         {
             var map = new Dictionary<ParameterProvider, FieldProvider>();
-            var diff = ContextualPath.TrimAncestorFrom(Resource.ContextualPath);
-            var variableSegments = diff.Where(seg => !seg.IsConstant).ToList();
-            if (variableSegments.Count > 0)
+            if (_getAll is null)
             {
-                variableSegments.RemoveAt(variableSegments.Count - 1);
+                return map;
             }
+
+            var diff = ContextualPath.TrimAncestorFrom(new RequestPathPattern(_getAll.OperationPath));
+            var variableSegments = diff.Where(seg => !seg.IsConstant).ToList();
+
             foreach (var seg in variableSegments)
             {
                 var parameter = new ParameterProvider(
@@ -295,10 +299,10 @@ private MethodProvider[] BuildGetAllMethods()
             }
 
             // implement paging method GetAll
-            var getAll = BuildGetAllMethod(_getAll, false);
+            _getAllSyncMethodProvider = BuildGetAllMethod(_getAll, false);
             var getAllAsync = BuildGetAllMethod(_getAll, true);
 
-            return [getAllAsync, getAll];
+            return [getAllAsync, _getAllSyncMethodProvider];
         }
 
         private MethodProvider[] BuildEnumeratorMethods()

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/RequestPathPatternExtensions.cs

@@ -38,7 +38,7 @@ public static IReadOnlyList<ValueExpression> PopulateArguments(
                 //Find matching parameter from pathFieldsParameters if enclosing type is ResourceCollectionClientProvider
                 else if (enclosingType is ResourceCollectionClientProvider collectionProvider && collectionProvider.TryGetPrivateFieldParameter(parameter, out var matchingField) && matchingField != null)
                 {
-                    arguments.Add(matchingField);
+                    arguments.Add(Convert(matchingField, matchingField.Type, parameter.Type));
                 }
                 else if (parameter.Type.Equals(typeof(RequestContent)))
                 {