Regenerate Azure.Provisioning.CognitiveServices #54123
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
ericsuh
force-pushed
the
ericsuh/provisioning-cogser-update
branch
6 times, most recently
from
22e7f40 to
0ef689b
Compare
This fixees the error that showed up when running `eng\scripts\CodeChecks.ps1 -ServiceDirectory core` on the `main` branch merge base with this PR.
ericsuh
force-pushed
the
ericsuh/provisioning-cogser-update
branch
from
0ef689b to
4874214
Compare
ericsuh
requested review from
a team,
ArcturusZhang,
ArthurMa1978,
KrzysztofCwalina,
christothes,
jorgerangel-msft,
jsquire and
m-nash
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request regenerates Azure.Provisioning.CognitiveServices to use version 1.5.2 of Azure.ResourceManager.CognitiveServices, which includes the newer Foundry APIs announced at Ignite. The changes update default API versions and add new resource types and models for AI Foundry capabilities.
Key Changes
- Updated default resource versions: CognitiveServices resources from
2024-10-01to2025-09-01, Authorization resources from2025-01-01to2025-03-01 - Added new AI Foundry resource types:
CognitiveServicesProject,CognitiveServicesConnection,CognitiveServicesCapabilityHost, and their project-level variants - Added extensive connection property types supporting various authentication methods (AAD, OAuth2, AccessKey, ServicePrincipal, etc.)
- Fixed consuming code to explicitly specify resource versions where tests assumed fixed versions
Reviewed changes
Copilot reviewed 10 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/provisioning/Azure.Provisioning.CognitiveServices/src/Generated/*.cs | Updated resource versions to 2025-09-01, added new AI Foundry resource types and models |
| sdk/provisioning/Azure.Provisioning/src/Generated/*.cs | Updated Authorization resource versions to 2025-03-01 |
| sdk/provisioning/Azure.Provisioning.CognitiveServices/tests/BasicCognitiveServicesTests.cs | Updated expected Bicep template version from 2024-10-01 to 2025-09-01 |
| sdk/cloudmachine/Azure.Projects.AI/src//.cs | Fixed by explicitly specifying resourceVersion: "2024-10-01" to maintain compatibility |
| eng/Packages.Data.props | Added version constraint for Azure.ResourceManager.CognitiveServices 1.5.2 in Generator projects |
| sdk/provisioning/Azure.Provisioning.CognitiveServices/api/*.cs | Updated API surface files with new types and version constants |
| .editorconfig | Added exception for bicep test files to not insert final newline |
| <PackageReference Update="Humanizer.Core" Version="2.14.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$(MSBuildProjectName.StartsWith('Generator'))"> |
There was a problem hiding this comment.
Please explain this entry. The condition is overly generalized and I'd like to understand the scenario where this reference is needed.
There was a problem hiding this comment.
This is targeting just the Generator package under Azure.Provisioning, which seems to just be named Generator.
I'm happy to try to target it even more granularly, but I would appreciate some help in how to do that, as I'm new to .NET/C#.
There was a problem hiding this comment.
The Resource Manager libraries are generally approved for current generation libraries, as they're known safe and under our control. I'd suggest just adding this in this section unconditionally, in alphabetical order by package name.
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Please revert. There's no reason this file should be in this PR.
There was a problem hiding this comment.
Tests were failing without this for me
There was a problem hiding this comment.
The line exists already, and this looks like a noop change. Was there a non-printable in there? Can you share the error message?
Revert changes
Add new line
2 participants
This updates
Azure.Provisioning.CognitiveServicesto use a newer version ofAzure.ResourceManager.CognitiveServicesthat have the newer Foundry APIs launched at Ignite.This also fixes some code that consumes
Azure.Provisioning.CognitiveServices, where the consuming code had a "floating" default resource version but the test assumed a fixed version.