Skip to content

Regenerate Azure.Provisioning.CognitiveServices #54123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Regenerate Azure.Provisioning.CognitiveServices #54123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9054888
Update dependency version for Azure.Provisioning Generator project
Nov 25, 2025
10ceb0e
Rerun Azure.Provisioning Generator
Nov 25, 2025
43130c6
Fix tests
Nov 26, 2025
4874214
Fix error in unrelated file
Nov 25, 2025
09ad7e9
Update .editorconfig
ericsuh Nov 27, 2025
17bd33c
Update .editorconfig
ericsuh Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@
<PackageReference Update="Humanizer.Core" Version="2.14.1" />
</ItemGroup>

<ItemGroup Condition="$(MSBuildProjectName.StartsWith('Generator'))">
Copy link
Member

@jsquire jsquire Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain this entry. The condition is overly generalized and I'd like to understand the scenario where this reference is needed.

Copy link
Member Author

@ericsuh ericsuh Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is targeting just the Generator package under Azure.Provisioning, which seems to just be named Generator.

I'm happy to try to target it even more granularly, but I would appreciate some help in how to do that, as I'm new to .NET/C#.

Copy link
Member

@jsquire jsquire Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Resource Manager libraries are generally approved for current generation libraries, as they're known safe and under our control. I'd suggest just adding this in this section unconditionally, in alphabetical order by package name.

<PackageReference Update="Azure.ResourceManager.CognitiveServices" Version="1.5.2" />
</ItemGroup>

<!--
Dependency versions for Track 2, Microsoft.* libraries.
These are dependencies for Track 2 integration packages
Expand Down
2 changes: 1 addition & 1 deletion sdk/cloudmachine/Azure.Projects.AI/src/MaaS/AIServiceFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public AIModelsFeature(string model, string modelVersion)
/// <param name="infrastructure"></param>
protected override void EmitConstructs(ProjectInfrastructure infrastructure)
{
CognitiveServicesAccount cognitiveServices = new("aiservices")
CognitiveServicesAccount cognitiveServices = new("aiservices", resourceVersion: "2024-10-01")
{
Name = infrastructure.ProjectId,
Kind = "AIServices",
Expand Down
2 changes: 1 addition & 1 deletion sdk/cloudmachine/Azure.Projects.AI/src/OpenAI/OpenAIAccountFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public OpenAIAccountFeature(CognitiveServicesSku? sku = default)
/// <param name="infrastructure"></param>
protected override void EmitConstructs(ProjectInfrastructure infrastructure)
{
CognitiveServicesAccount cognitiveServices = new("openai")
CognitiveServicesAccount cognitiveServices = new("openai", resourceVersion: "2024-10-01")
{
Name = infrastructure.ProjectId,
Kind = "OpenAI",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/src/GeoJson/GeoPoint.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Member

@jsquire jsquire Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert. There's no reason this file should be in this PR.

Copy link
Member Author

@ericsuh ericsuh Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were failing without this for me

Copy link
Member

@jsquire jsquire Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line exists already, and this looks like a noop change. Was there a non-printable in there? Can you share the error message?

// Licensed under the MIT License.

using System;
Expand Down
433 changes: 433 additions & 0 deletions ...g/Azure.Provisioning.CognitiveServices/api/Azure.Provisioning.CognitiveServices.net8.0.cs
View file
Open in desktop

Large diffs are not rendered by default.

433 changes: 433 additions & 0 deletions ...Provisioning.CognitiveServices/api/Azure.Provisioning.CognitiveServices.netstandard2.0.cs
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 12 additions & 1 deletion ...ovisioning/Azure.Provisioning.CognitiveServices/src/Generated/CognitiveServicesAccount.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion .../Azure.Provisioning.CognitiveServices/src/Generated/CognitiveServicesAccountDeployment.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

128 changes: 128 additions & 0 deletions ...ing/Azure.Provisioning.CognitiveServices/src/Generated/CognitiveServicesCapabilityHost.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion ...ing/Azure.Provisioning.CognitiveServices/src/Generated/CognitiveServicesCommitmentPlan.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading