-
Notifications
You must be signed in to change notification settings - Fork 5.1k
MPG migration - hardwaresecuritymodules #54198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MPG migration - hardwaresecuritymodules #54198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements an MPG (Management Plane Generator) migration for the hardwaresecuritymodules SDK. The changes update the generator infrastructure and regenerate SDK code with a new pattern that uses protocol methods and RequestContext instead of strongly-typed parameters.
Key Changes:
- Updated commit reference and added emitter package configuration in tsp-location.yaml
- Refactored RestOperations classes to use protocol-style methods with
RequestContextandRequestContentparameters - Changed subscriptionId parameter type from
stringtoGuidthroughout - Replaced strongly-typed data models in request methods with
RequestContent - Updated serialization patterns across all model classes
Reviewed changes
Copilot reviewed 3 out of 143 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated commit reference and added emitterPackageJsonPath for MPG configuration |
| PrivateEndpointConnectionsRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style with RequestContext |
| DedicatedHsmsRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style with RequestContext |
| CloudHsmClustersRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style with RequestContext |
| CloudHsmClusterRestoreStatusRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style |
| CloudHsmClusterPrivateLinkResourcesRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style |
| CloudHsmClusterBackupStatusRestOperations.cs | Renamed class, removed high-level methods, converted to protocol-style |
| ProviderConstants.cs | Added partial modifier and XML documentation |
| SecurityDomainActivationState.cs | Enhanced with additional operator overloads and documentation |
| PrivateEndpoint.cs | New model file for private endpoint resource |
| PrivateEndpoint.Serialization.cs | New serialization implementation for PrivateEndpoint |
| HardwareSecurityModulesPrivateLinkResourceListResult.cs | Updated field names and collection types |
| HardwareSecurityModulesPrivateEndpointConnectionListResult.cs | Updated field names and collection types |
| DedicatedHsmSkuName.cs | Enhanced with additional operator overloads and documentation |
| DedicatedHsmSku.cs | Renamed internal fields following new naming convention |
| DedicatedHsmProperties.cs | Renamed internal fields following new naming convention |
| DedicatedHsmPatch.cs | Renamed internal fields, added null handling for dictionary values |
| DedicatedHsmNetworkProfile.cs | Reordered properties, improved property accessor formatting |
| DedicatedHsmNetworkInterface.cs | Renamed internal fields following new naming convention |
| DedicatedHsmListResult.cs | Updated field names and collection types |
| DedicatedHsmJsonWebKeyType.cs | Enhanced with additional operator overloads and documentation |
| DedicatedHsmEndpointDetail.cs | Renamed internal fields following new naming convention |
| DedicatedHsmEndpointDependency.cs | Renamed internal fields following new naming convention |
| CloudHsmClusterSkuName.cs | Updated XML documentation comments for enum values |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.