Skip to content

Conversation

@haiyuazhang
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings November 27, 2025 15:55
@haiyuazhang haiyuazhang marked this pull request as draft November 27, 2025 15:55
Copilot finished reviewing on behalf of haiyuazhang November 27, 2025 15:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements an MPG (Management Plane Generator) migration for the hardwaresecuritymodules SDK. The changes update the generator infrastructure and regenerate SDK code with a new pattern that uses protocol methods and RequestContext instead of strongly-typed parameters.

Key Changes:

  • Updated commit reference and added emitter package configuration in tsp-location.yaml
  • Refactored RestOperations classes to use protocol-style methods with RequestContext and RequestContent parameters
  • Changed subscriptionId parameter type from string to Guid throughout
  • Replaced strongly-typed data models in request methods with RequestContent
  • Updated serialization patterns across all model classes

Reviewed changes

Copilot reviewed 3 out of 143 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updated commit reference and added emitterPackageJsonPath for MPG configuration
PrivateEndpointConnectionsRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style with RequestContext
DedicatedHsmsRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style with RequestContext
CloudHsmClustersRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style with RequestContext
CloudHsmClusterRestoreStatusRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style
CloudHsmClusterPrivateLinkResourcesRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style
CloudHsmClusterBackupStatusRestOperations.cs Renamed class, removed high-level methods, converted to protocol-style
ProviderConstants.cs Added partial modifier and XML documentation
SecurityDomainActivationState.cs Enhanced with additional operator overloads and documentation
PrivateEndpoint.cs New model file for private endpoint resource
PrivateEndpoint.Serialization.cs New serialization implementation for PrivateEndpoint
HardwareSecurityModulesPrivateLinkResourceListResult.cs Updated field names and collection types
HardwareSecurityModulesPrivateEndpointConnectionListResult.cs Updated field names and collection types
DedicatedHsmSkuName.cs Enhanced with additional operator overloads and documentation
DedicatedHsmSku.cs Renamed internal fields following new naming convention
DedicatedHsmProperties.cs Renamed internal fields following new naming convention
DedicatedHsmPatch.cs Renamed internal fields, added null handling for dictionary values
DedicatedHsmNetworkProfile.cs Reordered properties, improved property accessor formatting
DedicatedHsmNetworkInterface.cs Renamed internal fields following new naming convention
DedicatedHsmListResult.cs Updated field names and collection types
DedicatedHsmJsonWebKeyType.cs Enhanced with additional operator overloads and documentation
DedicatedHsmEndpointDetail.cs Renamed internal fields following new naming convention
DedicatedHsmEndpointDependency.cs Renamed internal fields following new naming convention
CloudHsmClusterSkuName.cs Updated XML documentation comments for enum values

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant