Skip to content

Conversation

@audunn
Copy link
Member

@audunn audunn commented Nov 28, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Release Plan Details

Copilot AI review requested due to automatic review settings November 28, 2025 20:41
@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Nov 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Azure NetApp Files SDK from API version 2025-09-01 to 2025-09-01-preview, introducing preview features for elastic resources, caching, ransomware protection, and LDAP configuration.

Key Changes:

  • API version bump from stable to preview release
  • Refactored object initialization to use object initializers instead of constructor parameters
  • Added support for 9 new elastic resource types (Cache, ElasticAccount, ElasticPool, ElasticVolume, ElasticSnapshotPolicy, ElasticSnapshot, ElasticBackupVault, ElasticBackupPolicy, ElasticBackup)

Reviewed changes

Copilot reviewed 3 out of 426 changed files in this pull request and generated 2 comments.

File Description
sdk/netapp/Azure.ResourceManager.NetApp/src/Custom/ArmNetAppModelFactory.cs Updated NetAppVolumePatch instantiation to use object initializer syntax
sdk/netapp/Azure.ResourceManager.NetApp/assets.json Updated asset tag reference for new API version
sdk/netapp/Azure.ResourceManager.NetApp/CHANGELOG.md Documented API version upgrade and new features including elastic resources, ransomware protection, and LDAP configuration

- Added `ActiveDirectory` resource type
- Added `RansomwareReport` resource type, Support for Advance AntiRansomware features
- Added `LdapConfiguration` to `NetAppAccountResource` to support LDAP configuration at account level
- Added `LargeVolumeType` and `` to `NetAppVolumeResource` to support ExtraLargeVolumes
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete documentation: the second property name after 'LargeVolumeType' is missing. Please specify the complete property name that was added to support ExtraLargeVolumes.

Suggested change
- Added `LargeVolumeType` and `` to `NetAppVolumeResource` to support ExtraLargeVolumes
- Added `LargeVolumeType` and `ExtraLargeVolumeType` to `NetAppVolumeResource` to support ExtraLargeVolumes

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.NetApp

@audunn audunn requested a review from jsquire as a code owner November 29, 2025 00:06
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@audunn:

Your account lacks the public membership to the Microsoft GitHub organization required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants